[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation
From: |
no-reply |
Subject: |
Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation |
Date: |
Fri, 13 Dec 2019 17:43:07 -0800 (PST) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH 00/10] Fixes for DP8393X SONIC device emulation
Type: series
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
702b708 dp8393x: Don't clobber packet checksum
a6efce5 dp8393x: Don't stop reception upon RBE interrupt assertion
8f04361 dp8393x: Implement packet size limit and RBAE interrupt
19bdaec dp8393x: Implement TBWC0 and TBWC1 registers to restore buffer state
d4634fd dp8393x: Clear RRRA command register bit only when appropriate
39e35db dp8393x: Update LLFA register
240cef4 dp8393x: Don't advance RX descriptor twice
ba2922d dp8393x: Have dp8393x_receive() return the packet size
8e1c5a6 dp8393x: Clean up endianness hacks
9c9ffc3 dp8393x: Mask EOL bit from descriptor addresses
=== OUTPUT BEGIN ===
1/10 Checking commit 9c9ffc38e9b9 (dp8393x: Mask EOL bit from descriptor
addresses)
ERROR: return is not a function, parentheses are not required
#24: FILE: hw/net/dp8393x.c:200:
+ return (s->regs[SONIC_URDA] << 16) | (s->regs[SONIC_CRDA] & 0xfffe);
ERROR: return is not a function, parentheses are not required
#33: FILE: hw/net/dp8393x.c:220:
+ return (s->regs[SONIC_UTDA] << 16) | (s->regs[SONIC_TTDA] & 0xfffe);
total: 2 errors, 0 warnings, 26 lines checked
Patch 1/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit 8e1c5a688838 (dp8393x: Clean up endianness hacks)
3/10 Checking commit ba2922dc3e93 (dp8393x: Have dp8393x_receive() return the
packet size)
4/10 Checking commit 240cef4caaee (dp8393x: Don't advance RX descriptor twice)
5/10 Checking commit 39e35db107bd (dp8393x: Update LLFA register)
6/10 Checking commit d4634fdd244c (dp8393x: Clear RRRA command register bit
only when appropriate)
7/10 Checking commit 19bdaec299f1 (dp8393x: Implement TBWC0 and TBWC1 registers
to restore buffer state)
8/10 Checking commit 8f04361b6bc8 (dp8393x: Implement packet size limit and
RBAE interrupt)
9/10 Checking commit a6efce5b17d0 (dp8393x: Don't stop reception upon RBE
interrupt assertion)
10/10 Checking commit 702b708cf099 (dp8393x: Don't clobber packet checksum)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [PATCH 04/10] dp8393x: Don't advance RX descriptor twice, (continued)
- [PATCH 04/10] dp8393x: Don't advance RX descriptor twice, Finn Thain, 2019/12/13
- [PATCH 06/10] dp8393x: Clear RRRA command register bit only when appropriate, Finn Thain, 2019/12/13
- [PATCH 02/10] dp8393x: Clean up endianness hacks, Finn Thain, 2019/12/13
- [PATCH 01/10] dp8393x: Mask EOL bit from descriptor addresses, Finn Thain, 2019/12/13
- [PATCH 03/10] dp8393x: Have dp8393x_receive() return the packet size, Finn Thain, 2019/12/13
- [PATCH 08/10] dp8393x: Implement packet size limit and RBAE interrupt, Finn Thain, 2019/12/13
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation,
no-reply <=
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Aleksandar Markovic, 2019/12/14
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Finn Thain, 2019/12/14
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Aleksandar Markovic, 2019/12/14
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Aleksandar Markovic, 2019/12/14
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Finn Thain, 2019/12/19
- Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Philippe Mathieu-Daudé, 2019/12/23
- NetBSD/arc on MIPS Magnum, was Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation, Finn Thain, 2019/12/23