[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/arm: Display helpful message when hflags mismatch
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH] target/arm: Display helpful message when hflags mismatch |
|
Date: |
Wed, 11 Dec 2019 16:36:24 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 |
On 12/9/19 8:00 AM, Alex Bennée wrote:
>> -#ifdef CONFIG_DEBUG_TCG
>> - assert(flags == rebuild_hflags_internal(env));
>> -#endif
>> + assert_hflags_rebuild_correctly(env);
>
> I'm trying to recall why we don't just use:
>
> g_assert_cmphex(flags, =, rebuild_hflags_internal(env))
>
> I think it came up in one of the reviews.
checkpatch.pl.
Because, I believe, there is an environment variable that causes this to *not*
abort on mismatch.
r~