qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/26] qdev: remove duplicated qdev_property_add_static() doc


From: Damien Hedde
Subject: Re: [PATCH 02/26] qdev: remove duplicated qdev_property_add_static() doc
Date: Wed, 11 Dec 2019 16:42:56 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0


On 12/1/19 12:15 PM, Marc-André Lureau wrote:
> The function is already documented in the header.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  hw/core/qdev.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index c7b3f0dec5..8b93b85727 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -717,16 +717,6 @@ static void qdev_property_add_legacy(DeviceState *dev, 
> Property *prop,
>      g_free(name);
>  }
>  
> -/**
> - * qdev_property_add_static:
> - * @dev: Device to add the property to.
> - * @prop: The qdev property definition.
> - * @errp: location to store error information.
> - *
> - * Add a static QOM property to @dev for qdev property @prop.
> - * On error, store error in @errp.  Static properties access data in a 
> struct.
> - * The type of the QOM property is derived from prop->info.
> - */
>  void qdev_property_add_static(DeviceState *dev, Property *prop,
>                                Error **errp)
>  {
> 

Reviewed-by: Damien Hedde <address@hidden>

Regards,
--
Damien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]