[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build-sys: build vhost-user-gpu only if CONFIG_TOOLS
From: |
Thomas Huth |
Subject: |
Re: [PATCH] build-sys: build vhost-user-gpu only if CONFIG_TOOLS |
Date: |
Wed, 11 Dec 2019 15:38:31 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 11/12/2019 15.23, Paolo Bonzini wrote:
> From: Marc-André Lureau <address@hidden>
>
> vhost-user-gpu is always built and installed, but it is not part of the
> emulator
> proper. Cut it if --disable-tools is specified.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> Makefile | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 53823c2..8d921c6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -321,14 +321,10 @@ HELPERS-y =
>
> HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) =
> qemu-bridge-helper$(EXESUF)
>
> -ifdef CONFIG_LINUX
> -ifdef CONFIG_VIRGL
> -ifdef CONFIG_GBM
> +ifeq ($(CONFIG_LINUX)$(CONFIG_VIRGL)$(CONFIG_GBM)$(CONFIG_TOOLS),yyyy)
> HELPERS-y += vhost-user-gpu$(EXESUF)
> vhost-user-json-y += contrib/vhost-user-gpu/50-qemu-gpu.json
> endif
> -endif
> -endif
Reviewed-by: Thomas Huth <address@hidden>