Re: [PATCH 1/2] net: Drop the legacy "name" parameter from the -net option

[Markus Armbruster]

Thomas Huth <address@hidden> writes:

> It's been deprecated since QEMU v3.1, so it's time to finally
> remove it. The "id" parameter can simply be used instead.
>
> Signed-off-by: Thomas Huth <address@hidden>
[...]
> diff --git a/qapi/net.json b/qapi/net.json
> index 335295be50..ff280ccd16 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -488,18 +488,16 @@
>  #
>  # @id: identifier for monitor commands
>  #
> -# @name: identifier for monitor commands, ignored if @id is present
> -#
>  # @opts: device type specific properties (legacy)
>  #
>  # Since: 1.2
>  #
>  # 'vlan': dropped in 3.0
> +# 'name': dropped in 5.0
>  ##

Uh, when did we start to add "dropped in" to our doc comments?

We should either do this systematically, or not at all.  If the former,
we have quite a few "dropped in" to add belatedly.

I vote for "not at all".

>  { 'struct': 'NetLegacy',
>    'data': {
>      '*id':   'str',
> -    '*name': 'str',
>      'opts':  'NetLegacyOptions' } }
>  
>  ##
[...]

History:

$ git-log -S"dropped in" -- qapi qapi-schema.json
commit ffaee83bcb28913b8b854aeab78b1a1f2115712d
Author: Markus Armbruster <address@hidden>
Date:   Tue Jul 9 17:20:53 2019 +0200

    qapi: Move query-target from misc.json to machine.json
    
    Move query-target and its return type TargetInfo from misc.json to
    machine.json, where they are covered by MAINTAINERS section "Machine
    core".  Also move its implementation from arch_init.c to
    hw/core/machine-qmp-cmds, where it is likewise covered.
    
    All users of SysEmuTarget are now in machine.json.  Move it there from
    common.json.
    
    Signed-off-by: Markus Armbruster <address@hidden>
    Message-Id: <address@hidden>

commit 416756cc049006ab8a05fe39e5f2e6af25cad9d2
Author: Thomas Huth <address@hidden>
Date:   Tue Aug 21 13:27:48 2018 +0200

    Record history of ppcemb target in common.json
    
    We recently removed the long deprecated "ppcemb" target.  This adds a
    comment in common.json about the SysEmuTarget type, recording when it was
    removed.
    
    Suggested-by: Eric Blake <address@hidden>
    Signed-off-by: David Gibson <address@hidden>

commit 4088b5536436090207dcf6d15e47908f74b2d8f2
Author: Thomas Huth <address@hidden>
Date:   Tue May 15 18:26:20 2018 +0200

    qapi/net.json: Fix the version number of the "vlan" removal
    
    "vlan" will be dropped in 2.13, not in 2.12. And while we're at it,
    use the better wording "dropped in" instead of "removed with" (also
    for the "dump" removal).
    
    Reported-by: Stefan Hajnoczi <address@hidden>
    Reported-by: Eric Blake <address@hidden>
    Signed-off-by: Thomas Huth <address@hidden>
    Reviewed-by: Eric Blake <address@hidden>
    Signed-off-by: Michael Tokarev <address@hidden>

commit 608cfed66a6adeac136b0c09cd62d081062256f3
Author: Markus Armbruster <address@hidden>
Date:   Thu Aug 24 21:14:00 2017 +0200

    qapi-schema: Collect UI stuff in qapi/ui.json
    
    UI stuff is remote desktop stuff (Spice, VNC) and input stuff (mouse,
    keyboard).
    
    Cc: Gerd Hoffmann <address@hidden>
    Signed-off-by: Markus Armbruster <address@hidden>
    Message-Id: <address@hidden>
    Reviewed-by: Marc-André Lureau <address@hidden>
    Reviewed-by: Gerd Hoffmann <address@hidden>

commit 912092b8e47f31c3db25e088af8460d9e752da29
Author: Gerd Hoffmann <address@hidden>
Date:   Thu Jul 27 12:47:20 2017 +0200

    ui: drop altgr and altgr_r QKeyCodes
    
    The right alt key (alt_r aka KEY_RIGHTALT) is used for AltGr.
    The altgr and altgr_r keys simply don't exist.  Drop them.
    
    Signed-off-by: Gerd Hoffmann <address@hidden>
    Reviewed-by: Eric Blake <address@hidden>
    Message-id: address@hidden