[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseri
From: |
Bharata B Rao |
Subject: |
Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest |
Date: |
Tue, 10 Dec 2019 09:20:38 +0530 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Tue, Dec 10, 2019 at 02:28:51PM +1100, David Gibson wrote:
> On Mon, Dec 09, 2019 at 12:30:12PM +0530, Bharata B Rao wrote:
> > A pseries guest can be run as a secure guest on Ultravisor-enabled
> > POWER platforms. When such a secure guest is reset, we need to
> > release/reset a few resources both on ultravisor and hypervisor side.
> > This is achieved by invoking this new ioctl KVM_PPC_SVM_OFF from the
> > machine reset path.
> >
> > As part of this ioctl, the secure guest is essentially transitioned
> > back to normal mode so that it can reboot like a regular guest and
> > become secure again.
> >
> > This ioctl has no effect when invoked for a normal guest.
> >
> > Signed-off-by: Bharata B Rao <address@hidden>
> > ---
> > hw/ppc/spapr.c | 1 +
> > target/ppc/kvm.c | 7 +++++++
> > target/ppc/kvm_ppc.h | 6 ++++++
> > 3 files changed, 14 insertions(+)
> >
> > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> > index f11422fc41..4c7ad3400d 100644
> > --- a/hw/ppc/spapr.c
> > +++ b/hw/ppc/spapr.c
> > @@ -1597,6 +1597,7 @@ static void spapr_machine_reset(MachineState *machine)
> > void *fdt;
> > int rc;
> >
> > + kvmppc_svm_off();
>
> If you're going to have this return an error value, you should really
> check it here.
I could, by spapr_machine_reset() and the callers don't propagate the
errors up. So may be I could print a warning instead when ioctl fails?
Regards,
Bharata.
- [PATCH v1 ppc-for-5.0 0/2] ppc/spapr: Support reboot of secure pseries guest, Bharata B Rao, 2019/12/09
- [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest, Bharata B Rao, 2019/12/09
- Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest, David Gibson, 2019/12/09
- Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest,
Bharata B Rao <=
- Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest, Alexey Kardashevskiy, 2019/12/09
- Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest, David Gibson, 2019/12/10
- Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest, Bharata B Rao, 2019/12/10
- Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest, David Gibson, 2019/12/10
- Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest, Bharata B Rao, 2019/12/11
- Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest, David Gibson, 2019/12/11
- Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest, Bharata B Rao, 2019/12/12
[PATCH v1 ppc-for-5.0 1/2] linux-headers: Update, Bharata B Rao, 2019/12/09