[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.0 v2 22/23] iotests: Check that @replaces can replace f
From: |
Max Reitz |
Subject: |
Re: [PATCH for-5.0 v2 22/23] iotests: Check that @replaces can replace filters |
Date: |
Mon, 9 Dec 2019 16:17:04 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 03.12.19 16:58, Vladimir Sementsov-Ogievskiy wrote:
> 11.11.2019 19:02, Max Reitz wrote:
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> tests/qemu-iotests/041 | 46 ++++++++++++++++++++++++++++++++++++++
>> tests/qemu-iotests/041.out | 4 ++--
>> 2 files changed, 48 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
>> index ab0cb5b42f..9a00cf6f7b 100755
>> --- a/tests/qemu-iotests/041
>> +++ b/tests/qemu-iotests/041
>> @@ -1200,6 +1200,52 @@ class TestOrphanedSource(iotests.QMPTestCase):
>> self.assertFalse('mirror-filter' in nodes,
>> 'Mirror filter node did not disappear')
>>
>> +# Test cases for @replaces that do not necessarily involve Quorum
>> +class TestReplaces(iotests.QMPTestCase):
>> + # Each of these test cases needs their own block graph, so do not
>> + # create any nodes here
>> + def setUp(self):
>> + self.vm = iotests.VM()
>> + self.vm.launch()
>> +
>> + def tearDown(self):
>> + self.vm.shutdown()
>> + for img in (test_img, target_img):
>> + try:
>> + os.remove(img)
>> + except OSError:
>> + pass
>> +
>> + """
>> + Check that we can replace filter nodes.
>> + """
>
> PEP8 says, that doc string should appear after "def" line.
> (this applies to previous patch too)
OK. I just noticed that in some previous patch I also left them having
single quotes, which I should fix.
Max
signature.asc
Description: OpenPGP digital signature