Re: [PATCH RESEND 4/4] target/i386: Add notes for versioned CPU models

[Tao Xu]

On 12/5/2019 4:44 PM, Xiaoyao Li wrote:
> On 12/2/2019 2:32 PM, Tao Xu wrote:
> > Add which features are added or removed in this version. Remove the
> > changed model-id in versioned CPU models.
> >
> > Signed-off-by: Tao Xu <address@hidden>
> > ---
> >    target/i386/cpu.c | 50 +++++++++++++++++++++++------------------------
> >    1 file changed, 25 insertions(+), 25 deletions(-)
> >
> > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> > index 7b3bd6d4db..c82fbfd02e 100644
> > --- a/target/i386/cpu.c
> > +++ b/target/i386/cpu.c
>
> [...]
>
> > @@ -3141,6 +3133,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
> >            .versions = (X86CPUVersionDefinition[]) {
> >                { .version = 1 },
> >                { .version = 2,
> > +              .note = "ARCH_CAPABILITIES",
>
> Here ARCH_CAPABILITIES doesn't tell what bits in
> MSR_IA32_ARCH_CAPABILITIES this version has, which makes it meaningless.
>
> Maybe
>          .note = "ARCH_CAPABLITIES(rdctl-no, ibrs-all, skip-l1dfl-vmentry, 
> mds-no)",
>
> is better?

But it is too long for -cpu help, break the info into 2 lines.