Re: [PATCH 1/4] target/arm: Add ID_AA64MMFR2_EL1

[Peter Maydell]

On Tue, 3 Dec 2019 at 23:42, Richard Henderson
<address@hidden> wrote:
>
> Add definitions for all of the fields, up to ARMv8.5.
> Convert the existing RESERVED register to a full register.
> Query KVM for the value of the register for the host.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/cpu.h    | 17 +++++++++++++++++
>  target/arm/helper.c |  4 ++--
>  target/arm/kvm64.c  |  2 ++
>  3 files changed, 21 insertions(+), 2 deletions(-)

> diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
> index 876184b8fe..482e7fdfbb 100644
> --- a/target/arm/kvm64.c
> +++ b/target/arm/kvm64.c
> @@ -549,6 +549,8 @@ bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures 
> *ahcf)
>                                ARM64_SYS_REG(3, 0, 0, 7, 0));
>          err |= read_sys_reg64(fdarray[2], &ahcf->isar.id_aa64mmfr1,
>                                ARM64_SYS_REG(3, 0, 0, 7, 1));
> +        err |= read_sys_reg64(fdarray[2], &ahcf->isar.id_aa64mmfr2,
> +                              ARM64_SYS_REG(3, 0, 0, 7, 2));

Do current KVM kernels definitely handle the request for this
new register (ie don't return an error)?

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM