[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] qapi: better document NVMe blockdev @device parameter
From: |
Daniel P . Berrangé |
Subject: |
[PATCH] qapi: better document NVMe blockdev @device parameter |
Date: |
Fri, 6 Dec 2019 14:38:11 +0000 |
Mention that this is a PCI device address & give the format it is
expected it. Also mention that it must be first unbound from any
host kernel driver.
Signed-off-by: Daniel P. Berrangé <address@hidden>
---
qapi/block-core.json | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 0cf68fea14..fcb52ec24f 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2963,9 +2963,13 @@
#
# Driver specific block device options for the NVMe backend.
#
-# @device: controller address of the NVMe device.
+# @device: PCI controller address of the NVMe device in
+# format hhhh:bb:ss.f (host:bus:slot.function)
# @namespace: namespace number of the device, starting from 1.
#
+# Note that the PCI @device must have been unbound from any host
+# kernel driver before instructing QEMU to add the blockdev.
+#
# Since: 2.12
##
{ 'struct': 'BlockdevOptionsNVMe',
--
2.23.0
- [PATCH] qapi: better document NVMe blockdev @device parameter,
Daniel P . Berrangé <=