Re: [PATCH 13/21] memory-device: Fix latent memory pre-plug error handling bugs

[Eric Blake]

On 12/1/19 11:07 PM, Markus Armbruster wrote:

> > >   {
> > > +    Error *err = NULL;

> > I remember that some time ago, the best practice was to use "local_err",
> > what is the latest state of that?
>
> Hundreds of local Error * variables are named @local_err, and hundreds
> more are named @err.
>
> For what it's worth, the big comment in error.h uses @err, except in one
> place where it needs two of them.

What's more, if we go through with Vladimir's Coccinelle cleanup to use 
ERRP_AUTO_PROPAGATE, then we don't have either name to worry about (both 
'&local_err' and '&err' are replaced by 'errp').

> > I still disagree that these are BUGs or even latent BUGs. If somebody
> > things these are BUGs and not cleanups, then we should probably have
> > proper "Fixes: " tags instead.
>
> Let's continue that discussion in the sub-thread where you first raised
> this objection.

One benefit of fixing the style (whether or not you count it as a bug 
fix) is that the Coccinelle script for updating to a new style is more 
likely to apply correctly.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org