[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] python/qemu: accel: Add list_accel() method
From: |
Alex Bennée |
Subject: |
Re: [PATCH 2/4] python/qemu: accel: Add list_accel() method |
Date: |
Tue, 03 Dec 2019 16:57:34 +0000 |
User-agent: |
mu4e 1.3.5; emacs 27.0.50 |
Wainer dos Santos Moschetta <address@hidden> writes:
> Since commit cbe6d6365a48 the command `qemu -accel help` returns
> the list of accelerators enabled in the QEMU binary. This adds
> the list_accel() method which return that same list.
>
> Signed-off-by: Wainer dos Santos Moschetta <address@hidden>
> ---
> python/qemu/accel.py | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/python/qemu/accel.py b/python/qemu/accel.py
> index 1b825126c5..a63ff980a9 100644
> --- a/python/qemu/accel.py
> +++ b/python/qemu/accel.py
> @@ -18,6 +18,7 @@ accelerators.
>
> import logging
> import os
> +import subprocess
>
> LOG = logging.getLogger(__name__)
>
> @@ -28,6 +29,25 @@ ADDITIONAL_ARCHES = {
> "aarch64" : "armhf"
> }
>
> +def list_accel(qemu_bin):
> + """
> + List accelerators enabled in the QEMU binary.
> +
> + @param qemu_bin (str): path to the QEMU binary.
> + @raise Exception: if failed to run `qemu -accel help`
> + @return a list of accelerator names.
> + """
> + if not qemu_bin:
> + return []
> + try:
> + out = subprocess.check_output("%s -accel help" % qemu_bin,
> shell=True)
> + except:
> + LOG.debug("Failed to get the list of accelerators in %s" %
> qemu_bin)
Ahh here it is. So I guess either mention the fact we will be using it
in the previous commit or bring it in here when we do use it.
I see we use LOG.debug for a bunch of failure reasons but surely
LOG.error is the more correct level for something that failed? I guess
it doesn't matter as we don't mess with the levels.
> + raise
> + lines = out.decode().splitlines()
> + # Skip the first line which is the header.
> + return [l.strip() for l in lines[1:] if l]
> +
> def kvm_available(target_arch=None):
> host_arch = os.uname()[4]
> if target_arch and target_arch != host_arch:
Anyway:
Reviewed-by: Alex Bennée <address@hidden>
--
Alex Bennée
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 2/4] python/qemu: accel: Add list_accel() method,
Alex Bennée <=