[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/21] block/file-posix: Fix laio_init() error handling crash
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH 03/21] block/file-posix: Fix laio_init() error handling crash bug |
|
Date: |
Mon, 2 Dec 2019 13:22:59 +0100 |
|
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 30.11.2019 um 20:42 hat Markus Armbruster geschrieben:
> raw_aio_attach_aio_context() passes uninitialized Error *local_err by
> reference to laio_init() via aio_setup_linux_aio(). When laio_init()
> fails, it passes it on to error_setg_errno(), tripping error_setv()'s
> assertion unless @local_err is null by dumb luck.
>
> Fix by initializing @local_err properly.
>
> Fixes: ed6e2161715c527330f936d44af4c547f25f687e
> Cc: Nishanth Aravamudan <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>