[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 16/21] s390/cpu_modules: Fix latent realize() error handling
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 16/21] s390/cpu_modules: Fix latent realize() error handling bugs |
|
Date: |
Mon, 02 Dec 2019 06:02:58 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
David Hildenbrand <address@hidden> writes:
> On 30.11.19 20:42, Markus Armbruster wrote:
>> get_max_cpu_model() crashes when kvm_s390_get_host_cpu_model() fails
>> and its @errp argument is null.
>>
>> apply_cpu_model() crashes when kvm_s390_apply_cpu_model() fails and
>> its @errp argument is null.
>>
>> s390_realize_cpu_model() crashes when get_max_cpu_model() or
>> check_compatibility() fail, and its @errp argument is null.
>>
>> All three messed up in commit 80560137cf "s390x/cpumodel: check and
>> apply the CPU model".
>>
>> The bugs can't bite as no caller actually passes null. Fix them
>> anyway.
>>
>
> Subject is wrong, should e.g., start with "s390x/cpumodels". (I am not
> aware of CPU modules :) )
Of course.
> [...]
>
> Same comment regarding "local_err" and "BUG".
>
> Reviewed-by: David Hildenbrand <address@hidden>
Thanks!