qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 8e0cd2: usb-audio: Fix invalid values in Audi


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 8e0cd2: usb-audio: Fix invalid values in AudioControl desc...
Date: Tue, 02 Apr 2024 06:33:52 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 8e0cd23f7163f7f203bdaffd9f06feaa49dcec2d
      
https://github.com/qemu/qemu/commit/8e0cd23f7163f7f203bdaffd9f06feaa49dcec2d
  Author: Joonas Kankaala <joonas.a.kankaala@gmail.com>
  Date:   2024-04-01 (Mon, 01 Apr 2024)

  Changed paths:
    M hw/usb/dev-audio.c

  Log Message:
  -----------
  usb-audio: Fix invalid values in AudioControl descriptors

This fixes the invalid bInterfaceProtocol value 0x04 in the USB audio
AudioControl descriptors. It should be zero. While Linux and Windows
forgive this error, macOS 14 Sonoma does not. The usb-audio device does
not appear in macOS sound settings even though the device is recognized
and shows up in USB system information. According to the USB audio class
specs 1.0-4.0, valid values are 0x00, 0x20, 0x30 and 0x40. (Note also
that Linux prints the warning "unknown interface protocol 0x4, assuming
v1", but then proceeds as if the value was zero.)

This also fixes the invalid wTotalLength value in the multi-channel
setup AudioControl interface header descriptor (used when multi=on
and out.mixing-engine off). The combined length of all the descriptors
there add up to 0x37, not 0x38. In Linux, "lsusb -D ..." displays
incomplete descriptor information when this length is incorrect.

Signed-off-by: Joonas Kankaala <joonas.a.kankaala@gmail.com>
Reviewed-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: 9988c7b50e0ebd93a8ac10d7da6890d05971e98e
      
https://github.com/qemu/qemu/commit/9988c7b50e0ebd93a8ac10d7da6890d05971e98e
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2024-04-01 (Mon, 01 Apr 2024)

  Changed paths:
    M fpu/softfloat-specialize.c.inc

  Log Message:
  -----------
  fpu/softfloat: Remove mention of TILE-Gx target

TILE-Gx has been removed during the v6.0 release (see
commit 2cc1a90166 "Remove deprecated target tilegx"),
no need to mention it in the list of "supported targets".

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: f6822fee969aed8662baa4fdc38e6aeced3894ad
      
https://github.com/qemu/qemu/commit/f6822fee969aed8662baa4fdc38e6aeced3894ad
  Author: Stefan Weil <sw@weilnetz.de>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M docs/devel/atomics.rst
    M docs/devel/ci-jobs.rst.inc
    M docs/devel/clocks.rst
    M docs/system/i386/sgx.rst
    M qapi/qom.json

  Log Message:
  -----------
  Fix some typos in documentation (found by codespell)

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: 7805132bc30b2619355b10bbfb67217ac838c677
      
https://github.com/qemu/qemu/commit/7805132bc30b2619355b10bbfb67217ac838c677
  Author: Dayu Liu <liu.dayu@zte.com.cn>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M hmp-commands.hx

  Log Message:
  -----------
  hmp: Add help information for watchdog action: inject-nmi

virsh qemu-monitor-command --hmp help information of
watchdog_action missing inject-nmi which already supported
in Commit 795dc6e4

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2247
Signed-off-by: Dayu Liu <liu.dayu@zte.com.cn>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
[Mjt: decode and word-wrap commit message and add Resolves: tag]


  Commit: 2fd8df9362d7f5b63e57fd0e561d08d2943ac7cf
      
https://github.com/qemu/qemu/commit/2fd8df9362d7f5b63e57fd0e561d08d2943ac7cf
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M docs/devel/atomics.rst
    M docs/devel/ci-jobs.rst.inc
    M docs/devel/clocks.rst
    M docs/system/i386/sgx.rst
    M fpu/softfloat-specialize.c.inc
    M hmp-commands.hx
    M hw/usb/dev-audio.c
    M qapi/qom.json

  Log Message:
  -----------
  Merge tag 'pull-trivial-patches' of https://gitlab.com/mjt0k/qemu into staging

trivial patches for 2024-04-02

# -----BEGIN PGP SIGNATURE-----
#
# iQFDBAABCAAtFiEEe3O61ovnosKJMUsicBtPaxppPlkFAmYL4EQPHG1qdEB0bHMu
# bXNrLnJ1AAoJEHAbT2saaT5ZyhIH/1sz3OeyczgPeMsICXpCnkQps8cDKuzUMkHA
# BHZGQ9AvFNZVw0YzgY+h1u2zPnsN0WNpWuxe8dbZODHcBjeJVZ5yOyJ6TWVVuKDn
# 6TzOfhGOeaUthNphpfZaM1q7fJfwU8zW3/pe6OCsD92Czxb8Eao3T4ONzVNZVXU9
# 3KPXPD9weWnY/sozXDqPFJmwn0LDL5o6IhPz+Ypp5xFrOTC+5+C/UmgTGIsuKTcO
# kQ96gVwCr3tm1YeJtEGfNOar/lt75jHHV2wbizaz2Jpwv9GHwtHXJOtQ38fIYxlm
# UPZ+L982SjfgaIHLCGOtLYJWSXsK5xI31HDSK1ZIiJquocZE1jU=
# =ZGw+
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 02 Apr 2024 11:39:00 BST
# gpg:                using RSA key 7B73BAD68BE7A2C289314B22701B4F6B1A693E59
# gpg:                issuer "mjt@tls.msk.ru"
# gpg: Good signature from "Michael Tokarev <mjt@tls.msk.ru>" [full]
# gpg:                 aka "Michael Tokarev <mjt@corpit.ru>" [full]
# gpg:                 aka "Michael Tokarev <mjt@debian.org>" [full]
# Primary key fingerprint: 6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 8044 65C5
#      Subkey fingerprint: 7B73 BAD6 8BE7 A2C2 8931  4B22 701B 4F6B 1A69 3E59

* tag 'pull-trivial-patches' of https://gitlab.com/mjt0k/qemu:
  hmp: Add help information for watchdog action: inject-nmi
  Fix some typos in documentation (found by codespell)
  fpu/softfloat: Remove mention of TILE-Gx target
  usb-audio: Fix invalid values in AudioControl descriptors

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/7fcf7575f3d2...2fd8df9362d7

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications



reply via email to

[Prev in Thread] Current Thread [Next in Thread]