qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] b17693: docs/s390: clarify even more that cpu


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] b17693: docs/s390: clarify even more that cpu-topology is ...
Date: Tue, 19 Mar 2024 07:25:28 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b17693453ef4d06f732295c2e70128a7cf20bf30
      
https://github.com/qemu/qemu/commit/b17693453ef4d06f732295c2e70128a7cf20bf30
  Author: Claudio Fontana <cfontana@suse.de>
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
    M docs/system/introduction.rst
    M docs/system/s390x/cpu-topology.rst

  Log Message:
  -----------
  docs/s390: clarify even more that cpu-topology is KVM-only

At least for now cpu-topology is implemented only for KVM.

We already say this, but this tries to be more explicit,
and also show it in the examples.

This adds a new reference in the introduction that we can point to,
whenever we need to reference accelerators and how to select them.

Signed-off-by: Claudio Fontana <cfontana@suse.de>
Message-ID: <20240314172218.16478-1-cfontana@suse.de>
Reviewed-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
Tested-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: fdf1c98063eec7f7fb4dd019391739eaae1e165f
      
https://github.com/qemu/qemu/commit/fdf1c98063eec7f7fb4dd019391739eaae1e165f
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/smbios/smbios.c

  Log Message:
  -----------
  SMBIOS: fix long lines

Break up long lines to fit under 80/90 char limit.

Fixes: 04f143d828 ("Implement SMBIOS type 9 v2.6")
Fixes: 735eee07d1 ("Implement base of SMBIOS type 9 descriptor.")
Cc: "Felix Wu" <flwu@google.com>
Cc: Nabih Estefan <nabihestefan@google.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 1bdef7a6290b1a7ed820aa2e9c25fa85069b2b85
      
https://github.com/qemu/qemu/commit/1bdef7a6290b1a7ed820aa2e9c25fa85069b2b85
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M qapi/common.json

  Log Message:
  -----------
  qapi: document PCIe Gen5/Gen6 speeds since 9.0

Document that PCIe Gen5/Gen6 speeds are only in QAPI
since 9.0 - the rest is since 4.0.

Cc: Lukas Stockner <lstockner@genesiscloud.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Fixes: c08da86dc4 ("pcie: Support PCIe Gen5/Gen6 link speeds")
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: e739d1935c461d0668057e9dbba9d06f728d29ec
      
https://github.com/qemu/qemu/commit/e739d1935c461d0668057e9dbba9d06f728d29ec
  Author: Thomas Weißschuh <thomas@t-8ch.de>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M docs/specs/pvpanic.rst

  Log Message:
  -----------
  docs/specs/pvpanic: mark shutdown event as not implemented

Mention the fact that this event is not yet implemented
to avoid confusion.
As requested by Michael.

Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
Message-Id: <20240313-pvpanic-note-v1-1-7f2571cdaedc@t-8ch.de>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 53002d9028f9d8b3215dafd7c0a55047bb5c9804
      
https://github.com/qemu/qemu/commit/53002d9028f9d8b3215dafd7c0a55047bb5c9804
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M tests/qtest/bios-tables-test.c

  Log Message:
  -----------
  tests: smbios: make it possible to write SMBIOS only test

Cureently it not possible to run SMBIOS test without ACPI one,
which gets into the way when testing ACPI-less configs.

Extract SMBIOS testing into separate routines that could also
be run without ACPI dependency and use that for testing SMBIOS.

As the 1st user add "acpi/piix4/smbios-options" test case.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-2-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: ed75658af39ea29c5bf2d6fd2c645a54c95db78a
      
https://github.com/qemu/qemu/commit/ed75658af39ea29c5bf2d6fd2c645a54c95db78a
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    A tests/data/smbios/type11_blob
    M tests/qtest/bios-tables-test.c

  Log Message:
  -----------
  tests: smbios: add test for -smbios type=11 option

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-3-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 579094cb995b605af07ba3ced3d0a5dc1545509c
      
https://github.com/qemu/qemu/commit/579094cb995b605af07ba3ced3d0a5dc1545509c
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    A tests/data/smbios/type11_blob.legacy
    M tests/qtest/bios-tables-test.c

  Log Message:
  -----------
  tests: smbios: add test for legacy mode CLI options

Unfortunately having 2.0 machine type deprecated is not enough
to get rid of legacy SMBIOS handling since 'isapc' also uses
that and it's staying around.

Hence add test for CLI options handling to be sure that it
ain't broken during SMBIOS code refactoring.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-4-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: a7bdf7186f8ee5955874438ec2ddb1d28bc084b4
      
https://github.com/qemu/qemu/commit/a7bdf7186f8ee5955874438ec2ddb1d28bc084b4
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/i386/fw_cfg.c
    M hw/smbios/smbios.c

  Log Message:
  -----------
  smbios: cleanup smbios_get_tables() from legacy handling

smbios_get_tables() bails out right away if leagacy mode is enabled
and won't generate any SMBIOS tables. At the same time x86 specific
fw_cfg_build_smbios() will genarate legacy tables and then proceed
to preparing temporary mem_array for useless call to
smbios_get_tables() and then discard it.

Drop legacy related check in smbios_get_tables() and return from
fw_cfg_build_smbios() early if legacy tables where built without
proceeding to non legacy part of the function.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-5-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: e94e0a833b9d909e239829a2030dbb6e7c2db01d
      
https://github.com/qemu/qemu/commit/e94e0a833b9d909e239829a2030dbb6e7c2db01d
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/i386/fw_cfg.c
    M hw/smbios/smbios.c
    M include/hw/firmware/smbios.h

  Log Message:
  -----------
  smbios: get rid of smbios_smp_sockets global

it makes smbios_validate_table() independent from
smbios_smp_sockets global, which in turn lets
smbios_get_tables() avoid using not related legacy code.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-6-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: b3854ce8a77f14b40a59c4fcef234f4af04504d5
      
https://github.com/qemu/qemu/commit/b3854ce8a77f14b40a59c4fcef234f4af04504d5
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/arm/virt.c
    M hw/i386/fw_cfg.c
    M hw/loongarch/virt.c
    M hw/riscv/virt.c
    M hw/smbios/smbios.c
    M include/hw/firmware/smbios.h

  Log Message:
  -----------
  smbios: get rid of smbios_legacy global

clean up smbios_set_defaults() which is reused by legacy
and non legacy machines from being aware of 'legacy' notion
and need to turn it off. And push legacy handling up to
PC machine code where it's relevant.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Acked-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-7-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: cba59fe38a2bc2b1888892539d0c4688e07aa356
      
https://github.com/qemu/qemu/commit/cba59fe38a2bc2b1888892539d0c4688e07aa356
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/smbios/smbios.c

  Log Message:
  -----------
  smbios: avoid mangling user provided tables

currently smbios_entry_add() preserves internally '-smbios type='
options but tables provided with '-smbios file=' are stored directly
into blob that eventually will be exposed to VM. And then later
QEMU adds default/'-smbios type' entries on top into the same blob.

It makes impossible to generate tables more than once, hence
'immutable' guard was used.
Make it possible to regenerate final blob by storing user provided
blobs into a dedicated area (usr_blobs) and then copy it when
composing final blob. Which also makes handling of -smbios
options consistent.

As side effect of this and previous commits there is no need to
generate legacy smbios_entries at the time options are parsed.
Instead compose smbios_entries on demand from  usr_blobs like
it is done for non-legacy SMBIOS tables.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Message-Id: <20240314152302.2324164-8-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 9cd7fd69cfad9180e22b9adb728fc7b596b4bc1e
      
https://github.com/qemu/qemu/commit/9cd7fd69cfad9180e22b9adb728fc7b596b4bc1e
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/i386/fw_cfg.c
    M hw/smbios/smbios.c
    M include/hw/firmware/smbios.h

  Log Message:
  -----------
  smbios: don't check type4 structures in legacy mode

legacy mode doesn't support structures of type 2 and more,
and CLI has a check for '-smbios type' option, however it's
still possible to sneak in type4 as a blob with '-smbios file'
option. However doing the later makes SMBIOS tables broken
since SeaBIOS doesn't expect that.

Rather than trying to add support for type4 to legacy code
(both QEMU and SeaBIOS), simplify smbios_get_table_legacy()
by dropping not relevant check in legacy code and error out
on type4 blob.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-9-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 684b49fda6735fef7ee07bb2c628b37fa114ca1e
      
https://github.com/qemu/qemu/commit/684b49fda6735fef7ee07bb2c628b37fa114ca1e
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/smbios/smbios.c

  Log Message:
  -----------
  smbios: add smbios_add_usr_blob_size() helper

it will be used by follow up patch when legacy handling
is moved out into a separate file.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Message-Id: <20240314152302.2324164-10-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: d638a8659b7e957dede0cdc5afa569b733a10da5
      
https://github.com/qemu/qemu/commit/d638a8659b7e957dede0cdc5afa569b733a10da5
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/smbios/smbios.c
    M include/hw/firmware/smbios.h

  Log Message:
  -----------
  smbios: rename/expose structures/bitmaps used by both legacy and modern code

As a preparation to move legacy handling into a separate file,
add prefix 'smbios_' to type0/type1/have_binfile_bitmap/have_fields_bitmap
and expose them in smbios.h so that they can be reused in
legacy and modern code.

Doing it as a separate patch to avoid rename cluttering follow-up
patch which will move legacy code into a separate file.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Message-Id: <20240314152302.2324164-11-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: b42b0e4daaa543bc9f8e24662f94d65f6481c4a0
      
https://github.com/qemu/qemu/commit/b42b0e4daaa543bc9f8e24662f94d65f6481c4a0
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/i386/Kconfig
    M hw/smbios/Kconfig
    M hw/smbios/meson.build
    M hw/smbios/smbios.c
    A hw/smbios/smbios_legacy.c
    A hw/smbios/smbios_legacy_stub.c
    M include/hw/firmware/smbios.h

  Log Message:
  -----------
  smbios: build legacy mode code only for 'pc' machine

basically moving code around without functional change.
And exposing some symbols so that they could be shared
between smbbios.c and new smbios_legacy.c

plus some meson magic to build smbios_legacy.c only
for 'pc' machine and otherwise replace it with stub
if not selected.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Message-Id: <20240314152302.2324164-12-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 643e1c9ef9d90a6e80b82998d41c91302fef506b
      
https://github.com/qemu/qemu/commit/643e1c9ef9d90a6e80b82998d41c91302fef506b
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/i386/fw_cfg.c
    M hw/smbios/smbios.c
    M hw/smbios/smbios_legacy.c
    M include/hw/firmware/smbios.h

  Log Message:
  -----------
  smbios: handle errors consistently

Current code uses mix of error_report()+exit(1)
and error_setg() to handle errors.
Use newer error_setg() everywhere, beside consistency
it will allow to detect error condition without killing
QEMU and attempt switch-over to SMBIOS3.x tables/entrypoint
in follow up patch.

while at it, clear smbios_tables pointer after freeing.
that will avoid double free if smbios_get_tables() is called
multiple times.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Message-Id: <20240314152302.2324164-13-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 69ea07a56ef54050a61b91fe8236fef4908fe5d1
      
https://github.com/qemu/qemu/commit/69ea07a56ef54050a61b91fe8236fef4908fe5d1
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/arm/virt.c
    M hw/i386/fw_cfg.c
    M hw/i386/fw_cfg.h
    M hw/i386/pc.c
    M hw/loongarch/virt.c
    M hw/riscv/virt.c
    M hw/smbios/smbios.c
    M hw/smbios/smbios_legacy.c
    M include/hw/firmware/smbios.h

  Log Message:
  -----------
  smbios: get rid of global smbios_ep_type

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-14-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 6735a4943e024715cf256625f02231e88f76c40b
      
https://github.com/qemu/qemu/commit/6735a4943e024715cf256625f02231e88f76c40b
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/smbios/smbios.c

  Log Message:
  -----------
  smbios: clear smbios_type4_count before building tables

it will help to keep type 4 tables accounting correct in case
SMBIOS tables are built multiple times.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-15-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 4901b80e13be62fc8ea2d8844941f336076af266
      
https://github.com/qemu/qemu/commit/4901b80e13be62fc8ea2d8844941f336076af266
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M qapi/machine.json

  Log Message:
  -----------
  smbios: extend smbios-entry-point-type with 'auto' value

later patches will use it to pick SMBIOS version at runtime
depending on configuration.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-16-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 4840c8a2b4666cf1b320a387c3f8b609258e7654
      
https://github.com/qemu/qemu/commit/4840c8a2b4666cf1b320a387c3f8b609258e7654
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/smbios/smbios.c

  Log Message:
  -----------
  smbios: in case of entry point is 'auto' try to build v2 tables 1st

QEMU for some time now uses SMBIOS 3.0 for PC/Q35 machines by
default, however Windows has a bug in locating SMBIOS 3.0
entrypoint and fails to find tables when booted on SeaBIOS
(on UEFI SMBIOS 3.0 tables work fine since firmware hands
over tables in another way)

Missing SMBIOS tables may lead to some issues for guest
though (worst are: possible reactiveation, inability to
get virtio drivers from 'Windows Update')

It's unclear  at this point if MS will fix the issue on their
side. So instead of it (or rather in addition) this patch
will try to workaround the issue.

aka, use smbios-entry-point-type=auto to make QEMU try
generating conservative SMBIOS 2.0 tables and if that
fails (due to limits/requested configuration) fallback
to SMBIOS 3.0 tables.

With this in place majority of users will use SMBIOS 2.0
tables which work fine with (Windows + legacy BIOS).
The configurations that is not to possible to describe
with SMBIOS 2.0 will switch automatically to SMBIOS 3.0
(which will trigger Windows bug but there is nothing
QEMU can do here, so go and aks Microsoft to real fix).

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-17-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 5ed7948213af8cba0c6153611aa0aea55069bac2
      
https://github.com/qemu/qemu/commit/5ed7948213af8cba0c6153611aa0aea55069bac2
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/smbios/smbios.c

  Log Message:
  -----------
  smbios: error out when building type 4 table is not possible

If SMBIOS v2 version is requested but number of cores/threads
are more than it's possible to describe with v2, error out
instead of silently ignoring the fact and filling core/thread
count with bogus values.

This will help caller to decide if it should fallback to
SMBIOSv3 when smbios-entry-point-type='auto'

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-18-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: c74f0126ce5d2b3ffec929c5f9f4ce961c7e2366
      
https://github.com/qemu/qemu/commit/c74f0126ce5d2b3ffec929c5f9f4ce961c7e2366
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M tests/qtest/bios-tables-test-allowed-diff.h

  Log Message:
  -----------
  tests: acpi/smbios: whitelist expected blobs

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Ani Sinha <anisinha@redhat.com>
Message-Id: <20240314152302.2324164-19-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 2c7c45b3d0ba097ac99bf4b9a13c6de1d7724032
      
https://github.com/qemu/qemu/commit/2c7c45b3d0ba097ac99bf4b9a13c6de1d7724032
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/i386/pc.c
    M hw/i386/pc_piix.c
    M hw/i386/pc_q35.c

  Log Message:
  -----------
  pc/q35: set SMBIOS entry point type to 'auto' by default

Use smbios-entry-point-type='auto' for newer machine types as a workaround
for Windows not detecting SMBIOS tables. Which makes QEMU pick SMBIOS tables
based on configuration (with 2.x preferred and fallback to 3.x if the former
isn't compatible with configuration)

Default compat setting of smbios-entry-point-type after series
for pc/q35 machines:
  * 9.0-newer: 'auto'
  * 8.1-8.2: '64'
  * 8.0-older: '32'

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2008
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-20-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 86e372ad1e22df373878e5c1cbda2d5026a34331
      
https://github.com/qemu/qemu/commit/86e372ad1e22df373878e5c1cbda2d5026a34331
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M tests/data/acpi/q35/SSDT.dimmpxm
    M tests/qtest/bios-tables-test-allowed-diff.h

  Log Message:
  -----------
  tests: acpi: update expected SSDT.dimmpxm blob

address shift is caused by switch to 32-bit SMBIOS entry point
which has slightly different size from 64-bit one and happens
to trigger a bit different memory layout.

Expected diff:

-    Name (MEMA, 0x07FFE000)
+    Name (MEMA, 0x07FFF000)

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Ani Sinha <anisinha@redhat.com>
Message-Id: <20240314152302.2324164-21-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: bb949df637bdb6136a9acca55a2371fe1721e109
      
https://github.com/qemu/qemu/commit/bb949df637bdb6136a9acca55a2371fe1721e109
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M hw/smbios/smbios_legacy.c

  Log Message:
  -----------
  smbios: add extra comments to smbios_get_table_legacy()

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20240314152302.2324164-22-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: ff7c98a9415f3d61d026002921dfc836ce232bcf
      
https://github.com/qemu/qemu/commit/ff7c98a9415f3d61d026002921dfc836ce232bcf
  Author: Claudio Fontana <cfontana@suse.de>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M target/s390x/cpu_models.c

  Log Message:
  -----------
  target/s390x: improve cpu compatibility check error message

some users were confused by this message showing under TCG:

 Selected CPU generation is too new. Maximum supported model
 in the configuration: 'xyz'

Clarify that the maximum can depend on the accel, and add a
hint to try a different one.

Also add a hint for features mismatch to suggest trying
different accel, QEMU and kernel versions.

Signed-off-by: Claudio Fontana <cfontana@suse.de>
Message-ID: <20240314213746.27163-1-cfontana@suse.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 47833f817cc597db124c690bd14600bb5d00e824
      
https://github.com/qemu/qemu/commit/47833f817cc597db124c690bd14600bb5d00e824
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M target/sparc/cpu.c

  Log Message:
  -----------
  target/sparc/cpu: Improve the CPU help text

Remove the unnecessary "Sparc" at the beginning of the line and
put the chip information into parentheses so that it is clearer
which part of the line have to be passed to "-cpu" to specify a
different CPU.

Message-ID: <20240307174334.130407-4-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: aebe0a8552e8d419c8103e60e593f2778eab41c4
      
https://github.com/qemu/qemu/commit/aebe0a8552e8d419c8103e60e593f2778eab41c4
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis-ci: Rename SOFTMMU -> SYSTEM

Since we *might* have user emulation with softmmu,
rename MAIN_SOFTMMU_TARGETS as MAIN_SYSTEM_TARGETS
to express 'system emulation targets'.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240313213339.82071-3-philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 9359197f0b460134c6bd8ce9842ba103b83be1b1
      
https://github.com/qemu/qemu/commit/9359197f0b460134c6bd8ce9842ba103b83be1b1
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-03-19 (Tue, 19 Mar 2024)

  Changed paths:
    M docs/specs/pvpanic.rst
    M hw/arm/virt.c
    M hw/i386/Kconfig
    M hw/i386/fw_cfg.c
    M hw/i386/fw_cfg.h
    M hw/i386/pc.c
    M hw/i386/pc_piix.c
    M hw/i386/pc_q35.c
    M hw/loongarch/virt.c
    M hw/riscv/virt.c
    M hw/smbios/Kconfig
    M hw/smbios/meson.build
    M hw/smbios/smbios.c
    A hw/smbios/smbios_legacy.c
    A hw/smbios/smbios_legacy_stub.c
    M include/hw/firmware/smbios.h
    M qapi/common.json
    M qapi/machine.json
    M tests/data/acpi/q35/SSDT.dimmpxm
    A tests/data/smbios/type11_blob
    A tests/data/smbios/type11_blob.legacy
    M tests/qtest/bios-tables-test.c

  Log Message:
  -----------
  Merge tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu 
into staging

virtio,pc,pci: bugfixes

Some minor fixes plus a big patchset from Igor fixing
a regression with windows.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

# -----BEGIN PGP SIGNATURE-----
#
# iQFDBAABCAAtFiEEXQn9CHHI+FuUyooNKB8NuNKNVGkFAmX4NzsPHG1zdEByZWRo
# YXQuY29tAAoJECgfDbjSjVRpkp0H/1foAaDYrApMiIkji4aI94bq/fwTnu5CshNP
# +YEzwJCS4qbl67/Ix2Z+xVz7twjQbgGdLd6hb9ZypAQfclUk5tDoKyCmqHtQMakX
# T080FayOvWmUEostAw7MXvuz0HpJlgnJaJBn29l1hHjA/XXahKqcc705cup+W8hv
# F7xb6AoFcbdETMzNaoqekNaHiiYyQPITY9p/UYPLzj2zyLsspR9kBebIeA1yhtXw
# Tmc3+FMquoM2fMNxpwfhCBswg662MlOXhLN3dmyLqeJRl09x1GvaeJIGMY2MbefM
# RMMv0/jqwAyii5HXew2rPIbLdULGq+hSjZo2NOlx3EOjTCaOkXc=
# =XGMp
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 18 Mar 2024 12:44:43 GMT
# gpg:                using RSA key 5D09FD0871C8F85B94CA8A0D281F0DB8D28D5469
# gpg:                issuer "mst@redhat.com"
# gpg: Good signature from "Michael S. Tsirkin <mst@kernel.org>" [full]
# gpg:                 aka "Michael S. Tsirkin <mst@redhat.com>" [full]
# Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
#      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469

* tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu: (24 
commits)
  smbios: add extra comments to smbios_get_table_legacy()
  tests: acpi: update expected SSDT.dimmpxm blob
  pc/q35: set SMBIOS entry point type to 'auto' by default
  tests: acpi/smbios: whitelist expected blobs
  smbios: error out when building type 4 table is not possible
  smbios: in case of entry point is 'auto' try to build v2 tables 1st
  smbios: extend smbios-entry-point-type with 'auto' value
  smbios: clear smbios_type4_count before building tables
  smbios: get rid of global smbios_ep_type
  smbios: handle errors consistently
  smbios: build legacy mode code only for 'pc' machine
  smbios: rename/expose structures/bitmaps used by both legacy and modern code
  smbios: add smbios_add_usr_blob_size() helper
  smbios: don't check type4 structures in legacy mode
  smbios: avoid mangling user provided tables
  smbios: get rid of smbios_legacy global
  smbios: get rid of smbios_smp_sockets global
  smbios: cleanup smbios_get_tables() from legacy handling
  tests: smbios: add test for legacy mode CLI options
  tests: smbios: add test for -smbios type=11 option
  ...

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: ddc27d2ad9361a81c2b3800d14143bf420dae172
      
https://github.com/qemu/qemu/commit/ddc27d2ad9361a81c2b3800d14143bf420dae172
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-03-19 (Tue, 19 Mar 2024)

  Changed paths:
    M .travis.yml
    M docs/system/introduction.rst
    M docs/system/s390x/cpu-topology.rst
    M target/s390x/cpu_models.c
    M target/sparc/cpu.c

  Log Message:
  -----------
  Merge tag 'pull-request-2024-03-18' of https://gitlab.com/thuth/qemu into 
staging

* Clarify s390x CPU topology docs and CPU compatibility error messages
* Improve the Sparc CPU help text
* Rename SOFTMMU to SYSTEM in the travis.yml file

# -----BEGIN PGP SIGNATURE-----
#
# iQJFBAABCAAvFiEEJ7iIR+7gJQEY8+q5LtnXdP5wLbUFAmX4f/gRHHRodXRoQHJl
# ZGhhdC5jb20ACgkQLtnXdP5wLbULnBAAgAPw1tonqEyt0kEw+i088do3yprrcoA+
# vTWB1Qk8ieL7nmBaFtsKYXVeoY+KICSGY4UvN3+jFot8uwzSz3vEYOpC5Nd+m0ct
# CqLUtVeq6wpql1PLswobiPdxdLznkgrXchvXY5LwURTtr1Gtq1JjAU+HdJ2UyRyZ
# WFe2HW2kriWswaprsyu6rNlmXzDTaNo/Gn6c0d//J0XYhg1qoxWsN95pzp7gMkb/
# YKx//Ss/lN4joRsqQGBQPCF43gFJwnmXdmwhyS4EcsCJ7DfqQ9UHgx42ypOgY497
# rVY7wTQeHSDOaQxkp+Vha0IvotIKll110J7bMpDL01++li1AiCMFjSl92dA6mHxL
# ZYGIjiUgTyjOuhuhkdLXbQLCUMST4VD8GOxxajil9jqBTwehUrUrNW/SOmP0az/p
# fq0Y8XxdynY8PKuBRPAM4f5hKIVtjzkz9m9XMu4bstYhIJNkfOQSiz1XzxS0T5/8
# 4VxaNF5we/l50HTnB4rJ0FGTzXiWO8BO3zSeD1caF+7ctHQWsypNBJYyKW52ITt3
# r6K17klsoNlmh8XjOt7wCVvNgsHj8SlsmtpN3GiTivDP0FVDY7DDA92teCRZB4TZ
# EhubWrQGERAPzG6Ud+bujUpwdgJ91MVvIuBjotAgNMT2Peayfc0V9PA4+7Xg5jW2
# 1wyyU3lr8y4=
# =4Ivl
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 18 Mar 2024 17:55:04 GMT
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* tag 'pull-request-2024-03-18' of https://gitlab.com/thuth/qemu:
  travis-ci: Rename SOFTMMU -> SYSTEM
  target/sparc/cpu: Improve the CPU help text
  target/s390x: improve cpu compatibility check error message
  docs/s390: clarify even more that cpu-topology is KVM-only

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/4511400fb78e...ddc27d2ad936

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications



reply via email to

[Prev in Thread] Current Thread [Next in Thread]