qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] e999be: dump: Fix HMP dump-guest-memory -z wi


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] e999be: dump: Fix HMP dump-guest-memory -z without -R
Date: Wed, 31 Jan 2024 11:59:26 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: e999bea8e688354a9dd790746bdae760c2953a2e
      
https://github.com/qemu/qemu/commit/e999bea8e688354a9dd790746bdae760c2953a2e
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M dump/dump-hmp-cmds.c

  Log Message:
  -----------
  dump: Fix HMP dump-guest-memory -z without -R

-z without -R has no effect: the dump format remains @elf.  Fix the
logic error so it becomes @kdump-zlib.

Fixes: e6549197f7ed (dump: Add command interface for kdump-raw formats)
Fixes: CID 1523841
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Stephen Brennan <stephen.s.brennan@oracle.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: 7aa94e591f983784a5af4e097cce2479f84a9452
      
https://github.com/qemu/qemu/commit/7aa94e591f983784a5af4e097cce2479f84a9452
  Author: Michael Tokarev <mjt@tls.msk.ru>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M docs/colo-proxy.txt
    M qemu-options.hx

  Log Message:
  -----------
  colo: examples: remove mentions of script= and (wrong) downscript=

There's no need to repeat script=/etc/qemu-ifup in examples,
as it is already in there.  More, all examples uses incorrect
"down script=" (which should be "downscript=").

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>


  Commit: dee70f51bf7088a43650109ed2bd8324deecbaf6
      
https://github.com/qemu/qemu/commit/dee70f51bf7088a43650109ed2bd8324deecbaf6
  Author: Han Han <hhan@redhat.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M qapi/migration.json

  Log Message:
  -----------
  qapi/migration.json: Fix the member name for MigrationCapability

s/@compression/@compress/

Fixes: 864128df46

Signed-off-by: Han Han <hhan@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: db101376af52e81f740a27f5fa38260ad171323c
      
https://github.com/qemu/qemu/commit/db101376af52e81f740a27f5fa38260ad171323c
  Author: Yihuan Pan <xun794@gmail.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M docs/system/keys.rst.inc

  Log Message:
  -----------
  qemu-docs: Update options for graphical frontends

The command line options `-ctrl-grab` and `-alt-grab` have been removed
in QEMU 7.1. Instead, use the `-display sdl,grab-mod=<modifiers>` option
to specify the grab modifiers.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2103
Signed-off-by: Yihuan Pan <xun794@gmail.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: 63b4c714abee2046b60b9455079127eab7b18920
      
https://github.com/qemu/qemu/commit/63b4c714abee2046b60b9455079127eab7b18920
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M .mailmap

  Log Message:
  -----------
  mailmap: Fix Stefan Weil email

Commit 5204b499a6 ("mailmap: Fix Stefan Weil author email")
corrected authorship for patch received at qemu-devel@nongnu.org,
correct now for patch received at qemu-trivial@nongnu.org.

Update other authorship email for Stefan's commits.

Suggested-by: Stefan Weil <sw@weilnetz.de>
Fixes: d819fc9516 ("virtio-blk: Fix potential nullptr read access")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: bbad42455b808cee25488b050fc0be36117c9698
      
https://github.com/qemu/qemu/commit/bbad42455b808cee25488b050fc0be36117c9698
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M scripts/clean-includes

  Log Message:
  -----------
  scripts/clean-includes: Update exclude list

Update the exclude list to exclude some more files which don't follow our
standard #include policy.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: 05871c72be699d14c169968b9080e3a784389cd3
      
https://github.com/qemu/qemu/commit/05871c72be699d14c169968b9080e3a784389cd3
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M hw/hyperv/hv-balloon-internal.h
    M hw/hyperv/hv-balloon-our_range_memslots.c
    M hw/hyperv/hv-balloon-our_range_memslots.h
    M hw/hyperv/hv-balloon-page_range_tree.c
    M hw/hyperv/hv-balloon-page_range_tree.h
    M hw/hyperv/hv-balloon.c

  Log Message:
  -----------
  hyperv: Clean up includes

This commit was created with scripts/clean-includes:
 ./scripts/clean-includes --git hyperv hw/hyperv/*.[ch]

All .c should include qemu/osdep.h first.  The script performs three
related cleanups:

* Ensure .c files include qemu/osdep.h first.
* Including it in a .h is redundant, since the .c  already includes
  it.  Drop such inclusions.
* Likewise, including headers qemu/osdep.h includes is redundant.
  Drop these, too.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: 3910de6fc7f32b05e8e8883cbea89907f36a2b33
      
https://github.com/qemu/qemu/commit/3910de6fc7f32b05e8e8883cbea89907f36a2b33
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M disas/riscv-xthead.c
    M disas/riscv-xventana.c
    M disas/riscv.h

  Log Message:
  -----------
  disas/riscv: Clean up includes

This commit was created with scripts/clean-includes:
 ./scripts/clean-includes --git disas/riscv disas/riscv*[ch]

All .c should include qemu/osdep.h first.  The script performs three
related cleanups:

* Ensure .c files include qemu/osdep.h first.
* Including it in a .h is redundant, since the .c  already includes
  it.  Drop such inclusions.
* Likewise, including headers qemu/osdep.h includes is redundant.
  Drop these, too.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: 00e3deef8e4004b6d37193b5310fd3f0d26c3df5
      
https://github.com/qemu/qemu/commit/00e3deef8e4004b6d37193b5310fd3f0d26c3df5
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M hw/arm/aspeed_eeprom.c
    M hw/arm/aspeed_eeprom.h
    M tests/qtest/qtest_aspeed.h

  Log Message:
  -----------
  aspeed: Clean up includes

This commit was created with scripts/clean-includes.

All .c should include qemu/osdep.h first.  The script performs three
related cleanups:

* Ensure .c files include qemu/osdep.h first.
* Including it in a .h is redundant, since the .c  already includes
  it.  Drop such inclusions.
* Likewise, including headers qemu/osdep.h includes is redundant.
  Drop these, too.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: ee88df50152c04dfc7259f1ac00cd263f5a5116e
      
https://github.com/qemu/qemu/commit/ee88df50152c04dfc7259f1ac00cd263f5a5116e
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M hw/nvram/fw_cfg-acpi.c
    M hw/virtio/virtio-acpi.c
    M include/hw/nvram/fw_cfg_acpi.h
    M include/hw/virtio/virtio-acpi.h

  Log Message:
  -----------
  acpi: Clean up includes

This commit was created with scripts/clean-includes:
 ./scripts/clean-includes --git acpi include/hw/*/*acpi.h hw/*/*acpi.c

All .c should include qemu/osdep.h first.  The script performs three
related cleanups:

* Ensure .c files include qemu/osdep.h first.
* Including it in a .h is redundant, since the .c  already includes
  it.  Drop such inclusions.
* Likewise, including headers qemu/osdep.h includes is redundant.
  Drop these, too.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: c34448f73f2184d82a42b0068cc4fc859dce83d9
      
https://github.com/qemu/qemu/commit/c34448f73f2184d82a42b0068cc4fc859dce83d9
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M include/hw/audio/asc.h
    M include/hw/m68k/q800-glue.h

  Log Message:
  -----------
  m68k: Clean up includes

This commit was created with scripts/clean-includes:
./scripts/clean-includes --git m68k include/hw/audio/asc.h include/hw/m68k/*.h

All .c should include qemu/osdep.h first.  The script performs three
related cleanups:

* Ensure .c files include qemu/osdep.h first.
* Including it in a .h is redundant, since the .c  already includes
  it.  Drop such inclusions.
* Likewise, including headers qemu/osdep.h includes is redundant.
  Drop these, too.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: b0b05c9c635bb313d0645c4f16fa56de04b53c6e
      
https://github.com/qemu/qemu/commit/b0b05c9c635bb313d0645c4f16fa56de04b53c6e
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M include/hw/arm/raspberrypi-fw-defs.h
    M include/hw/mem/memory-device.h
    M include/hw/ppc/spapr_nested.h
    M include/hw/xen/xen-hvm-common.h
    M include/qemu/qtree.h
    M include/ui/rect.h

  Log Message:
  -----------
  include: Clean up includes

This commit was created with scripts/clean-includes:
 ./scripts/clean-includes --git include include/*/*.h include/*/*/*.h

All .c should include qemu/osdep.h first.  The script performs three
related cleanups:

* Ensure .c files include qemu/osdep.h first.
* Including it in a .h is redundant, since the .c  already includes
  it.  Drop such inclusions.
* Likewise, including headers qemu/osdep.h includes is redundant.
  Drop these, too.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: ad5a8c4d2d55e3f2365ac72f353371835377d6c4
      
https://github.com/qemu/qemu/commit/ad5a8c4d2d55e3f2365ac72f353371835377d6c4
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M hw/cxl/cxl-events.c

  Log Message:
  -----------
  cxl: Clean up includes

This commit was created with scripts/clean-includes.

All .c should include qemu/osdep.h first.  The script performs three
related cleanups:

* Ensure .c files include qemu/osdep.h first.
* Including it in a .h is redundant, since the .c  already includes
  it.  Drop such inclusions.
* Likewise, including headers qemu/osdep.h includes is redundant.
  Drop these, too.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: be355a44ca69e119278dd5212886aaeac560ae59
      
https://github.com/qemu/qemu/commit/be355a44ca69e119278dd5212886aaeac560ae59
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M target/riscv/vector_internals.c
    M target/riscv/vector_internals.h

  Log Message:
  -----------
  riscv: Clean up includes

This commit was created with scripts/clean-includes:
 ./scripts/clean-includes --git riscv target/riscv/*.[ch]

All .c should include qemu/osdep.h first.  The script performs three
related cleanups:

* Ensure .c files include qemu/osdep.h first.
* Including it in a .h is redundant, since the .c  already includes
  it.  Drop such inclusions.
* Likewise, including headers qemu/osdep.h includes is redundant.
  Drop these, too.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: 493bc2dbc16bbb0b9ac16badff5c31752bc224a9
      
https://github.com/qemu/qemu/commit/493bc2dbc16bbb0b9ac16badff5c31752bc224a9
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M audio/pwaudio.c
    M net/af-xdp.c
    M plugins/core.c
    M plugins/loader.c
    M util/userfaultfd.c

  Log Message:
  -----------
  misc: Clean up includes

This commit was created with scripts/clean-includes:
 ./scripts/clean-includes --git misc net/af-xdp.c plugins/*.c audio/pwaudio.c 
util/userfaultfd.c

All .c should include qemu/osdep.h first.  The script performs three
related cleanups:

* Ensure .c files include qemu/osdep.h first.
* Including it in a .h is redundant, since the .c  already includes
  it.  Drop such inclusions.
* Likewise, including headers qemu/osdep.h includes is redundant.
  Drop these, too.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: 93e08863d9b64c7c9568eb486a5f2367b2100899
      
https://github.com/qemu/qemu/commit/93e08863d9b64c7c9568eb486a5f2367b2100899
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M backends/hostmem.c

  Log Message:
  -----------
  backends/hostmem: Fix block comments style (checkpatch.pl warnings)

While re-indenting code in host_memory_backend_memory_complete(),
we triggered various "Block comments use a leading /* on a separate
line" warnings from checkpatch.pl. Correct the comments style.

Fixes: e199f7ad4d ("backends: Simplify host_memory_backend_memory_complete()")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: dfa1aa870847ccac27324c7da71eb83b9aa18531
      
https://github.com/qemu/qemu/commit/dfa1aa870847ccac27324c7da71eb83b9aa18531
  Author: Greg Kurz <groug@kaod.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M hw/i386/acpi-build.c

  Log Message:
  -----------
  hw/i386: Add `\n` to hint message

error_printf() doesn't add newlines.

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: 7e487d8c34a589213313b550d5b533d10350d434
      
https://github.com/qemu/qemu/commit/7e487d8c34a589213313b550d5b533d10350d434
  Author: Greg Kurz <groug@kaod.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M hw/loongarch/acpi-build.c

  Log Message:
  -----------
  hw/loongarch: Add `\n` to hint message

error_printf() doesn't add newlines.

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: cd25f5d38379f3b235da1d3cbc32c208654383d6
      
https://github.com/qemu/qemu/commit/cd25f5d38379f3b235da1d3cbc32c208654383d6
  Author: Greg Kurz <groug@kaod.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M hw/arm/virt-acpi-build.c

  Log Message:
  -----------
  hw/arm: Add `\n` to hint message

error_printf() doesn't add newlines.

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: 0a77a76f55e8a9d84082ebe7eaab443db68c7783
      
https://github.com/qemu/qemu/commit/0a77a76f55e8a9d84082ebe7eaab443db68c7783
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M hw/intc/xics.c

  Log Message:
  -----------
  hw/intc/xics: Include missing 'cpu.h' header

Include missing headers in order to avoid when refactoring
unrelated headers:

  hw/intc/xics.c: In function 'icp_realize':
  hw/intc/xics.c:304:5: error: unknown type name 'PowerPCCPU'
    304 |     PowerPCCPU *cpu;
        |     ^~~~~~~~~~

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: 54f0058fa7821c391719e69a92804636b2c403ae
      
https://github.com/qemu/qemu/commit/54f0058fa7821c391719e69a92804636b2c403ae
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M hw/hyperv/hyperv.c

  Log Message:
  -----------
  hw/hyperv: Include missing headers

Include missing headers in order to avoid when refactoring
unrelated headers:

  hw/hyperv/hyperv.c:33:18: error: field ‘msg_page_mr’ has incomplete type
    33 |     MemoryRegion msg_page_mr;
       |                  ^~~~~~~~~~~
  hw/hyperv/hyperv.c: In function ‘synic_update’:
  hw/hyperv/hyperv.c:64:13: error: implicit declaration of function 
‘memory_region_del_subregion’ [-Werror=implicit-function-declaration]
    64 |             memory_region_del_subregion(get_system_memory(),
       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
  hw/hyperv/hyperv.c: In function ‘hyperv_hcall_signal_event’:
  hw/hyperv/hyperv.c:683:17: error: implicit declaration of function 
‘ldq_phys’; did you mean ‘ldub_phys’? [-Werror=implicit-function-declaration]
   683 |         param = ldq_phys(&address_space_memory, addr);
       |                 ^~~~~~~~
       |                 ldub_phys
  hw/hyperv/hyperv.c:683:17: error: nested extern declaration of ‘ldq_phys’ 
[-Werror=nested-externs]
  hw/hyperv/hyperv.c: In function ‘hyperv_hcall_retreive_dbg_data’:
  hw/hyperv/hyperv.c:792:24: error: ‘TARGET_PAGE_SIZE’ undeclared (first use in 
this function); did you mean ‘TARGET_PAGE_BITS’?
   792 |     msg.u.recv.count = TARGET_PAGE_SIZE - sizeof(*debug_data_out);
       |                        ^~~~~~~~~~~~~~~~
       |                        TARGET_PAGE_BITS
  hw/hyperv/hyperv.c: In function ‘hyperv_syndbg_send’:
  hw/hyperv/hyperv.c:885:16: error: ‘HV_SYNDBG_STATUS_INVALID’ undeclared 
(first use in this function)
   885 |         return HV_SYNDBG_STATUS_INVALID;
       |                ^~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: 75e79f5a08c9d6a573bace48403799fd432b5dbd
      
https://github.com/qemu/qemu/commit/75e79f5a08c9d6a573bace48403799fd432b5dbd
  Author: Fiona Ebner <f.ebner@proxmox.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M block/io_uring.c

  Log Message:
  -----------
  block/io_uring: improve error message when init fails

The man page for io_uring_queue_init states:

> io_uring_queue_init(3) returns 0 on success and -errno on failure.

and the man page for io_uring_setup (which is one of the functions
where the return value of io_uring_queue_init() can come from) states:

> On error, a negative error code is returned. The caller should not
> rely on errno variable.

Tested using 'sysctl kernel.io_uring_disabled=2'. Output before this
change:

> failed to init linux io_uring ring

Output after this change:

> failed to init linux io_uring ring: Operation not permitted

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20240123135044.204985-1-f.ebner@proxmox.com>


  Commit: 615eaeab3d318ba239d54141a4251746782f65c1
      
https://github.com/qemu/qemu/commit/615eaeab3d318ba239d54141a4251746782f65c1
  Author: Richard W.M. Jones <rjones@redhat.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M block/blkio.c

  Log Message:
  -----------
  block/blkio: Make s->mem_region_alignment be 64 bits

With GCC 14 the code failed to compile on i686 (and was wrong for any
version of GCC):

../block/blkio.c: In function ‘blkio_file_open’:
../block/blkio.c:857:28: error: passing argument 3 of ‘blkio_get_uint64’ from 
incompatible pointer type [-Wincompatible-pointer-types]
  857 |                            &s->mem_region_alignment);
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~
      |                            |
      |                            size_t * {aka unsigned int *}
In file included from ../block/blkio.c:12:
/usr/include/blkio.h:49:67: note: expected ‘uint64_t *’ {aka ‘long long 
unsigned int *’} but argument is of type ‘size_t *’ {aka ‘unsigned int *’}
   49 | int blkio_get_uint64(struct blkio *b, const char *name, uint64_t 
*value);
      |                                                         ~~~~~~~~~~^~~~~

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
Message-id: 20240130122006.2977938-1-rjones@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: d5eaeefbdac30d9ca62612f18e2d3f4509272856
      
https://github.com/qemu/qemu/commit/d5eaeefbdac30d9ca62612f18e2d3f4509272856
  Author: Stefan Hajnoczi <stefanha@redhat.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M hw/block/block.c

  Log Message:
  -----------
  pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes()

The following expression is incorrect because blk_pread_nonzeroes()
deals in units of bytes, not sectors:

  bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS)
                                              ^^^^^^^

BDRV_REQUEST_MAX_BYTES is the appropriate constant.

Fixes: a4b15a8b9ef2 ("pflash: Only read non-zero parts of backend image")
Cc: Xiang Zheng <zhengxiang9@huawei.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20240130002712.257815-1-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 956ef499902b09aa8a3e70791455ccf45645032d
      
https://github.com/qemu/qemu/commit/956ef499902b09aa8a3e70791455ccf45645032d
  Author: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M hw/core/qdev.c
    M include/hw/qdev-core.h

  Log Message:
  -----------
  hw/core/qdev.c: add qdev_get_human_name()

Add a simple method to return some kind of human readable identifier for
use in error messages.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-id: 
8b566bfced98ae44be1fcc1f8e7215f0c3393aa1.1706598705.git.manos.pitsidianakis@linaro.org
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 954b33daee83fe79293fd81c2f7371db48e7d6bd
      
https://github.com/qemu/qemu/commit/954b33daee83fe79293fd81c2f7371db48e7d6bd
  Author: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M hw/block/block.c
    M hw/block/m25p80.c
    M hw/block/pflash_cfi01.c
    M hw/block/pflash_cfi02.c
    M include/hw/block/block.h

  Log Message:
  -----------
  hw/block/block.c: improve confusing blk_check_size_and_read_all() error

In cases where a device tries to read more bytes than the block device
contains, the error is vague: "device requires X bytes, block backend
provides Y bytes".

This patch changes the errors of this function to include the block
backend name, the device id and device type name where appropriate.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-id: 
7260eadff22c08457740117c1bb7bd2b4353acb9.1706598705.git.manos.pitsidianakis@linaro.org
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 24f920ad5ad038364407effce092945c40a46fe9
      
https://github.com/qemu/qemu/commit/24f920ad5ad038364407effce092945c40a46fe9
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-01-31 (Wed, 31 Jan 2024)

  Changed paths:
    M block/blkio.c
    M block/io_uring.c
    M hw/block/block.c
    M hw/block/m25p80.c
    M hw/block/pflash_cfi01.c
    M hw/block/pflash_cfi02.c
    M hw/core/qdev.c
    M include/hw/block/block.h
    M include/hw/qdev-core.h

  Log Message:
  -----------
  Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into 
staging

Pull request

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmW5b1IACgkQnKSrs4Gr
# c8geoQf8DU8Z8jlvy1luuBZLq3R7hnC7c3Wzje0atLGP++pX6QUXfAgGDsTTIQeh
# XWmkFhbOBurhToH8YpgPyNG8ZWYd9+NIvLnIJiWDklNDZg2zC00aOi8yBEbsgyFb
# 50HJA30AAHq8PuctCzhGhENLxvBvNDNME74SwYH7FSIK5x/nA1XBHDZsjst1/Hk2
# 1loLbVWElbU28Xll7hI862SAb8RULC/sRQomkQAhpydxq4TApNuRwvpRfPNFwFJ0
# +dCquCJEfV6wfD62xg2CBGA5DrD9T7ADxmCYl4DQyp3HIRKXAptjgLsx3aZaIr1z
# KAnCRNUXRuLgRZf7b9I+HhxGISoNng==
# =/bBL
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 30 Jan 2024 21:51:14 GMT
# gpg:                using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>" [full]
# gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>" [full]
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* tag 'block-pull-request' of https://gitlab.com/stefanha/qemu:
  hw/block/block.c: improve confusing blk_check_size_and_read_all() error
  hw/core/qdev.c: add qdev_get_human_name()
  pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes()
  block/blkio: Make s->mem_region_alignment be 64 bits
  block/io_uring: improve error message when init fails

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 14639717bf379480e937716fcaf1e72b47fd4c5f
      
https://github.com/qemu/qemu/commit/14639717bf379480e937716fcaf1e72b47fd4c5f
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-01-31 (Wed, 31 Jan 2024)

  Changed paths:
    M .mailmap
    M audio/pwaudio.c
    M backends/hostmem.c
    M disas/riscv-xthead.c
    M disas/riscv-xventana.c
    M disas/riscv.h
    M docs/colo-proxy.txt
    M docs/system/keys.rst.inc
    M dump/dump-hmp-cmds.c
    M hw/arm/aspeed_eeprom.c
    M hw/arm/aspeed_eeprom.h
    M hw/arm/virt-acpi-build.c
    M hw/cxl/cxl-events.c
    M hw/hyperv/hv-balloon-internal.h
    M hw/hyperv/hv-balloon-our_range_memslots.c
    M hw/hyperv/hv-balloon-our_range_memslots.h
    M hw/hyperv/hv-balloon-page_range_tree.c
    M hw/hyperv/hv-balloon-page_range_tree.h
    M hw/hyperv/hv-balloon.c
    M hw/hyperv/hyperv.c
    M hw/i386/acpi-build.c
    M hw/intc/xics.c
    M hw/loongarch/acpi-build.c
    M hw/nvram/fw_cfg-acpi.c
    M hw/virtio/virtio-acpi.c
    M include/hw/arm/raspberrypi-fw-defs.h
    M include/hw/audio/asc.h
    M include/hw/m68k/q800-glue.h
    M include/hw/mem/memory-device.h
    M include/hw/nvram/fw_cfg_acpi.h
    M include/hw/ppc/spapr_nested.h
    M include/hw/virtio/virtio-acpi.h
    M include/hw/xen/xen-hvm-common.h
    M include/qemu/qtree.h
    M include/ui/rect.h
    M net/af-xdp.c
    M plugins/core.c
    M plugins/loader.c
    M qapi/migration.json
    M qemu-options.hx
    M scripts/clean-includes
    M target/riscv/vector_internals.c
    M target/riscv/vector_internals.h
    M tests/qtest/qtest_aspeed.h
    M util/userfaultfd.c

  Log Message:
  -----------
  Merge tag 'pull-trivial-patches' of https://gitlab.com/mjt0k/qemu into staging

trivial patches for 2024-01-31

# -----BEGIN PGP SIGNATURE-----
#
# iQFDBAABCAAtFiEEe3O61ovnosKJMUsicBtPaxppPlkFAmW6NScPHG1qdEB0bHMu
# bXNrLnJ1AAoJEHAbT2saaT5ZdQYH/2fhfhZotH0V2qAcMxlOoHbAE9UhZNRsSYtf
# QFP0GXFYFAMm7LHkPUbvKgO7LylKWAOMn/zKZqgj1Vf1EpoKQ2FwLtR/buDz86Ec
# pi2OrDPRA7Ay5c3ow3YZZkUOhQTTcR5rNjYctPtt/J4j8ol/z5vre7weJIg2bCJe
# zI7vIVg7iFFzbkXY20KHngJ5nDC+aEm7WaGlxAP8kfkvy324Wy9O2k8qu2J5zbLT
# HGvh3rwEDvRTYe4CaKFFHWNV0m4092HAr/dJBobugI5VZ6QQpK6Tgy8N+4ZrCHD2
# SjUKeym85VTOYGuY8b18fk5MQK2SzsfBUJ4x8VGC75W4mJ8agdc=
# =HImO
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 31 Jan 2024 11:55:19 GMT
# gpg:                using RSA key 7B73BAD68BE7A2C289314B22701B4F6B1A693E59
# gpg:                issuer "mjt@tls.msk.ru"
# gpg: Good signature from "Michael Tokarev <mjt@tls.msk.ru>" [full]
# gpg:                 aka "Michael Tokarev <mjt@corpit.ru>" [full]
# gpg:                 aka "Michael Tokarev <mjt@debian.org>" [full]
# Primary key fingerprint: 6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 8044 65C5
#      Subkey fingerprint: 7B73 BAD6 8BE7 A2C2 8931  4B22 701B 4F6B 1A69 3E59

* tag 'pull-trivial-patches' of https://gitlab.com/mjt0k/qemu: (21 commits)
  hw/hyperv: Include missing headers
  hw/intc/xics: Include missing 'cpu.h' header
  hw/arm: Add `\n` to hint message
  hw/loongarch: Add `\n` to hint message
  hw/i386: Add `\n` to hint message
  backends/hostmem: Fix block comments style (checkpatch.pl warnings)
  misc: Clean up includes
  riscv: Clean up includes
  cxl: Clean up includes
  include: Clean up includes
  m68k: Clean up includes
  acpi: Clean up includes
  aspeed: Clean up includes
  disas/riscv: Clean up includes
  hyperv: Clean up includes
  scripts/clean-includes: Update exclude list
  mailmap: Fix Stefan Weil email
  qemu-docs: Update options for graphical frontends
  qapi/migration.json: Fix the member name for MigrationCapability
  colo: examples: remove mentions of script= and (wrong) downscript=
  ...

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/bd2e12310b18...14639717bf37



reply via email to

[Prev in Thread] Current Thread [Next in Thread]