[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 903761: qtest: bump min meson timeout to 60 s
|
From: |
Daniel Berrangé |
|
Subject: |
[Qemu-commits] [qemu/qemu] 903761: qtest: bump min meson timeout to 60 seconds |
|
Date: |
Tue, 23 Jan 2024 12:06:52 -0800 |
Branch: refs/heads/staging-8.2
Home: https://github.com/qemu/qemu
Commit: 903761a48a900c51f6c40d37b37bafb85c0dc64c
https://github.com/qemu/qemu/commit/903761a48a900c51f6c40d37b37bafb85c0dc64c
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/qtest/meson.build
Log Message:
-----------
qtest: bump min meson timeout to 60 seconds
Even some of the relatively fast qtests can sometimes hit the 30 second
timeout in GitLab CI under high parallelism/load conditions. Bump the
min to 60 seconds to give a higher margin for reliability.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20230717182859.707658-2-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-2-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit 9eb95e5c56905365939017fc785312c59639e350)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: d72d37defdba3bd66e367fc4a56c907177706837
https://github.com/qemu/qemu/commit/d72d37defdba3bd66e367fc4a56c907177706837
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/qtest/meson.build
Log Message:
-----------
qtest: bump migration-test timeout to 8 minutes
The migration test should take between 1 min 30 and 2 mins on reasonably
modern hardware. The test is not especially compute bound, rather its
running time is dominated by the guest RAM size relative to the
bandwidth cap, which forces each iteration to take at least 30 seconds.
None the less under high load conditions with multiple QEMU processes
spawned and competing with other parallel tests, the worst case running
time might be somewhat extended. Bumping the timeout to 8 minutes gives
us good headroom, while still catching stuck tests relatively quickly.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20230717182859.707658-3-berrange@redhat.com>
[thuth: Bump timeout to 8 minutes to make it work on very loaded systems, too]
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-3-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit 70717951141451872cc0cba4d5d3a3cea5310525)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: 8d14cfff7b96eca2f606c1a65bb2e53fa1805fa7
https://github.com/qemu/qemu/commit/8d14cfff7b96eca2f606c1a65bb2e53fa1805fa7
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/qtest/meson.build
Log Message:
-----------
qtest: bump qom-test timeout to 15 minutes
The qom-test is periodically hitting the 5 minute timeout when running
on the aarch64 emulator under GitLab CI. With an --enable-debug build
it can take over 10 minutes for arm/aarch64 targets. Setting timeout
to 15 minutes gives enough headroom to hopefully make it reliable.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20230717182859.707658-4-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-4-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit cb2218ab1637ed80f0f9abd41f60c43f24bb268a)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: 9bfd2e0dedb1945e12eb97ddbf3ad635a9ec64c0
https://github.com/qemu/qemu/commit/9bfd2e0dedb1945e12eb97ddbf3ad635a9ec64c0
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/qtest/meson.build
Log Message:
-----------
qtest: bump npcm7xx_pwm-test timeout to 5 minutes
The npcm7xx_pwm-test takes 3 & 1/2 minutes in a --enable-debug build.
Bumping to 5 minutes will give more headroom.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20230717182859.707658-5-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-5-thuth@redhat.com>
[AJB: s/pwn/pwm]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit d05328bcb0f11a901e9f3e89ad01f2828a5ebe3a)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: 7a6cccf96f8444227c230049f4bbf71399a7431b
https://github.com/qemu/qemu/commit/7a6cccf96f8444227c230049f4bbf71399a7431b
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/qtest/meson.build
Log Message:
-----------
qtest: bump test-hmp timeout to 4 minutes
The hmp test takes just under 3 minutes in a --enable-debug
build. Bumping to 4 minutes will give more headroom.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20230717182859.707658-6-berrange@redhat.com>
[thuth: fix copy-n-paste error in the description]
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-6-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit f6d8d0e5429dbdad883530b7fa2bfdd0ace582ab)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: 80200efb6ace1e7d61a0e759c1691b1f1633d1f8
https://github.com/qemu/qemu/commit/80200efb6ace1e7d61a0e759c1691b1f1633d1f8
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/qtest/meson.build
Log Message:
-----------
qtest: bump pxe-test timeout to 10 minutes
The pxe-test uses the boot_sector_test() function, and that already
uses a timeout of 600 seconds. So adjust the timeout on the meson
side accordingly.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
[thuth: Bump timeout to 600s and adjust commit description]
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-7-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit 17e164da121a939e7f09a01776b302c6554d1fc8)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: 018438bb615a26a8053bd9878f244b0d14ef5052
https://github.com/qemu/qemu/commit/018438bb615a26a8053bd9878f244b0d14ef5052
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/qtest/meson.build
Log Message:
-----------
qtest: bump prom-env-test timeout to 6 minutes
The prom-env-test can take more than 5 minutes in a --enable-debug
build on a loaded system. Bumping to 6 minutes will give more headroom.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
[thuth: Bump timeout to 6 minutes instead of 3]
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-8-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit 8911563900db29ddc46b4660b7ee4771c8f1c9b6)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: 0551ef031181dc7e6106a53bc8c53ed64c122675
https://github.com/qemu/qemu/commit/0551ef031181dc7e6106a53bc8c53ed64c122675
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/qtest/meson.build
Log Message:
-----------
qtest: bump boot-serial-test timeout to 3 minutes
The boot-serial-test takes about 1 + 1/2 minutes in a --enable-debug
build. Bumping to 3 minutes will give more headroom.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20230717182859.707658-9-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-9-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit 93b6d67348df850eae074f8118d1e4f29622d8f7)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: 7a5f1d5708b9aa1d99da03aee56763f409ae6a38
https://github.com/qemu/qemu/commit/7a5f1d5708b9aa1d99da03aee56763f409ae6a38
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/qtest/meson.build
Log Message:
-----------
qtest: bump qos-test timeout to 2 minutes
The qos-test takes just under 1 minute in a --enable-debug
build. Bumping to 2 minutes will give more headroom.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20230717182859.707658-10-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-10-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit f6bee9c2f21ae733eee6adace03228bf5d3fdc83)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: 6d2a0f71418f4721fbecf6ec33d735064930f9d9
https://github.com/qemu/qemu/commit/6d2a0f71418f4721fbecf6ec33d735064930f9d9
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/qtest/meson.build
Log Message:
-----------
qtest: bump aspeed_smc-test timeout to 6 minutes
On a loaded system with --enable-debug, this test can take longer than
5 minutes. Raising the timeout to 6 minutes gives greater headroom for
such situations.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
[thuth: Increase the timeout to 6 minutes for very loaded systems]
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-11-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit e8a12fe31f776c60fec993513cd1b1e66c2b8e29)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: 7c3e7b5b10a8c17cfcb883651c44ba16790078c2
https://github.com/qemu/qemu/commit/7c3e7b5b10a8c17cfcb883651c44ba16790078c2
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/qtest/meson.build
Log Message:
-----------
qtest: bump bios-table-test timeout to 9 minutes
This is reliably hitting the current 2 minute timeout in GitLab CI,
and for the TCI job, it even hits a 6 minute timeout.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20230717182859.707658-12-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-12-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit 794876fb5281c93aeeac0ab007c938b755461d95)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: 38161104d2d18c78e35599380eab5eb576e60e5a
https://github.com/qemu/qemu/commit/38161104d2d18c78e35599380eab5eb576e60e5a
Author: Thomas Huth <thuth@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/qtest/meson.build
Log Message:
-----------
tests/qtest: Bump the device-introspect-test timeout to 12 minutes
When running the test in slow mode on a very loaded system with the
arm/aarch64 target and with --enable-debug, it can take longer than
10 minutes to finish the introspection test. Bump the timeout to twelve
minutes to make sure that it also finishes in such situations.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-13-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit 50dfa7ca4819f32aab5c915204b8eea684bca46e)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: 5fbeab4a24d28550ff64989093f2146722c3d2f3
https://github.com/qemu/qemu/commit/5fbeab4a24d28550ff64989093f2146722c3d2f3
Author: Thomas Huth <thuth@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/unit/meson.build
Log Message:
-----------
tests/unit: Bump test-aio-multithread test timeout to 2 minutes
When running the tests in slow mode on a very loaded system and with
--enable-debug, the test-aio-multithread can take longer than 1 minute.
Bump the timeout to two minutes to make sure that it also passes in
such situations.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-14-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit c45f8f1aef35730a2dcf3cabe296ac12965db43d)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: d0797eb0c1128685291d4d5a873d7d3acb441036
https://github.com/qemu/qemu/commit/d0797eb0c1128685291d4d5a873d7d3acb441036
Author: Thomas Huth <thuth@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/unit/meson.build
Log Message:
-----------
tests/unit: Bump test-crypto-block test timeout to 5 minutes
When running the tests in slow mode on a very loaded system and with
--enable-debug, the test-crypto-block can take longer than 4 minutes.
Bump the timeout to 5 minutes to make sure that it also passes in
such situations.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-15-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit e1b363e328d559cd5f86d3d1d7b84d0154e153d3)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: b05cf1725aa74e1afe51db62f16e96e6ee9d8f08
https://github.com/qemu/qemu/commit/b05cf1725aa74e1afe51db62f16e96e6ee9d8f08
Author: Thomas Huth <thuth@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M tests/fp/meson.build
Log Message:
-----------
tests/fp: Bump fp-test-mulAdd test timeout to 3 minutes
When running the tests in slow mode with --enable-debug on a very loaded
system, the fp-test-mulAdd test can take longer than 2 minutes. Bump the
timeout to three minutes to make sure it passes in such situations, too.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-16-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit 92b1dba3b0708fb054b96bd022b84857b8b047a9)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Commit: d113451ac9d26a15af51f1e44e8acb3b593c84ab
https://github.com/qemu/qemu/commit/d113451ac9d26a15af51f1e44e8acb3b593c84ab
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M scripts/mtest2make.py
Log Message:
-----------
mtest2make: stop disabling meson test timeouts
The mtest2make.py script passes the arg '-t 0' to 'meson test' which
disables all test timeouts. This is a major source of pain when running
in GitLab CI and a test gets stuck. It will stall until GitLab kills the
CI job. This leaves us with little easily consumable information about
the stalled test. The TAP format doesn't show the test name until it is
completed, and TAP output from multiple tests it interleaved. So we
have to analyse the log to figure out what tests had un-finished TAP
output present and thus infer which test case caused the hang. This is
very time consuming and error prone.
By allowing meson to kill stalled tests, we get a direct display of what
test program got stuck, which lets us more directly focus in on what
specific test case within the test program hung.
The other issue with disabling meson test timeouts by default is that it
makes it more likely that maintainers inadvertantly introduce slowdowns.
For example the recent-ish change that accidentally made migrate-test
take 15-20 minutes instead of around 1 minute.
The main risk of this change is that the individual test timeouts might
be too short to allow completion in high load scenarios. Thus, there is
likely to be some short term pain where we have to bump the timeouts for
certain tests to make them reliable enough. The preceeding few patches
raised the timeouts for all failures that were immediately apparent
in GitLab CI.
Even with the possible short term instability, this should still be a
net win for debuggability of failed CI pipelines over the long term.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20230717182859.707658-13-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20231215070357.10888-17-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
(cherry picked from commit 4156325cd3c205ce77b82de2c48127ccacddaf5b)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Compare: https://github.com/qemu/qemu/compare/003d0c7eb449...d113451ac9d2
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 903761: qtest: bump min meson timeout to 60 seconds,
Daniel Berrangé <=