[Qemu-commits] [qemu/qemu] fbb9b5: coverity: physmem: use simple assertions instead o...

[Alex Bennée]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: fbb9b591b339aaa90e2e78c157132c7fcdce9489
      
https://github.com/qemu/qemu/commit/fbb9b591b339aaa90e2e78c157132c7fcdce9489
  Author: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
  Date:   2023-11-09 (Thu, 09 Nov 2023)

  Changed paths:
    M scripts/coverity-scan/model.c
    M system/physmem.c

  Log Message:
  -----------
  coverity: physmem: use simple assertions instead of modelling

Unfortunately Coverity doesn't follow the logic aroung "len" and "l"
variables in stacks finishing with flatview_{read,write}_continue() and
generate a lot of OVERRUN false-positives. When small buffer (2 or 4
bytes) is passed to mem read/write path, Coverity assumes the worst
case of sz=8 in stn_he_p()/ldn_he_p() (defined in
include/qemu/bswap.h), and reports buffer overrun.

To silence these false-positives we have model functions, which hide
real logic from Coverity.

However, it turned out that these new two assertions are enough to
quiet Coverity.

Assertions are better than hiding the logic, so let's drop the
modelling and move to assertions for memory r/w call stacks.

After patch, the sequence

 cov-make-library --output-file /tmp/master.xmldb \
    scripts/coverity-scan/model.c
 cov-build --dir ~/covtmp/master make -j9
 cov-analyze --user-model-file /tmp/master.xmldb \
    --dir ~/covtmp/master --all --strip-path "$(pwd)
 cov-format-errors --dir ~/covtmp/master \
    --html-output ~/covtmp/master_html_report

Generate for me the same big set of CIDs excepept for 6 disappeared (so
it becomes even better).

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Acked-by: David Hildenbrand <david@redhat.com>
Message-ID: <20231005140326.332830-1-vsementsov@yandex-team.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: d6693d4b76a494e3e76337db7f23c70256b7a744
      
https://github.com/qemu/qemu/commit/d6693d4b76a494e3e76337db7f23c70256b7a744
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
    M configure
    M tests/Makefile.include

  Log Message:
  -----------
  tests: respect --enable/--disable-download for Avocado

Pass the content of $mkvenv_flags (which is either "--online"
or empty) down to tests/Makefile.include.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 85b2c619a9d0d3f2f850f9f9741f845d0611c8a4
      
https://github.com/qemu/qemu/commit/85b2c619a9d0d3f2f850f9f9741f845d0611c8a4
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
    M docs/devel/build-system.rst
    M pythondeps.toml

  Log Message:
  -----------
  docs: document what configure does with virtual environments

Given the recent confusion around how QEMU detects the system
Meson installation, and/or decides to install its own, it is
time to fill in the "Python virtual environments and the QEMU
build system" section of the documentation.

As a curiosity, a first and partial draft of the text was generated
by an LLM[1].  It required quite a bit of editing and probably did not
save much time, but some expressions do remain in the finished text.

[1] https://chat.openai.com/share/42c1500d-71c1-480b-bab9-7ccc2c155365

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 1714a17382a8f2d3d7d311cc562007ca202b215e
      
https://github.com/qemu/qemu/commit/1714a17382a8f2d3d7d311cc562007ca202b215e
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
    M python/scripts/vendor.py
    R python/wheels/meson-0.63.3-py3-none-any.whl
    A python/wheels/meson-1.2.3-py3-none-any.whl
    M pythondeps.toml

  Log Message:
  -----------
  buildsys: Bump known good meson version to v1.2.3

We need meson v1.2.3 to build QEMU on macOS Sonoma.  It
also builds fine all our CI jobs (as tested by also bumping
"accepted" in pythondeps.toml), so let's use it as our
"good enough" packaged wheel.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1939
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20231109160504.93677-2-philmd@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: a3cd347c6b2f8c11f76bb192686600026e6e23fb
      
https://github.com/qemu/qemu/commit/a3cd347c6b2f8c11f76bb192686600026e6e23fb
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
    M .gitlab-ci.d/cirrus.yml
    R .gitlab-ci.d/cirrus/macos-12.vars
    A .gitlab-ci.d/cirrus/macos-13.vars
    M tests/lcitool/refresh

  Log Message:
  -----------
  .gitlab-ci.d/cirrus: Upgrade macOS to 13 (Ventura)

macOS 14 "Sonoma" was released on September 2023 [1].

According to QEMU's support policy, we stop supporting the
previous major release two years after the the new major
release has been published. Replace the macOS 12 (Monterey)
testing by macOS 13 (Ventura, released on October 2022, [2]).

Refresh the generated files by running:

  $ make lcitool-refresh

[1] https://www.apple.com/newsroom/2023/09/macos-sonoma-is-available-today/
[2] https://www.apple.com/newsroom/2022/10/macos-ventura-is-now-available/

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20231108162022.76189-1-philmd@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 1d802d050caeff83add1054bee1fc9f98e59a3f2
      
https://github.com/qemu/qemu/commit/1d802d050caeff83add1054bee1fc9f98e59a3f2
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
    M .gitlab-ci.d/cirrus.yml
    A .gitlab-ci.d/cirrus/macos-14.vars
    M tests/lcitool/libvirt-ci
    M tests/lcitool/refresh

  Log Message:
  -----------
  .gitlab-ci.d/cirrus: Add manual testing of macOS 14 (Sonoma)

Upgrade libvirt-ci so it covers macOS 14. Add a manual entry
(QEMU_JOB_OPTIONAL: 1) to test on Sonoma release. Refresh the
lci-tool generated files.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20231109160504.93677-3-philmd@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 4bb351b243a7d9478ba74e16c9893375b131e948
      
https://github.com/qemu/qemu/commit/4bb351b243a7d9478ba74e16c9893375b131e948
  Author: Stefan Hajnoczi <stefanha@redhat.com>
  Date:   2023-11-12 (Sun, 12 Nov 2023)

  Changed paths:
    M .gitlab-ci.d/cirrus.yml
    R .gitlab-ci.d/cirrus/macos-12.vars
    A .gitlab-ci.d/cirrus/macos-13.vars
    A .gitlab-ci.d/cirrus/macos-14.vars
    M configure
    M docs/devel/build-system.rst
    M python/scripts/vendor.py
    R python/wheels/meson-0.63.3-py3-none-any.whl
    A python/wheels/meson-1.2.3-py3-none-any.whl
    M pythondeps.toml
    M scripts/coverity-scan/model.c
    M system/physmem.c
    M tests/Makefile.include
    M tests/lcitool/libvirt-ci
    M tests/lcitool/refresh

  Log Message:
  -----------
  Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging

* document what configure does with virtual environments
* Bump known good meson version to v1.2.3
* Upgrade macOS to 13 (Ventura) and Add manual testing of macOS 14 (Sonoma)
* use simple assertions instead of Coverity models

# -----BEGIN PGP SIGNATURE-----
#
# iQFIBAABCAAyFiEE8TM4V0tmI4mGbHaCv/vSX3jHroMFAmVN+kcUHHBib256aW5p
# QHJlZGhhdC5jb20ACgkQv/vSX3jHroPUowf/cnIY/3uICnaJLQZ7DESczHiOikc9
# 3q9tVRKYsef8hQaYjIgXXUAHE4vORX0I7O46UfG0Q/FwhTj/1CJoADfoWVmJlzYM
# clzLVD/3U87jj9DZnzNomCL78MXno2ZzdfrVsUoo4ioMQXe5dioIq6Uw0v5ROjYC
# vBQWtFnEv0vrNRjN7flXdkL1PRIBu7NSHviVW8C1UtzF7jMzHJpe4rOSjnyqIXso
# lNXTt3q8qQjS7tI84MXicFEYCBEE7ae3wbErbWV+ulQ4TiyzjSyduWQHsAJ63te/
# OiLvxgcWCyda1SMpMgmy5+zpfG0ZwCrGD7lN+Dfz+D12wknN7ztlNEx1LQ==
# =JkYJ
# -----END PGP SIGNATURE-----
# gpg: Signature made Fri 10 Nov 2023 17:39:19 HKT
# gpg:                using RSA key F13338574B662389866C7682BFFBD25F78C7AE83
# gpg:                issuer "pbonzini@redhat.com"
# gpg: Good signature from "Paolo Bonzini <bonzini@gnu.org>" [full]
# gpg:                 aka "Paolo Bonzini <pbonzini@redhat.com>" [full]
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
#      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83

* tag 'for-upstream' of https://gitlab.com/bonzini/qemu:
  .gitlab-ci.d/cirrus: Add manual testing of macOS 14 (Sonoma)
  .gitlab-ci.d/cirrus: Upgrade macOS to 13 (Ventura)
  buildsys: Bump known good meson version to v1.2.3
  docs: document what configure does with virtual environments
  tests: respect --enable/--disable-download for Avocado
  coverity: physmem: use simple assertions instead of modelling

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


Compare: https://github.com/qemu/qemu/compare/69680740eafa...4bb351b243a7