qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 2c109f: simpletrace: add __all__ to define pu


From: Alex Bennée
Subject: [Qemu-commits] [qemu/qemu] 2c109f: simpletrace: add __all__ to define public interface
Date: Thu, 28 Sep 2023 06:48:53 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 2c109f21994a72e9b91c24c422e540b921e84f66
      
https://github.com/qemu/qemu/commit/2c109f21994a72e9b91c24c422e540b921e84f66
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M scripts/simpletrace.py

  Log Message:
  -----------
  simpletrace: add __all__ to define public interface

It was unclear what was the supported public interface. I.e. when
refactoring the code, what functions/classes are important to retain.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-2-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 8405ec6ab6a05b8c84f7be1130a7891d1a874624
      
https://github.com/qemu/qemu/commit/8405ec6ab6a05b8c84f7be1130a7891d1a874624
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M scripts/simpletrace.py

  Log Message:
  -----------
  simpletrace: annotate magic constants from QEMU code

It wasn't clear where the constants and structs came from, so I added
comments to help.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-3-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: f7bd4f0237ec394198940f5b81cbde280c5b5c01
      
https://github.com/qemu/qemu/commit/f7bd4f0237ec394198940f5b81cbde280c5b5c01
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M scripts/simpletrace.py

  Log Message:
  -----------
  simpletrace: improve parsing of sys.argv; fix files never closed.

The arguments extracted from `sys.argv` named and unpacked to make it
clear what the arguments are and what they're used for.

The two input files were opened, but never explicitly closed. File usage
changed to use `with` statement to take care of this. At the same time,
ownership of the file-object is moved up to `run` function. Added option
to process to support file-like objects.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-4-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 3b71b61e9f50cad73958a87216dba7b22b851318
      
https://github.com/qemu/qemu/commit/3b71b61e9f50cad73958a87216dba7b22b851318
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M scripts/simpletrace.py

  Log Message:
  -----------
  simpletrace: changed naming of edict and idtoname to improve readability

Readability is subjective, but I've expanded the naming of the variables
and arguments, to help with understanding for new eyes on the code.

Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230926103436.25700-5-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: ce96eb334dc0a3a7f570f422e8a578495f34e4f2
      
https://github.com/qemu/qemu/commit/ce96eb334dc0a3a7f570f422e8a578495f34e4f2
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M scripts/simpletrace.py

  Log Message:
  -----------
  simpletrace: update code for Python 3.11

The call to `getargspec` was deprecated and in Python 3.11 it has been
removed in favor of `getfullargspec`. `getfullargspec` is compatible
with QEMU's requirement of at least Python version 3.6.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-6-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: d1f9259014317baa3bce7db7d4c2e927341e3cae
      
https://github.com/qemu/qemu/commit/d1f9259014317baa3bce7db7d4c2e927341e3cae
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M scripts/simpletrace.py

  Log Message:
  -----------
  simpletrace: improved error handling on struct unpack

A failed call to `read_header` wouldn't be handled the same for the two
different code paths (one path would try to use `None` as a list).
Changed to raise exception to be handled centrally. This also allows for
easier unpacking, as errors has been filtered out.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-7-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 1990fb98934d8e114ac73b0ca649bf4820ca896a
      
https://github.com/qemu/qemu/commit/1990fb98934d8e114ac73b0ca649bf4820ca896a
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M scripts/simpletrace.py

  Log Message:
  -----------
  simpletrace: define exception and add handling

Define `SimpleException` to differentiate our exceptions from generic
exceptions (IOError, etc.). Adapted simpletrace to support this and
output to stderr.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-8-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 87617b9ae63c4675460244d067e246b362dc3867
      
https://github.com/qemu/qemu/commit/87617b9ae63c4675460244d067e246b362dc3867
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M scripts/simpletrace.py

  Log Message:
  -----------
  simpletrace: made Analyzer into context-manager

Instead of explicitly calling `begin` and `end`, we can change the class
to use the context-manager paradigm. This is mostly a styling choice,
used in modern Python code. But it also allows for more advanced analyzers
to handle exceptions gracefully in the `__exit__` method (not
demonstrated here).

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-9-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 6f53641a980df2d1b38503b10bfda9236fa075b4
      
https://github.com/qemu/qemu/commit/6f53641a980df2d1b38503b10bfda9236fa075b4
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M scripts/simpletrace.py

  Log Message:
  -----------
  simpletrace: refactor to separate responsibilities

Moved event_mapping and event_id_to_name down one level in the function
call-stack to keep variable instantiation and usage closer (`process`
and `run` has no use of the variables; `read_trace_records` does).

Instead of passing event_mapping and event_id_to_name to the bottom of
the call-stack, we move their use to `read_trace_records`. This
separates responsibility and ownership of the information.

`read_record` now just reads the arguments from the file-object by
knowning the total number of bytes. Parsing it to specific arguments is
moved up to `read_trace_records`.

Special handling of dropped events removed, as they can be handled
by the general code.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-10-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: b78234e65cad8c4899a2cfcc5e5cd8d33fce1b95
      
https://github.com/qemu/qemu/commit/b78234e65cad8c4899a2cfcc5e5cd8d33fce1b95
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M scripts/simpletrace.py

  Log Message:
  -----------
  simpletrace: move logic of process into internal function

To avoid duplicate code depending on input types and to better handle
open/close of log with a context-manager, we move the logic of process into
_process.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-11-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: d1f89c23bd93e40e180d4fc727e691a698a6d522
      
https://github.com/qemu/qemu/commit/d1f89c23bd93e40e180d4fc727e691a698a6d522
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M scripts/simpletrace.py

  Log Message:
  -----------
  simpletrace: move event processing to Analyzer class

Moved event processing to the Analyzer class to separate specific analyzer
logic (like caching and function signatures) from the _process function.
This allows for new types of Analyzer-based subclasses without changing
the core code.

Note, that the fn_cache is important for performance in cases where the
analyzer is branching away from the catch-all a lot. The cache has no
measurable performance penalty.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-12-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 3470fef15a7bff730b00633346d28b889027a609
      
https://github.com/qemu/qemu/commit/3470fef15a7bff730b00633346d28b889027a609
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M scripts/simpletrace.py

  Log Message:
  -----------
  simpletrace: added simplified Analyzer2 class

By moving the dynamic argument construction to keyword-arguments,
we can remove all of the specialized handling, and streamline it.
If a tracing method wants to access these, they can define the
kwargs, or ignore it be placing `**kwargs` at the end of the
function's arguments list.

Added deprecation warning to Analyzer class to make users aware
of the Analyzer2 class. No removal date is planned.

Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-13-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 84197267d1620405c664f6d4510288d0fd3a8837
      
https://github.com/qemu/qemu/commit/84197267d1620405c664f6d4510288d0fd3a8837
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: add maintainer of simpletrace.py

In my work to refactor simpletrace.py, I noticed that there's no
maintainer of it, and has the status of "odd fixes". I'm using it from
time to time, so I'd like to maintain the script.

I've added myself as reviewer under "Tracing" to be informed of changes
that might affect simpletrace.py.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-14-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: ff014701ab0f09fdbf37b4c39334790f9b298253
      
https://github.com/qemu/qemu/commit/ff014701ab0f09fdbf37b4c39334790f9b298253
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M scripts/analyse-locks-simpletrace.py

  Log Message:
  -----------
  scripts/analyse-locks-simpletrace.py: changed iteritems() to items()

Python 3 removed `dict.iteritems()` in favor of `dict.items()`. This
means the script currently doesn't work on Python 3.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-15-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: d97fa9a00d5b333c8642670b7b55f9101d495dce
      
https://github.com/qemu/qemu/commit/d97fa9a00d5b333c8642670b7b55f9101d495dce
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M tests/tcg/tricore/Makefile.softmmu-target

  Log Message:
  -----------
  tests/tcg/tricore: Bump cpu to tc37x

we don't want to exclude ISA v1.6.2 insns from our tests.

Acked-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-Id: <20230828112651.522058-2-kbastian@mail.uni-paderborn.de>


  Commit: 3e2a5107c52f5bf7ed68f4b468cff5be456f1097
      
https://github.com/qemu/qemu/commit/3e2a5107c52f5bf7ed68f4b468cff5be456f1097
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M target/tricore/helper.h
    M target/tricore/op_helper.c
    M target/tricore/translate.c
    M target/tricore/tricore-opcodes.h
    M tests/tcg/tricore/Makefile.softmmu-target
    A tests/tcg/tricore/asm/test_crcn.S

  Log Message:
  -----------
  target/tricore: Implement CRCN insn

reported in https://gitlab.com/qemu-project/qemu/-/issues/1667

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230828112651.522058-3-kbastian@mail.uni-paderborn.de>


  Commit: ce64babdf60fb9a7de8bcac637243a10db1a3b26
      
https://github.com/qemu/qemu/commit/ce64babdf60fb9a7de8bcac637243a10db1a3b26
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M target/tricore/helper.c

  Log Message:
  -----------
  target/tricore: Correctly handle FPU RM from PSW

when we reconstructed PSW using psw_read(), we were trying to clear the
cached USB bits out of env->PSW. The mask was wrong and we would clear
PSW.RM as well.

when we write the PSW using psw_write() we update the rounding modes in
env->fp_status for softfloat. The order of bits used by TriCore is not
the one used by softfloat.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230828112651.522058-4-kbastian@mail.uni-paderborn.de>


  Commit: 2bdbe35632fc1f5f83054427085f59d28f45660f
      
https://github.com/qemu/qemu/commit/2bdbe35632fc1f5f83054427085f59d28f45660f
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M target/tricore/fpu_helper.c
    M target/tricore/helper.h
    M target/tricore/translate.c
    M tests/tcg/tricore/Makefile.softmmu-target
    A tests/tcg/tricore/asm/test_ftou.S

  Log Message:
  -----------
  target/tricore: Implement FTOU insn

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230828112651.522058-5-kbastian@mail.uni-paderborn.de>


  Commit: e43692bce684b76480df66473a9b3bec7a7d312a
      
https://github.com/qemu/qemu/commit/e43692bce684b76480df66473a9b3bec7a7d312a
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M target/tricore/fpu_helper.c

  Log Message:
  -----------
  target/tricore: Clarify special case for FTOUZ insn

this is not something other ISAs do, so clarify it with a comment.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230828112651.522058-6-kbastian@mail.uni-paderborn.de>


  Commit: 815061b9da88a3a9a90fae58b5a778632e0cc2df
      
https://github.com/qemu/qemu/commit/815061b9da88a3a9a90fae58b5a778632e0cc2df
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M target/tricore/fpu_helper.c
    M target/tricore/helper.c
    M target/tricore/helper.h
    M target/tricore/translate.c
    M target/tricore/tricore-opcodes.h
    M tests/tcg/tricore/Makefile.softmmu-target
    A tests/tcg/tricore/asm/test_ftohp.S

  Log Message:
  -----------
  target/tricore: Implement ftohp insn

reported in https://gitlab.com/qemu-project/qemu/-/issues/1667

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230828112651.522058-7-kbastian@mail.uni-paderborn.de>


  Commit: 5e0e06d9a2ce13d5b9832f0dddeaf5e2f4f70591
      
https://github.com/qemu/qemu/commit/5e0e06d9a2ce13d5b9832f0dddeaf5e2f4f70591
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M target/tricore/fpu_helper.c
    M target/tricore/helper.h
    M target/tricore/translate.c
    M target/tricore/tricore-opcodes.h
    M tests/tcg/tricore/Makefile.softmmu-target
    A tests/tcg/tricore/asm/test_hptof.S

  Log Message:
  -----------
  target/tricore: Implement hptof insn

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1667
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230828112651.522058-8-kbastian@mail.uni-paderborn.de>


  Commit: 23fa6f56b33f8fddf86ba4d027fb7d3081440cd9
      
https://github.com/qemu/qemu/commit/23fa6f56b33f8fddf86ba4d027fb7d3081440cd9
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M target/tricore/translate.c
    M tests/tcg/tricore/asm/macros.h
    M tests/tcg/tricore/asm/test_insert.S

  Log Message:
  -----------
  target/tricore: Fix RCPW/RRPW_INSERT insns for width = 0

we would crash if width was 0 for these insns, as tcg_gen_deposit() is
undefined for that case. For TriCore, width = 0 is a mov from the src reg
to the dst reg, so we special case this here.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230828112651.522058-9-kbastian@mail.uni-paderborn.de>


  Commit: 222ff2d3581e46731fe19644dfc4c4f36f39ac03
      
https://github.com/qemu/qemu/commit/222ff2d3581e46731fe19644dfc4c4f36f39ac03
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M target/tricore/translate.c
    M tests/tcg/tricore/asm/macros.h
    M tests/tcg/tricore/asm/test_insert.S

  Log Message:
  -----------
  target/tricore: Swap src and dst reg for RCRR_INSERT

Acked-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230828112651.522058-10-kbastian@mail.uni-paderborn.de>


  Commit: 1f22db19533c6e8b01274d12c161c063083e2fba
      
https://github.com/qemu/qemu/commit/1f22db19533c6e8b01274d12c161c063083e2fba
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M target/tricore/translate.c

  Log Message:
  -----------
  target/tricore: Replace cpu_*_code with translator_*

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230828112651.522058-11-kbastian@mail.uni-paderborn.de>


  Commit: 4f79db4750cbabed18f11cd791c5e5222a711fd5
      
https://github.com/qemu/qemu/commit/4f79db4750cbabed18f11cd791c5e5222a711fd5
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M target/tricore/translate.c

  Log Message:
  -----------
  target/tricore: Fix FTOUZ being ISA v1.3.1 up

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230828112651.522058-12-kbastian@mail.uni-paderborn.de>


  Commit: 8c3cf3f2bdf072b5ead13db81f1e6d879cd09bb6
      
https://github.com/qemu/qemu/commit/8c3cf3f2bdf072b5ead13db81f1e6d879cd09bb6
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M tests/tcg/tricore/asm/macros.h

  Log Message:
  -----------
  tests/tcg/tricore: Extended and non-extened regs now match

RSx for d regs and e regs now use the same numbering. This makes sure
that mixing d and e registers in an insn test will not overwrite data
between registers.

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230913105326.40832-2-kbastian@mail.uni-paderborn.de>


  Commit: d224aabca40d1b580b69961702bacac3f33c7fc3
      
https://github.com/qemu/qemu/commit/d224aabca40d1b580b69961702bacac3f33c7fc3
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M hw/tricore/tricore_testdevice.c

  Log Message:
  -----------
  hw/tricore: Log failing test in testdevice

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230913105326.40832-3-kbastian@mail.uni-paderborn.de>


  Commit: ac8b435467871f835ea4eb05231cd54c20706f6b
      
https://github.com/qemu/qemu/commit/ac8b435467871f835ea4eb05231cd54c20706f6b
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M tests/tcg/tricore/asm/macros.h

  Log Message:
  -----------
  tests/tcg: Reset result register after each test

some insns use the result register implicitly as an input. Thus, we
could end up with data from the previous insn spilling over.

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230913105326.40832-4-kbastian@mail.uni-paderborn.de>


  Commit: fc0d69a46c229dced4f5918a5998d3e341255ee2
      
https://github.com/qemu/qemu/commit/fc0d69a46c229dced4f5918a5998d3e341255ee2
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M tests/tcg/tricore/Makefile.softmmu-target
    M tests/tcg/tricore/asm/macros.h
    A tests/tcg/tricore/asm/test_arith.S

  Log Message:
  -----------
  tests/tcg/tricore: Add test for all arith insns up to addx

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230913105326.40832-5-kbastian@mail.uni-paderborn.de>


  Commit: ae8b974313b5468502d039b9dd54aca80f23870e
      
https://github.com/qemu/qemu/commit/ae8b974313b5468502d039b9dd54aca80f23870e
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M tests/tcg/tricore/asm/macros.h
    M tests/tcg/tricore/asm/test_arith.S

  Log Message:
  -----------
  tests/tcg/tricore: Add test from 'and' to 'csub'

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230913105326.40832-6-kbastian@mail.uni-paderborn.de>


  Commit: 121a8d9a3382c11f8db0b2aa3a71e0a8fcb8822b
      
https://github.com/qemu/qemu/commit/121a8d9a3382c11f8db0b2aa3a71e0a8fcb8822b
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M tests/tcg/tricore/asm/macros.h
    M tests/tcg/tricore/asm/test_arith.S

  Log Message:
  -----------
  tests/tcg/tricore: Add test from 'dextr' to 'lt'

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230913105326.40832-7-kbastian@mail.uni-paderborn.de>


  Commit: 1d5ff96220fbf1001d6390a9b9a024e501c66edb
      
https://github.com/qemu/qemu/commit/1d5ff96220fbf1001d6390a9b9a024e501c66edb
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M tests/tcg/tricore/asm/macros.h
    M tests/tcg/tricore/asm/test_arith.S

  Log Message:
  -----------
  tests/tcg/tricore: Add test from 'max' to 'shas'

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230913105326.40832-8-kbastian@mail.uni-paderborn.de>


  Commit: 7bfa7436d8bab1b528b85367dddcd047f312723b
      
https://github.com/qemu/qemu/commit/7bfa7436d8bab1b528b85367dddcd047f312723b
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M tests/tcg/tricore/asm/test_arith.S

  Log Message:
  -----------
  tests/tcg/tricore: Add test from 'shuffle' to 'xor.t'

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230913105326.40832-9-kbastian@mail.uni-paderborn.de>


  Commit: 85002916e19aa33e58efe40b061bbd5bea0ccbfc
      
https://github.com/qemu/qemu/commit/85002916e19aa33e58efe40b061bbd5bea0ccbfc
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M target/tricore/cpu.h

  Log Message:
  -----------
  target/tricore: Remove CSFRs from cpu.h

these are already defined in 'csfr.h.inc'. We don't need to duplicate
these registers.

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230913105326.40832-10-kbastian@mail.uni-paderborn.de>


  Commit: 080ca1baa84316a58790b6507de89fabf4c40ec0
      
https://github.com/qemu/qemu/commit/080ca1baa84316a58790b6507de89fabf4c40ec0
  Author: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M target/tricore/op_helper.c

  Log Message:
  -----------
  target/tricore: Change effective address (ea) to target_ulong

as this is an effective address and those cannot be signed,
it should not be a signed integer.

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <20230913105326.40832-11-kbastian@mail.uni-paderborn.de>


  Commit: 696ff346366fc292dc9b32cd65f9e379d45e5428
      
https://github.com/qemu/qemu/commit/696ff346366fc292dc9b32cd65f9e379d45e5428
  Author: Stefan Hajnoczi <stefanha@redhat.com>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M hw/tricore/tricore_testdevice.c
    M target/tricore/cpu.h
    M target/tricore/fpu_helper.c
    M target/tricore/helper.c
    M target/tricore/helper.h
    M target/tricore/op_helper.c
    M target/tricore/translate.c
    M target/tricore/tricore-opcodes.h
    M tests/tcg/tricore/Makefile.softmmu-target
    M tests/tcg/tricore/asm/macros.h
    A tests/tcg/tricore/asm/test_arith.S
    A tests/tcg/tricore/asm/test_crcn.S
    A tests/tcg/tricore/asm/test_ftohp.S
    A tests/tcg/tricore/asm/test_ftou.S
    A tests/tcg/tricore/asm/test_hptof.S
    M tests/tcg/tricore/asm/test_insert.S

  Log Message:
  -----------
  Merge tag 'pull-tricore-20230928' of https://github.com/bkoppelmann/qemu into 
staging

- Add FTOU, CRCN, FTOHP, and HPTOF insns
- Add test for arithmetic TriCore insns

# -----BEGIN PGP SIGNATURE-----
#
# iQJTBAABCgA9FiEEbmNqfoPy3Qz6bm43CtLGOWtpyhQFAmUVPVgfHGtiYXN0aWFu
# QG1haWwudW5pLXBhZGVyYm9ybi5kZQAKCRAK0sY5a2nKFFzmD/9iWljlOkYEH/pe
# AJXi08MAFtVxZ7b5pkv4a/oMVy+/RtqXnTLqsh3RChby0YNaY9t4ySXCDk9n1E7c
# zrJ6dPzJ7MhNSOz9Hz0uHYZrY9ZVKsjr6GT/VMy1QcHm5z47gzNn0NwJ9WVImr4R
# Dv80PYcMueP08LHO81tACSV0ppxcg1WgRV+onyX9BgZVbdh51JS313OvtUfvvwyC
# pBxzzyZccXkLlzm0ObcEUbTCJ+fGOJ3jwHwBIEaEZFujdmBU2sM8+BTV0FgyvwH/
# 2JuM1GlKxef2lT9JInfzbwturtaKCj4uBhtw7Jvj69rQlIbal+m0AYAbr20xWCiD
# DPt6UeO9xFy+2LvjxQFv3iAFSjRvdQwYTnnq/on8LQ4y+m7fZ2a0Utl8OZlj/pX8
# 0LDPspC10aSxzqBYqkjTaahzGZbZmLapV4eAwrHNHa3JnOGk45paOJFX2JnPB1gB
# T2O8Mc738I1M6qPQzSMrM8y7xlRi97kUpF5BLfYUdjNpUVb03KIK9aEq74paAU+a
# IZTwE7U+8jn7ZEzFwMRIu0rg+bFi1ZlMmvDZm9kbBHQwoZ5xPoyEIoITlXw4B/Kk
# vg2bLz6SH+tzu9DLcoWg7FupxNE3VOtJgkGXCN2tkYoJwDE9wjVpGYJ1anW+fTZN
# J8/iunffflAyaLkRh5hi5iklvHqOeA==
# =3Fk7
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu 28 Sep 2023 04:46:16 EDT
# gpg:                using RSA key 6E636A7E83F2DD0CFA6E6E370AD2C6396B69CA14
# gpg:                issuer "kbastian@mail.uni-paderborn.de"
# gpg: Can't check signature: No public key

* tag 'pull-tricore-20230928' of https://github.com/bkoppelmann/qemu: (21 
commits)
  target/tricore: Change effective address (ea) to target_ulong
  target/tricore: Remove CSFRs from cpu.h
  tests/tcg/tricore: Add test from 'shuffle' to 'xor.t'
  tests/tcg/tricore: Add test from 'max' to 'shas'
  tests/tcg/tricore: Add test from 'dextr' to 'lt'
  tests/tcg/tricore: Add test from 'and' to 'csub'
  tests/tcg/tricore: Add test for all arith insns up to addx
  tests/tcg: Reset result register after each test
  hw/tricore: Log failing test in testdevice
  tests/tcg/tricore: Extended and non-extened regs now match
  target/tricore: Fix FTOUZ being ISA v1.3.1 up
  target/tricore: Replace cpu_*_code with translator_*
  target/tricore: Swap src and dst reg for RCRR_INSERT
  target/tricore: Fix RCPW/RRPW_INSERT insns for width = 0
  target/tricore: Implement hptof insn
  target/tricore: Implement ftohp insn
  target/tricore: Clarify special case for FTOUZ insn
  target/tricore: Implement FTOU insn
  target/tricore: Correctly handle FPU RM from PSW
  target/tricore: Implement CRCN insn
  ...

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 12f1b8f113d884bcd556f3eda6b1837f4c56eb00
      
https://github.com/qemu/qemu/commit/12f1b8f113d884bcd556f3eda6b1837f4c56eb00
  Author: Stefan Hajnoczi <stefanha@redhat.com>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M MAINTAINERS
    M scripts/analyse-locks-simpletrace.py
    M scripts/simpletrace.py

  Log Message:
  -----------
  Merge tag 'tracing-pull-request' of https://gitlab.com/stefanha/qemu into 
staging

Pull request

- Mads Ynddal's improvements to simpletrace.py

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmUVgyAACgkQnKSrs4Gr
# c8jxkAf/TVtEZTPDvQMz7PNEsAdGLREwYKrsUXHtqOrINbVL1slrJ1qYmygeJltq
# 37CAcxBzvnaH7y2jF8JPKWK3sO3x1fc2ocA72BZt3kuim5T7MojJgFfAN/PdwRHf
# q1a+lYJHKOi0BV4yWPmPHnCSXOohHbJfRBxwZgwFEZMbWdlkAm6m+JFUqn+Vd5ee
# 4vEBxrNMY28H02OeoFNBQPCLRHrkeH4EVj+DP5TAk1H1ehoZeH45UoUsopEfD51z
# IyiXxzumtgpCMyC/jXS5BY6VStW7lDLoDscflMQ/l7ITEtm7Hj2fnPcp/aRKoEUk
# p1JuoSm8YrwnwMokFsQCbkYWkBWieQ==
# =rrnI
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu 28 Sep 2023 09:44:00 EDT
# gpg:                using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>" [ultimate]
# gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>" [ultimate]
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* tag 'tracing-pull-request' of https://gitlab.com/stefanha/qemu:
  scripts/analyse-locks-simpletrace.py: changed iteritems() to items()
  MAINTAINERS: add maintainer of simpletrace.py
  simpletrace: added simplified Analyzer2 class
  simpletrace: move event processing to Analyzer class
  simpletrace: move logic of process into internal function
  simpletrace: refactor to separate responsibilities
  simpletrace: made Analyzer into context-manager
  simpletrace: define exception and add handling
  simpletrace: improved error handling on struct unpack
  simpletrace: update code for Python 3.11
  simpletrace: changed naming of edict and idtoname to improve readability
  simpletrace: improve parsing of sys.argv; fix files never closed.
  simpletrace: annotate magic constants from QEMU code
  simpletrace: add __all__ to define public interface

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


Compare: https://github.com/qemu/qemu/compare/36e9aab3c569...12f1b8f113d8



reply via email to

[Prev in Thread] Current Thread [Next in Thread]