[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 58b4de: softmmu: Fix dirtylimit memory leak
|
From: |
Alex Bennée |
|
Subject: |
[Qemu-commits] [qemu/qemu] 58b4de: softmmu: Fix dirtylimit memory leak |
|
Date: |
Wed, 30 Aug 2023 09:23:00 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 58b4def2a28b38d7c5d49e99beb31e45936b1096
https://github.com/qemu/qemu/commit/58b4def2a28b38d7c5d49e99beb31e45936b1096
Author: alloc.young <alloc.young@outlook.com>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M softmmu/dirtylimit.c
Log Message:
-----------
softmmu: Fix dirtylimit memory leak
Fix memory leak in hmp_info_vcpu_dirty_limit,use g_autoptr
to handle memory deallocation.
Signed-off-by: alloc.young <alloc.young@outlook.com>
Reviewed-by: Hyman Huang <yong.huang@smartx.com>
Message-Id:
<SA1PR11MB6760B9AB7EAFBDAFB524ED06F5E3A@SA1PR11MB6760.namprd11.prod.outlook.com>
Signed-off-by: Hyman Huang <yong.huang@smartx.com>
Commit: 19b14cea453b7429a06922fe96e55e6b32fe718a
https://github.com/qemu/qemu/commit/19b14cea453b7429a06922fe96e55e6b32fe718a
Author: alloc.young <alloc.young@outlook.com>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M softmmu/dirtylimit.c
Log Message:
-----------
softmmu/dirtylimit: Convert free to g_free
Convert free to g_free to match g_new and g_malloc functions.
Fixes: cc2b33eab0 ("softmmu/dirtylimit: Implement vCPU dirtyrate calculation
periodically")
Fixes: baa609832e ("softmmu/dirtylimit: Implement virtual CPU throttle")
Signed-off-by: alloc.young <alloc.young@outlook.com>
Reviewed-by: Hyman Huang <yong.huang@smartx.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id:
<SA1PR11MB67604ECD85AFF34BEB3072F7F5E3A@SA1PR11MB6760.namprd11.prod.outlook.com>
Signed-off-by: Hyman Huang <yong.huang@smartx.com>
Commit: 3eb82637fbf8c0471990b59e6733fd4beb1f9939
https://github.com/qemu/qemu/commit/3eb82637fbf8c0471990b59e6733fd4beb1f9939
Author: Andrei Gudkov <gudkov.andrei@huawei.com>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M migration/dirtyrate.c
Log Message:
-----------
migration/dirtyrate: Fix precision losses and g_usleep overshoot
Signed-off-by: Andrei Gudkov <gudkov.andrei@huawei.com>
Reviewed-by: Hyman Huang <yong.huang@smartx.com>
Message-Id:
<8ddb0d40d143f77aab8f602bd494e01e5fa01614.1691161009.git.gudkov.andrei@huawei.com>
Signed-off-by: Hyman Huang <yong.huang@smartx.com>
Commit: 86e4f93d827d3c1efd00cd8a906e38a2c0f2b5bc
https://github.com/qemu/qemu/commit/86e4f93d827d3c1efd00cd8a906e38a2c0f2b5bc
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M softmmu/physmem.c
Log Message:
-----------
softmmu: Assert data in bounds in iotlb_to_section
Acked-by: Alex Bennée <alex.bennee@linaro.org>
Suggested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 0d58c660689f6da1e3feff8a997014003d928b3b
https://github.com/qemu/qemu/commit/0d58c660689f6da1e3feff8a997014003d928b3b
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M accel/tcg/cpu-exec-common.c
M include/exec/cpu-common.h
M softmmu/physmem.c
Log Message:
-----------
softmmu: Use async_run_on_cpu in tcg_commit
After system startup, run the update to memory_dispatch
and the tlb_flush on the cpu. This eliminates a race,
wherein a running cpu sees the memory_dispatch change
but has not yet seen the tlb_flush.
Since the update now happens on the cpu, we need not use
qatomic_rcu_read to protect the read of memory_dispatch.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1826
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1834
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1846
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 77fafcb50046f6c683f3cab9df975fdab43e1a68
https://github.com/qemu/qemu/commit/77fafcb50046f6c683f3cab9df975fdab43e1a68
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M tcg/tcg-op-vec.c
Log Message:
-----------
tcg: Remove vecop_list check from tcg_gen_not_vec
The not pattern is always available via generic expansion.
See debug block in tcg_can_emit_vecop_list.
Fixes: 11978f6f58 ("tcg: Fix expansion of INDEX_op_not_vec")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: dad2f2f5afbaf58d6056f31dfd4b9edd0854b8ab
https://github.com/qemu/qemu/commit/dad2f2f5afbaf58d6056f31dfd4b9edd0854b8ab
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M tcg/sparc64/tcg-target.c.inc
M tcg/sparc64/tcg-target.h
Log Message:
-----------
tcg/sparc64: Disable TCG_TARGET_HAS_extr_i64_i32
Since a59a29312660 ("tcg/sparc64: Remove sparc32plus constraints")
we no longer distinguish registers with 32 vs 64 bits.
Therefore we can remove support for the backend-specific
type change opcodes.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 669fd6151337fdc81e34f7eb4940ba2f20d89957
https://github.com/qemu/qemu/commit/669fd6151337fdc81e34f7eb4940ba2f20d89957
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M include/exec/cpu_ldst.h
Log Message:
-----------
Revert "include/exec: typedef abi_ptr to vaddr in softmmu"
This reverts commit fc15bfb6a6bda8d4d01f1383579d385acae17c0f.
This patch caused a regression for tricore-softmmu,
./tests/tcg/tricore-softmmu/test_boot_to_main.c.tst.
Reported-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: f187609f27b261702a17f79d20bf252ee0d4f9cd
https://github.com/qemu/qemu/commit/f187609f27b261702a17f79d20bf252ee0d4f9cd
Author: Fabiano Rosas <farosas@suse.de>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
M migration/block.c
Log Message:
-----------
block-migration: Ensure we don't crash during migration cleanup
We can fail the blk_insert_bs() at init_blk_migration(), leaving the
BlkMigDevState without a dirty_bitmap and BlockDriverState. Account
for the possibly missing elements when doing cleanup.
Fix the following crashes:
Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault.
0x0000555555ec83ef in bdrv_release_dirty_bitmap (bitmap=0x0) at
../block/dirty-bitmap.c:359
359 BlockDriverState *bs = bitmap->bs;
#0 0x0000555555ec83ef in bdrv_release_dirty_bitmap (bitmap=0x0) at
../block/dirty-bitmap.c:359
#1 0x0000555555bba331 in unset_dirty_tracking () at ../migration/block.c:371
#2 0x0000555555bbad98 in block_migration_cleanup_bmds () at
../migration/block.c:681
Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault.
0x0000555555e971ff in bdrv_op_unblock (bs=0x0, op=BLOCK_OP_TYPE_BACKUP_SOURCE,
reason=0x0) at ../block.c:7073
7073 QLIST_FOREACH_SAFE(blocker, &bs->op_blockers[op], list, next) {
#0 0x0000555555e971ff in bdrv_op_unblock (bs=0x0,
op=BLOCK_OP_TYPE_BACKUP_SOURCE, reason=0x0) at ../block.c:7073
#1 0x0000555555e9734a in bdrv_op_unblock_all (bs=0x0, reason=0x0) at
../block.c:7095
#2 0x0000555555bbae13 in block_migration_cleanup_bmds () at
../migration/block.c:690
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Message-id: 20230731203338.27581-1-farosas@suse.de
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: c54483b6f45a0c84e230728a1a9e7adf90345e15
https://github.com/qemu/qemu/commit/c54483b6f45a0c84e230728a1a9e7adf90345e15
Author: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
M block.c
M block/qcow2.c
M include/block/block-common.h
Log Message:
-----------
block: add subcluster_size field to BlockDriverInfo
This is going to be used in the subsequent commit as requests alignment
(in particular, during copy-on-read). This value only makes sense for
the formats which support subclusters (currently QCOW2 only). If this
field isn't set by driver's own bdrv_get_info() implementation, we
simply set it equal to the cluster size thus treating each cluster as
having a single subcluster.
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20230711172553.234055-2-andrey.drobyshev@virtuozzo.com>
Commit: fc6b211f920a68f4c9c8db91ccc35ca95fe6683a
https://github.com/qemu/qemu/commit/fc6b211f920a68f4c9c8db91ccc35ca95fe6683a
Author: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
M block/io.c
M block/mirror.c
M include/block/block-io.h
Log Message:
-----------
block/io: align requests to subcluster_size
When target image is using subclusters, and we align the request during
copy-on-read, it makes sense to align to subcluster_size rather than
cluster_size. Otherwise we end up with unnecessary allocations.
This commit renames bdrv_round_to_clusters() to bdrv_round_to_subclusters()
and utilizes subcluster_size field of BlockDriverInfo to make necessary
alignments. It affects copy-on-read as well as mirror job (which is
using bdrv_round_to_clusters()).
This change also fixes the following bug with failing assert (covered by
the test in the subsequent commit):
qemu-img create -f qcow2 base.qcow2 64K
qemu-img create -f qcow2 -o
extended_l2=on,backing_file=base.qcow2,backing_fmt=qcow2 img.qcow2 64K
qemu-io -c "write -P 0xaa 0 2K" img.qcow2
qemu-io -C -c "read -P 0x00 2K 62K" img.qcow2
qemu-io: ../block/io.c:1236: bdrv_co_do_copy_on_readv: Assertion `skip_bytes <
pnum' failed.
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20230711172553.234055-3-andrey.drobyshev@virtuozzo.com>
Commit: e2f938265e0aa8486303d260f3cb13d5bb9e9d6a
https://github.com/qemu/qemu/commit/e2f938265e0aa8486303d260f3cb13d5bb9e9d6a
Author: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
M tests/qemu-iotests/197
M tests/qemu-iotests/197.out
Log Message:
-----------
tests/qemu-iotests/197: add testcase for CoR with subclusters
Add testcase which checks that allocations during copy-on-read are
performed on the subcluster basis when subclusters are enabled in target
image.
This testcase also triggers the following assert with previous commit
not being applied, so we check that as well:
qemu-io: ../block/io.c:1236: bdrv_co_do_copy_on_readv: Assertion `skip_bytes <
pnum' failed.
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20230711172553.234055-4-andrey.drobyshev@virtuozzo.com>
Commit: 87ec6f55af38e29be5b2b65a8acf84da73e06d06
https://github.com/qemu/qemu/commit/87ec6f55af38e29be5b2b65a8acf84da73e06d06
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
M util/fdmon-io_uring.c
Log Message:
-----------
aio-posix: zero out io_uring sqe user_data
liburing does not clear sqe->user_data. We must do it ourselves to avoid
undefined behavior in process_cqe() when user_data is used.
Note that fdmon-io_uring is currently disabled, so this is a latent bug
that does not affect users. Let's merge this fix now to make it easier
to enable fdmon-io_uring in the future (and I'm working on that).
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20230426212639.82310-1-stefanha@redhat.com>
Commit: ef9d20c63b64989ce4941dc48531c50728ddcc21
https://github.com/qemu/qemu/commit/ef9d20c63b64989ce4941dc48531c50728ddcc21
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
M accel/tcg/cpu-exec-common.c
M include/exec/cpu-common.h
M include/exec/cpu_ldst.h
M softmmu/physmem.c
M tcg/sparc64/tcg-target.c.inc
M tcg/sparc64/tcg-target.h
M tcg/tcg-op-vec.c
Log Message:
-----------
Merge tag 'pull-tcg-20230829-2' of https://gitlab.com/rth7680/qemu into
staging
softmmu: Use async_run_on_cpu in tcg_commit
tcg: Remove vecop_list check from tcg_gen_not_vec
tcg/sparc64: Disable TCG_TARGET_HAS_extr_i64_i32
Revert "include/exec: typedef abi_ptr to vaddr in softmmu"
# -----BEGIN PGP SIGNATURE-----
#
# iQFRBAABCgA7FiEEekgeeIaLTbaoWgXAZN846K9+IV8FAmTuOcYdHHJpY2hhcmQu
# aGVuZGVyc29uQGxpbmFyby5vcmcACgkQZN846K9+IV9gGwf/QzbRP8MknlCZXrkZ
# ykIZAkE4gRUb64Wzc2Oz1XaueltgBGRCS338oE8umtcLKTngZ8rVFD/LPTIEyAEY
# SOzdHEJLPMSUv54rjAV8W4mVku81E9QvzOgz8PIzFM0mDiPJ/lG6JBTee/IZJHr3
# cW9W/2XMEz2rS2ONPj7WXbVbk/1ao29JFlhcWKNauUfqrNWK+VWOpo2w5qfgJruz
# mjOSiMErU7SijytrKG9GP3Ri1JGskocfGcYYPofz8j6lmQoZrT6aYUj2tJTL8rvQ
# Js+JCP8ZCXFO8/2jJqOivQccBGmLi8wf6Ke777xE0tAqfzXqBOp4tvJbv28e8lja
# p+Lqhg==
# =KPna
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 29 Aug 2023 14:32:38 EDT
# gpg: using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg: issuer "richard.henderson@linaro.org"
# gpg: Good signature from "Richard Henderson <richard.henderson@linaro.org>"
[full]
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A 05C0 64DF 38E8 AF7E 215F
* tag 'pull-tcg-20230829-2' of https://gitlab.com/rth7680/qemu:
Revert "include/exec: typedef abi_ptr to vaddr in softmmu"
tcg/sparc64: Disable TCG_TARGET_HAS_extr_i64_i32
tcg: Remove vecop_list check from tcg_gen_not_vec
softmmu: Use async_run_on_cpu in tcg_commit
softmmu: Assert data in bounds in iotlb_to_section
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: ee89152d4145ed017cc3cd820aa5e6d62bda9355
https://github.com/qemu/qemu/commit/ee89152d4145ed017cc3cd820aa5e6d62bda9355
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
M migration/dirtyrate.c
M softmmu/dirtylimit.c
Log Message:
-----------
Merge tag 'dirtylimit-dirtyrate-pull-request' of
https://github.com/newfriday/qemu into staging
Dirtylimit and dirtyrate 20230829 patches PULL request
Correct memory leaks in dirtylimit and accuracy losses in
dirtyrate, respectively; make minor corrections to overshoot
and memory deallocation.
This is v3 with a signed tag. Please apply.
Thanks, Yong.
# -----BEGIN PGP SIGNATURE-----
# Version: GnuPG v2.0.22 (GNU/Linux)
#
# iQIcBAABAgAGBQJk7VtOAAoJEN/yI9az/suchasP/j/7DQTggrrB/2lWhB79BTrT
# L+Tgljh9zynrJeL/OjvE7VD3sxDcHQmHprGT7FkdgIdd3fHl8GHnFz8L1CMLg63E
# i/4SY3RFIvmMqMrmBNx77+D6nSfezKrkwmoln7VGjK6rC0s86PRok+Dxf4SaoP1i
# cCeFOq2O0U/im1fQQl0uETqxYAX+StVRhnpWTqpPFBBaVCmCGQx3WWXGXXFOl5PB
# JNLgDX3lxSpSIfRK9vCb61gFe8gMp+5hUDZgfUln9fmXrO6NsVgHEjvsMqm9UZO1
# tNGSh1GNmO2du6m2iCzVChB8bfe9P3g/XAubfRIkqZtWZK8lhz1mVQEg4wJ4VgX1
# uMAi8gzpMV5Rdiy9MWYZW9sCuoiZepksBuGtrFMBXXyCpP76N+uWshfj+/Mp2mt0
# 475ZiC4silwCeRDWH4UkTyNQtc7+WVRjZP0ToXuUOSyWFdyRPCQdAIDlUacxk/9p
# BSymBM2P760oa4IMCwhey5/WaFdfFFcMD4e2UwfTpafwY5uwVOTxN23k7+iCivQs
# 3RbP8ghvakgNPTO+1HcdoRW/LrjnGn1mZ5qvLj1+f7slP5NEsBDZVEylQJIHjXh4
# oE8OwB/rRexlUGRUuIgMpVeEk8/LcEMy73I+dj/zSkfQEw8KuCp6EUB5HFiciS0/
# IG5X0TdcvAdicG8qmDGx
# =NKkN
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 28 Aug 2023 22:43:26 EDT
# gpg: using RSA key DFF223D6B3FECB9C
# gpg: Can't check signature: No public key
* tag 'dirtylimit-dirtyrate-pull-request' of https://github.com/newfriday/qemu:
migration/dirtyrate: Fix precision losses and g_usleep overshoot
softmmu/dirtylimit: Convert free to g_free
softmmu: Fix dirtylimit memory leak
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: 156618d9ea67f2f2e31d9dedd97f2dcccbe6808c
https://github.com/qemu/qemu/commit/156618d9ea67f2f2e31d9dedd97f2dcccbe6808c
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
M block.c
M block/io.c
M block/mirror.c
M block/qcow2.c
M include/block/block-common.h
M include/block/block-io.h
M migration/block.c
M tests/qemu-iotests/197
M tests/qemu-iotests/197.out
M util/fdmon-io_uring.c
Log Message:
-----------
Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into
staging
Pull request
v3:
- Drop UFS emulation due to CI failures
- Add "aio-posix: zero out io_uring sqe user_data"
# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmTvLIEACgkQnKSrs4Gr
# c8itVggAka3RMkEclbeW7JKJBOolm3oUuJTobV8oJfDNMQ8mmom9JkXVUctyPWQT
# EF+oeqZz1omjr0Dk7YEA2toCahTbXm/UsG7i6cZg8JXPl6e9sOne0j+p5zO5x/kc
# YlG43SBQJHdp/BfTm/gvwUh0W2on0wadaeEV82m3ZyIrZGTgNcrC1p1gj5dwF5VX
# SqW02mgALETECyJpo8O7y9vNUYGxEtETG9jzAhtrugGpYk4bPeXlm/rc+2zwV+ET
# YCnfUvhjhlu5vS4nkta6natg0If16ODjy35vWYm/aGlgveGTqQq9HWgTL71eNuxm
# Smn+hJHuvkyBclKjbGiiO1W1MuG1/g==
# =UvNK
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 30 Aug 2023 07:48:17 EDT
# gpg: using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>" [ultimate]
# gpg: aka "Stefan Hajnoczi <stefanha@gmail.com>" [ultimate]
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35 775A 9CA4 ABB3 81AB 73C8
* tag 'block-pull-request' of https://gitlab.com/stefanha/qemu:
aio-posix: zero out io_uring sqe user_data
tests/qemu-iotests/197: add testcase for CoR with subclusters
block/io: align requests to subcluster_size
block: add subcluster_size field to BlockDriverInfo
block-migration: Ensure we don't crash during migration cleanup
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Compare: https://github.com/qemu/qemu/compare/813bac3d8d70...156618d9ea67
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 58b4de: softmmu: Fix dirtylimit memory leak,
Alex Bennée <=