[Qemu-commits] [qemu/qemu] 6a2c23: accel/tcg: Avoid reading too much in load_atom_{2, 4}

[Richard Henderson]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 6a2c23ddeb5bc8883c227ce1a3ff22e9978291af
      
https://github.com/qemu/qemu/commit/6a2c23ddeb5bc8883c227ce1a3ff22e9978291af
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-08-10 (Thu, 10 Aug 2023)

  Changed paths:
    M accel/tcg/ldst_atomicity.c.inc
    M tests/tcg/aarch64/Makefile.target
    A tests/tcg/aarch64/lse2-fault.c

  Log Message:
  -----------
  accel/tcg: Avoid reading too much in load_atom_{2,4}

When load_atom_extract_al16_or_al8 is inexpensive, we want to use
it early, in order to avoid the overhead of required_atomicity.
However, we must not read past the end of the page.

If there are more than 8 bytes remaining, then both the "aligned 16"
and "aligned 8" paths align down so that the read has at least
16 bytes remaining on the page.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: dad1036f43b55c68eb76e73ef771b252ec764b14
      
https://github.com/qemu/qemu/commit/dad1036f43b55c68eb76e73ef771b252ec764b14
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-08-10 (Thu, 10 Aug 2023)

  Changed paths:
    M tests/guest-debug/run-test.py

  Log Message:
  -----------
  tests/tcg: ensure system-mode gdb tests start stopped

Without -S we run into potential races with tests starting before the
gdbstub attaches. We don't need to worry about user-mode as enabling
the gdbstub implies we wait for the initial connection.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230810153640.1879717-7-alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 3869eb7eee6f6c00d51e8ce8fd71a769f3e0bf3e
      
https://github.com/qemu/qemu/commit/3869eb7eee6f6c00d51e8ce8fd71a769f3e0bf3e
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-08-10 (Thu, 10 Aug 2023)

  Changed paths:
    M gdbstub/gdbstub.c
    M gdbstub/trace-events

  Log Message:
  -----------
  gdbstub: more fixes for client Ctrl-C handling

The original fix caused problems with spurious characters on other
system emulation. So:

  - instead of spamming output make the warning a trace point
  - ensure we only allow a stop reply if it was 0x3

Suggested-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: 
<456ed3318421dd7946bdfb5ceda7e05332da368c.1690910333.git.quic_mathbern@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230810153640.1879717-8-alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: f1b0f894c8c25f7ed24197ff130c7acb6b9fd6e7
      
https://github.com/qemu/qemu/commit/f1b0f894c8c25f7ed24197ff130c7acb6b9fd6e7
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-08-10 (Thu, 10 Aug 2023)

  Changed paths:
    M gdbstub/gdbstub.c

  Log Message:
  -----------
  gdbstub: don't complain about preemptive ACK chars

When starting a remote connection GDB sends an '+':

  /* Ack any packet which the remote side has already sent.  */
  remote_serial_write ("+", 1);

which gets flagged as a garbage character in the gdbstub state
machine. As gdb does send it out lets be permissive about the handling
so we can better see real issues.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: gdb-patches@sourceware.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230810153640.1879717-9-alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 70b73990d5e2e8e1ce63274b6b85888bef2957aa
      
https://github.com/qemu/qemu/commit/70b73990d5e2e8e1ce63274b6b85888bef2957aa
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-08-10 (Thu, 10 Aug 2023)

  Changed paths:
    M accel/tcg/ldst_atomicity.c.inc
    M gdbstub/gdbstub.c
    M gdbstub/trace-events
    M tests/guest-debug/run-test.py
    M tests/tcg/aarch64/Makefile.target
    A tests/tcg/aarch64/lse2-fault.c

  Log Message:
  -----------
  Merge tag 'pull-tcg-20230810' of https://gitlab.com/rth7680/qemu into staging

accel/tcg: Avoid reading too much in load_atom_{2,4}
tests/tcg: ensure system-mode gdb tests start stopped
gdbstub: more fixes for client Ctrl-C handling

# -----BEGIN PGP SIGNATURE-----
#
# iQFRBAABCgA7FiEEekgeeIaLTbaoWgXAZN846K9+IV8FAmTVJ4EdHHJpY2hhcmQu
# aGVuZGVyc29uQGxpbmFyby5vcmcACgkQZN846K9+IV+/iAf9EUojONGO1FQCUokR
# +8kfHFaGH5R5U4v6Zd6xlwHt94iagW8s+DdpM/YdmgZFxQ5jglCCsLOXQYtJ/HPu
# McKRv86Yr264ysrwYzTuyOLIC585UU0KzYbGBQvjCSeQ43Au5bR/3ec35Lwgm7OO
# eukLdpmuD4QoSgBmVgkbziKH1zaX8NjgPoWGfFqxfzzWUZBfU4VfyLgGKw2gtqoz
# fMTORiqbnzSvQfYINNJ0qBTyXWm0YmydDzaK6zfBrsCzdMk3JYksxgneItvqgRar
# A5UAYUPhBPftIyTAnI3PQo+siyuaDhFRU9BwHb25a/pkuOUg8PBFO2HruseLmmdl
# bPcnhQ==
# =7c0w
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu 10 Aug 2023 11:08:01 AM PDT
# gpg:                using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg:                issuer "richard.henderson@linaro.org"
# gpg: Good signature from "Richard Henderson <richard.henderson@linaro.org>" 
[ultimate]

* tag 'pull-tcg-20230810' of https://gitlab.com/rth7680/qemu:
  gdbstub: don't complain about preemptive ACK chars
  gdbstub: more fixes for client Ctrl-C handling
  tests/tcg: ensure system-mode gdb tests start stopped
  accel/tcg: Avoid reading too much in load_atom_{2,4}

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/64d3be986f9e...70b73990d5e2