[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] a36c86: qga/qapi-schema: Tidy up documentatio
|
From: |
Richard Henderson |
|
Subject: |
[Qemu-commits] [qemu/qemu] a36c86: qga/qapi-schema: Tidy up documentation of guest-fs... |
|
Date: |
Fri, 28 Apr 2023 14:06:38 -0700 |
Branch: refs/heads/staging
Home: https://github.com/qemu/qemu
Commit: a36c865370818ec7dc4e0fae0f59dca07a7c07bb
https://github.com/qemu/qemu/commit/a36c865370818ec7dc4e0fae0f59dca07a7c07bb
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qga/qapi-schema.json
Log Message:
-----------
qga/qapi-schema: Tidy up documentation of guest-fsfreeze-status
Delete "error state indicates", because it doesn't make sense.
I suspect it was an accident.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230425064223.820979-2-armbru@redhat.com>
Commit: 573a5fab3e585cdff4aceda757f471ada953274e
https://github.com/qemu/qemu/commit/573a5fab3e585cdff4aceda757f471ada953274e
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qga/qapi-schema.json
Log Message:
-----------
qga/qapi-schema: Fix a misspelled reference
Code returns a list of GuestNetworkInterface, documentation claims
GuestNetworkInfo, which doesn't exist. Fix the documentation.
Fixes: 3424fc9f16a1 (qemu-ga: add guest-network-get-interfaces command)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230425064223.820979-3-armbru@redhat.com>
Commit: d93ed1bdc989c81aa38746e569f5e2dc4888cf83
https://github.com/qemu/qemu/commit/d93ed1bdc989c81aa38746e569f5e2dc4888cf83
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qapi/machine-target.json
M qapi/machine.json
M qapi/migration.json
Log Message:
-----------
qapi: Fix misspelled references
query-cpu-definitions returns a list of CpuDefinitionInfo, but
documentation claims CpuDefInfo, which doesn't exist.
query-migrate-capabilities returns a list of
MigrationCapabilityStatus, but documentation claims
MigrationCapabilitiesStatus, which doesn't exist.
balloon and query-balloon can fail with KVMMissingCap, but
documentation claims KvmMissingCap, which doesn't exist.
Fix the documentation.
Fixes: e4e31c6324af (qapi: add query-cpu-definitions command (v2))
Fixes: bbf6da32b5bd (Add migration capabilities)
Fixes: d72f326431e2 (qapi: Convert balloon)
Fixes: 96637bcdf9e0 (qapi: Convert query-balloon)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20230425064223.820979-4-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: 71568864c43d2e03df79ebeb360a876d1b04352c
https://github.com/qemu/qemu/commit/71568864c43d2e03df79ebeb360a876d1b04352c
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qapi/block-core.json
M qapi/misc.json
M qapi/ui.json
Log Message:
-----------
qapi: Fix up references to long gone error classes
Commit de253f14912e88f4 (qmp: switch to the new error format on the
wire) removed most error classes. Several later commits mistakenly
mentioned them in documentation. Replace them by the actual error
class there.
Fixes: 44e3e053af56 (qmp: add interface blockdev-snapshot-delete-internal-sync)
Fixes: f323bc9e8b3b (qmp: add interface blockdev-snapshot-internal-sync)
Fixes: ba1c048a8f9c (qapi: Introduce add-fd, remove-fd, query-fdsets)
Fixes: ed61fc10e8c8 (QAPI: add command for live block commit, 'block-commit')
Fixes: e4c8f004c55d (qapi: convert sendkey)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230425064223.820979-5-armbru@redhat.com>
Commit: 9a5af2f9dc8f231f6ca20f61b95970380f1024e2
https://github.com/qemu/qemu/commit/9a5af2f9dc8f231f6ca20f61b95970380f1024e2
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qapi/block-core.json
Log Message:
-----------
qapi/block-core: Clean up after removal of dirty bitmap @status
Commit 81cbfd50886 (block: remove dirty bitmaps 'status' field)
removed deprecated BlockDirtyInfo member @status. It neglected to
remove references to its enumeration values from the documentation of
its replacements. Do that now.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-Id: <20230425064223.820979-6-armbru@redhat.com>
Commit: f1a787b5f4b60524580ed9d1527568590d73789b
https://github.com/qemu/qemu/commit/f1a787b5f4b60524580ed9d1527568590d73789b
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M docs/devel/qapi-code-gen.rst
M docs/interop/firmware.json
M qapi/qom.json
M qapi/ui.json
Log Message:
-----------
qapi: @foo should be used to reference, not ``foo``
Documentation suggests @foo is merely shorthand for ``foo``. It's
not, it carries additional meaning: it's a reference to a QAPI schema
name.
Reword the documentation to spell that out.
Fix up the few ``foo`` that should be @foo.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230425064223.820979-7-armbru@redhat.com>
Commit: 37fa48a4cbd68760235293ebf95980fb87239b42
https://github.com/qemu/qemu/commit/37fa48a4cbd68760235293ebf95980fb87239b42
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qapi/block-core.json
M qapi/block.json
M qapi/char.json
M qapi/machine.json
M qapi/migration.json
M qapi/misc.json
M qapi/net.json
M qapi/qdev.json
M qapi/qom.json
M qapi/replay.json
M qapi/run-state.json
M qapi/ui.json
Log Message:
-----------
qapi: Tidy up examples
A few examples neglect to prefix QMP input with '->'. Fix that.
Two examples have extra space after '<-'. Delete it.
A few examples neglect to show output. Provide some. The example
output for query-vcpu-dirty-limit could use further improvement. Add
a TODO comment.
Use "Examples:" instead of "Example:" where multiple examples are
given.
One example section numbers its two examples. Not done elsewhere;
drop.
Another example section separates them with "or". Likewise.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230425064223.820979-8-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: 5042854db877e07dd0806348dc3dbd4cd999ef80
https://github.com/qemu/qemu/commit/5042854db877e07dd0806348dc3dbd4cd999ef80
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qapi/qapi-schema.json
Log Message:
-----------
qapi: Delete largely misleading "Stability Considerations"
Documentation section "Stability Considerations" dates back to the
early days of QMP (commit 82a56f0d83d (Monitor: Introduce the
qmp-commands.hx file)). It became largely misleading years ago.
Delete it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230425064223.820979-9-armbru@redhat.com>
Commit: c11010289851ab1943442ff87cf19b7686fb94b3
https://github.com/qemu/qemu/commit/c11010289851ab1943442ff87cf19b7686fb94b3
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M docs/devel/qapi-code-gen.rst
M qapi/block-export.json
M qapi/stats.json
M qapi/trace.json
M qapi/yank.json
Log Message:
-----------
qapi: Fix bullet list markup in documentation
Peter Maydell's commit 100cc4fe0f08 explains:
rST insists on a blank line before and after a bulleted list [...]
Add some extra blank lines in the doc comments so they're
acceptable rST input.
It missed one in qapi/trace.json.
Paolo Bonzini later added another instance in qapi/stats.json,
providing further, if unintended, evidence for his quip that rST is
the Perl of ASCII-based markups.
Both are parsed as ordinary paragraph, resulting in garbled output.
John Snow missed the need for a blank line when converting
docs/devel/qapi-code-gen.txt to rST.
Add the blank lines we need to get the bullet lists recognized as
such.
Kevin Wolf and Lukas Straub added two more, but indented. Sphinx
recognizes them as (indented) bullet lists. The indentation looks
slightly off.
Insert a blank line and delete the extra indentation.
Fixes: 100cc4fe0f0827f8da1a5c05f9c65e2aaa40e03d (qapi: Add blank lines before
bulleted lists)
Fixes: 467ef823d83e (qmp: add filtering of statistics by target vCPU)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230425064223.820979-10-armbru@redhat.com>
[Fix of docs/devel/qapi-code-gen.rst squashed, commit message adjusted]
Commit: f2de3b926cf37e0c878a52f01a29e5d708bccedb
https://github.com/qemu/qemu/commit/f2de3b926cf37e0c878a52f01a29e5d708bccedb
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qapi/block-core.json
M qapi/control.json
M qapi/machine.json
M qapi/net.json
Log Message:
-----------
qapi: Fix unintended definition lists in documentation
rST parses something like
first line
second line
as a definition list item, where "first line" is the term being
defined by "second line".
This bites us in a couple of places. Here's one:
# @bps_max: total throughput limit during bursts,
# in bytes (Since 1.7)
scripts/qapi/parser.py parses this into an "argument section" with
name "bps_max" and text
total throughput limit during bursts,
in bytes (Since 1.7)
docs/sphinx/qapidoc.py duly passes the text to the rST parser, which
parses it as another definition list. Comes out as nested
definitions: term "bps_max: int (optional)" defined as term "total
throughput limit during bursts," defined as "in bytes (Since 1.7)".
rST truly is the Perl of ASCII-based markups.
Fix by deleting the extra indentation.
Fixes: 26ec4e53f2bf (qapi: Fix indent level on doc comments in json files)
Fixes: c0ac533b6f97 (qapi: Stop using whitespace for alignment in comments)
Fixes: 81ad2964e938 (net/vmnet: add vmnet backends to qapi/net)
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20230425064223.820979-11-armbru@redhat.com>
Commit: c0af9e1fc7da6a352678d05fdea7a85b80ab2d80
https://github.com/qemu/qemu/commit/c0af9e1fc7da6a352678d05fdea7a85b80ab2d80
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qga/qapi-schema.json
Log Message:
-----------
qga/qapi-schema: Fix member documentation markup
GuestDiskStatsInfo's member documentation is parsed as ordinary text
due to missing colons. The generated documentation shows these
members as "Not documented".
The fix is obvious: add the missing colons.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230425064223.820979-12-armbru@redhat.com>
Commit: 91577c47257a4459e7fa679f719c20b5093d4e4e
https://github.com/qemu/qemu/commit/91577c47257a4459e7fa679f719c20b5093d4e4e
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qapi/block-core.json
M qapi/job.json
M qapi/rdma.json
Log Message:
-----------
qapi: Fix argument documentation markup
Member / argument documentation of BlockdevAmendOptionsQcow2,
job-resume, and RDMA_GID_STATUS_CHANGED is parsed as ordinary text due
to missing colon or space before the colon. The generated
documentation shows these members / arguments as "Not documented".
The fix is obvious: add missing colons, delete extra spaces.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230425064223.820979-13-armbru@redhat.com>
Commit: 86bf13aea39e32adb8f068a4d14e2ad16edb725c
https://github.com/qemu/qemu/commit/86bf13aea39e32adb8f068a4d14e2ad16edb725c
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qapi/machine.json
M qapi/net.json
M qapi/run-state.json
Log Message:
-----------
qapi: Replace ad hoc "since" documentation by member documentation
MemoryDeviceInfoKind, NetClientDriver, and GuestPanicAction mention
some members only in ad hoc since documentation. The generated
documentation shows these members as "Not documented".
Replace by formal member documentation.
Add actual documentation text for the GuestPanicAction members, to
match existing member documentation there. For the others, merely
move existing "since" information.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230425064223.820979-14-armbru@redhat.com>
Commit: 7c3def93b138a72aac2b64c4cca321677bb97392
https://github.com/qemu/qemu/commit/7c3def93b138a72aac2b64c4cca321677bb97392
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qapi/machine.json
M qapi/migration.json
Log Message:
-----------
qapi: Fix misspelled section tags in doc comments
Section tags are case sensitive and end with a colon. Screwing up
either gets them interpreted as ordinary paragraph. Fix a few.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230425064223.820979-15-armbru@redhat.com>
Commit: 94546de1a811cabc0c878ed474ef51b7ec102b84
https://github.com/qemu/qemu/commit/94546de1a811cabc0c878ed474ef51b7ec102b84
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qapi/block-core.json
M qapi/stats.json
M qapi/tpm.json
M qapi/ui.json
Log Message:
-----------
qapi: Format since information the conventional way: (since X.Y)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230425064223.820979-16-armbru@redhat.com>
Commit: 4622c70689f0bc39bd31922cee2a569f2bc3f390
https://github.com/qemu/qemu/commit/4622c70689f0bc39bd31922cee2a569f2bc3f390
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qapi/cryptodev.json
M qapi/job.json
M qapi/qapi-schema.json
M storage-daemon/qapi/qapi-schema.json
Log Message:
-----------
qapi storage-daemon/qapi: Fix documentation section structure
In the QEMU QMP Reference Manual, subsection "Block core (VM
unrelated)" is empty. Its contents is at the end of subsection
"Background jobs" instead. That's because qapi/job.json is included
first from qapi/block-core.json, which makes qapi/job.json's
documentation go between qapi/block-core.json's subsection heading and
contents.
In the QEMU Storage Daemon QMP Reference Manual, section "Block
Devices" contains nothing but an empty subsection "Block core (VM
unrelated)". The latter's contents is at the end section "Socket data
types", along with subsection "Block device exports". Subsection
"Background jobs" is at the end of section "Cryptography". All this
is because storage-daemon/qapi/qapi-schema.json includes modules in a
confused order.
Fix both as follows.
Turn subsection "Background jobs" into a section.
Move it before section "Block devices" in the QEMU QMP Reference
Manual, by including qapi/jobs.json right before qapi/block.json.
Reorder include directives in storage-daemon/qapi/qapi-schema.json to
match the order in qapi/qapi-schema.json, so that the QEMU Storage
Daemon QMP Reference Manual's section structure the QEMU QMP Reference
Manual's.
In the QEMU QMP Reference Manual, qapi/cryptodev.json's documentation
is at the end of section "Virtio devices". That's because it lacks a
section heading, and therefore gets squashed into whatever section
happens to precede it.
Add section heading so it's in section "Cryptography devices".
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: zhenwei pi <pizhenwei@bytedance.com>
Message-Id: <20230425064223.820979-17-armbru@redhat.com>
Commit: e2e9e567f0e23971cac35ba1dee7edb51085b5f7
https://github.com/qemu/qemu/commit/e2e9e567f0e23971cac35ba1dee7edb51085b5f7
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M docs/devel/qapi-code-gen.rst
Log Message:
-----------
docs/devel/qapi-code-gen: Describe some doc markup pitfalls
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230427095346.1238913-1-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Commit: 290afd3460ffa3eb8dfbb55b7410dd9237f8c38c
https://github.com/qemu/qemu/commit/290afd3460ffa3eb8dfbb55b7410dd9237f8c38c
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M include/block/block-common.h
Log Message:
-----------
block/block-common: add zoned device structs
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230427172019.3345-2-faithilikerun@gmail.com
Message-id: 20230324090605.28361-2-faithilikerun@gmail.com
[Adjust commit message prefix as suggested by Philippe Mathieu-Daudé
<philmd@linaro.org>.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: 4caf116ac3a16923b60f9d4481c9b54e2973055d
https://github.com/qemu/qemu/commit/4caf116ac3a16923b60f9d4481c9b54e2973055d
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M block/file-posix.c
M include/block/block_int-common.h
Log Message:
-----------
block/file-posix: introduce helper functions for sysfs attributes
Use get_sysfs_str_val() to get the string value of device
zoned model. Then get_sysfs_zoned_model() can convert it to
BlockZoneModel type of QEMU.
Use get_sysfs_long_val() to get the long value of zoned device
information.
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230427172019.3345-3-faithilikerun@gmail.com
Message-id: 20230324090605.28361-3-faithilikerun@gmail.com
[Adjust commit message prefix as suggested by Philippe Mathieu-Daudé
<philmd@linaro.org>.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: e973b9e81f215c4449d1a0f3897579e70eb443a8
https://github.com/qemu/qemu/commit/e973b9e81f215c4449d1a0f3897579e70eb443a8
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M block/block-backend.c
M block/file-posix.c
M block/io.c
M include/block/block-io.h
M include/block/block_int-common.h
M include/block/raw-aio.h
M include/sysemu/block-backend-io.h
M meson.build
M qemu-io-cmds.c
Log Message:
-----------
block/block-backend: add block layer APIs resembling Linux ZonedBlockDevice
ioctls
Add zoned device option to host_device BlockDriver. It will be presented only
for zoned host block devices. By adding zone management operations to the
host_block_device BlockDriver, users can use the new block layer APIs
including Report Zone and four zone management operations
(open, close, finish, reset, reset_all).
Qemu-io uses the new APIs to perform zoned storage commands of the device:
zone_report(zrp), zone_open(zo), zone_close(zc), zone_reset(zrs),
zone_finish(zf).
For example, to test zone_report, use following command:
$ ./build/qemu-io --image-opts -n driver=host_device, filename=/dev/nullb0
-c "zrp offset nr_zones"
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230427172019.3345-4-faithilikerun@gmail.com
Message-id: 20230324090605.28361-4-faithilikerun@gmail.com
[Adjust commit message prefix as suggested by Philippe Mathieu-Daudé
<philmd@linaro.org> and remove spurious ret = -errno in
raw_co_zone_mgmt().
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: 721f580b49befe56b4f33b3a14f3f827eaf92ae2
https://github.com/qemu/qemu/commit/721f580b49befe56b4f33b3a14f3f827eaf92ae2
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M block/raw-format.c
Log Message:
-----------
block/raw-format: add zone operations to pass through requests
raw-format driver usually sits on top of file-posix driver. It needs to
pass through requests of zone commands.
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230427172019.3345-5-faithilikerun@gmail.com
Message-id: 20230324090605.28361-5-faithilikerun@gmail.com
[Adjust commit message prefix as suggested by Philippe Mathieu-Daudé
<philmd@linaro.org>.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: 46aa2a38d0ab4ed0c64b9b8edca6fda3d9900dc1
https://github.com/qemu/qemu/commit/46aa2a38d0ab4ed0c64b9b8edca6fda3d9900dc1
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M block.c
M block/file-posix.c
M block/raw-format.c
M include/block/block_int-common.h
Log Message:
-----------
block: add zoned BlockDriver check to block layer
Putting zoned/non-zoned BlockDrivers on top of each other is not
allowed.
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230427172019.3345-6-faithilikerun@gmail.com
Message-id: 20230324090605.28361-6-faithilikerun@gmail.com
[Adjust commit message prefix as suggested by Philippe Mathieu-Daudé
<philmd@linaro.org> and clarify that the check is about zoned
BlockDrivers.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: b8c274b7079af59c7b50edf401772213308e936f
https://github.com/qemu/qemu/commit/b8c274b7079af59c7b50edf401772213308e936f
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
A tests/qemu-iotests/tests/zoned
A tests/qemu-iotests/tests/zoned.out
Log Message:
-----------
iotests: test new zone operations
The new block layer APIs of zoned block devices can be tested by:
$ tests/qemu-iotests/check zoned
Run each zone operation on a newly created null_blk device
and see whether it outputs the same zone information.
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230427172019.3345-7-faithilikerun@gmail.com
Message-id: 20230324090605.28361-7-faithilikerun@gmail.com
[Adjust commit message prefix as suggested by Philippe Mathieu-Daudé
<philmd@linaro.org>.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: 8d6164ee93050ccc7fcb000835fea1b8f1b569ea
https://github.com/qemu/qemu/commit/8d6164ee93050ccc7fcb000835fea1b8f1b569ea
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M block/file-posix.c
M block/trace-events
Log Message:
-----------
block: add some trace events for new block layer APIs
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230427172019.3345-8-faithilikerun@gmail.com
Message-id: 20230324090605.28361-8-faithilikerun@gmail.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: 2ee9aa989d57cfe43cad50f875dea48215eacb31
https://github.com/qemu/qemu/commit/2ee9aa989d57cfe43cad50f875dea48215eacb31
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M docs/devel/index-api.rst
A docs/devel/zoned-storage.rst
M docs/system/qemu-block-drivers.rst.inc
Log Message:
-----------
docs/zoned-storage: add zoned device documentation
Add the documentation about the zoned device support to virtio-blk
emulation.
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230427172019.3345-9-faithilikerun@gmail.com
Message-id: 20230324090605.28361-9-faithilikerun@gmail.com
[Add index-api.rst to fix "zoned-storage.rst:document isn't included in
any toctree" error and fix pre-formatted command-line indentation.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: da7318ddedf924d49f134e38db9b005d8f2dc589
https://github.com/qemu/qemu/commit/da7318ddedf924d49f134e38db9b005d8f2dc589
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M block/file-posix.c
M include/block/block-common.h
M include/block/block_int-common.h
Log Message:
-----------
file-posix: add tracking of the zone write pointers
Since Linux doesn't have a user API to issue zone append operations to
zoned devices from user space, the file-posix driver is modified to add
zone append emulation using regular writes. To do this, the file-posix
driver tracks the wp location of all zones of the device. It uses an
array of uint64_t. The most significant bit of each wp location indicates
if the zone type is conventional zones.
The zones wp can be changed due to the following operations issued:
- zone reset: change the wp to the start offset of that zone
- zone finish: change to the end location of that zone
- write to a zone
- zone append
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Message-id: 20230427172339.3709-2-faithilikerun@gmail.com
[Fix errno propagation from handle_aiocb_zone_mgmt()
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: 881c8ec02ed6e4547990c34b4579b15e5a836008
https://github.com/qemu/qemu/commit/881c8ec02ed6e4547990c34b4579b15e5a836008
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M block/block-backend.c
M block/file-posix.c
M block/io.c
M block/io_uring.c
M block/linux-aio.c
M block/raw-format.c
M include/block/block-io.h
M include/block/block_int-common.h
M include/block/raw-aio.h
M include/sysemu/block-backend-io.h
Log Message:
-----------
block: introduce zone append write for zoned devices
A zone append command is a write operation that specifies the first
logical block of a zone as the write position. When writing to a zoned
block device using zone append, the byte offset of the call may point at
any position within the zone to which the data is being appended. Upon
completion the device will respond with the position where the data has
been written in the zone.
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230427172339.3709-3-faithilikerun@gmail.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: d7e90a6607626a5e1084c2e263d2bb0ee7453d16
https://github.com/qemu/qemu/commit/d7e90a6607626a5e1084c2e263d2bb0ee7453d16
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M qemu-io-cmds.c
M tests/qemu-iotests/tests/zoned
M tests/qemu-iotests/tests/zoned.out
Log Message:
-----------
qemu-iotests: test zone append operation
The patch tests zone append writes by reporting the zone wp after
the completion of the call. "zap -p" option can print the sector
offset value after completion, which should be the start sector
where the append write begins.
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230427172339.3709-4-faithilikerun@gmail.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: 9f99390a3510201d8e8af2598371b8b1ad8685ad
https://github.com/qemu/qemu/commit/9f99390a3510201d8e8af2598371b8b1ad8685ad
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M block/file-posix.c
M block/trace-events
Log Message:
-----------
block: add some trace events for zone append
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230427172339.3709-5-faithilikerun@gmail.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: e730704a73f70870725e73270083b144e239d0c4
https://github.com/qemu/qemu/commit/e730704a73f70870725e73270083b144e239d0c4
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M include/standard-headers/drm/drm_fourcc.h
M include/standard-headers/linux/ethtool.h
M include/standard-headers/linux/fuse.h
M include/standard-headers/linux/pci_regs.h
M include/standard-headers/linux/vhost_types.h
M include/standard-headers/linux/virtio_blk.h
M linux-headers/asm-arm64/kvm.h
M linux-headers/asm-x86/kvm.h
M linux-headers/linux/kvm.h
M linux-headers/linux/vfio.h
M linux-headers/linux/vhost.h
Log Message:
-----------
include: update virtio_blk headers to v6.3-rc1
Use scripts/update-linux-headers.sh to update headers to 6.3-rc1.
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
[Reran scripts/update-linux-headers.sh on Linux v6.3. The only change
was the use of __virtioXX types instead of uintXX_t.
--Stefan]
Message-Id: <20230407082528.18841-2-faithilikerun@gmail.com>
Commit: bf3b8accc799fe1d90747199c86fb7285bef0ece
https://github.com/qemu/qemu/commit/bf3b8accc799fe1d90747199c86fb7285bef0ece
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M hw/block/virtio-blk-common.c
M hw/block/virtio-blk.c
M hw/virtio/virtio-qmp.c
Log Message:
-----------
virtio-blk: add zoned storage emulation for zoned devices
This patch extends virtio-blk emulation to handle zoned device commands
by calling the new block layer APIs to perform zoned device I/O on
behalf of the guest. It supports Report Zone, four zone oparations (open,
close, finish, reset), and Append Zone.
The VIRTIO_BLK_F_ZONED feature bit will only be set if the host does
support zoned block devices. Regular block devices(conventional zones)
will not be set.
The guest os can use blktests, fio to test those commands on zoned devices.
Furthermore, using zonefs to test zone append write is also supported.
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20230407082528.18841-3-faithilikerun@gmail.com>
Commit: 123225a484b6e680a820556e96c3751f750e2baf
https://github.com/qemu/qemu/commit/123225a484b6e680a820556e96c3751f750e2baf
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M block/qapi-sysemu.c
M block/qapi.c
M hw/block/virtio-blk.c
M include/block/accounting.h
M qapi/block-core.json
M qapi/block.json
Log Message:
-----------
block: add accounting for zone append operation
Taking account of the new zone append write operation for zoned devices,
BLOCK_ACCT_ZONE_APPEND enum is introduced as other I/O request type (read,
write, flush).
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20230407082528.18841-4-faithilikerun@gmail.com>
Commit: 820e26f2a7c52cfec2ad6c0c288e3f40a5c4059b
https://github.com/qemu/qemu/commit/820e26f2a7c52cfec2ad6c0c288e3f40a5c4059b
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M hw/block/trace-events
M hw/block/virtio-blk.c
Log Message:
-----------
virtio-blk: add some trace events for zoned emulation
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20230407082528.18841-5-faithilikerun@gmail.com>
Commit: d3c760be786571d83d5cea01953e543df4d76f51
https://github.com/qemu/qemu/commit/d3c760be786571d83d5cea01953e543df4d76f51
Author: Sam Li <faithilikerun@gmail.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M docs/devel/zoned-storage.rst
Log Message:
-----------
docs/zoned-storage:add zoned emulation use case
Add the documentation about the example of using virtio-blk driver
to pass the zoned block devices through to the guest.
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
[Fix rST syntax
--Stefan]
Message-Id: <20230407082528.18841-6-faithilikerun@gmail.com>
Commit: 291b612833789563f711285287e02c097643f1c0
https://github.com/qemu/qemu/commit/291b612833789563f711285287e02c097643f1c0
Author: Juan Quintela <quintela@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/multifd.c
Log Message:
-----------
multifd: We already account for this packet on the multifd thread
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Commit: 3fb55f450449dd2f97276c2b788bedfaab7d2138
https://github.com/qemu/qemu/commit/3fb55f450449dd2f97276c2b788bedfaab7d2138
Author: Juan Quintela <quintela@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/meson.build
A migration/migration-stats.c
A migration/migration-stats.h
M migration/migration.c
M migration/multifd.c
M migration/ram.c
M migration/ram.h
M migration/savevm.c
Log Message:
-----------
migration: Move ram_stats to its own file migration-stats.[ch]
There is already include/qemu/stats.h, so stats.h was a bad idea.
We want this file to not depend on anything else, we will move all the
migration counters/stats to this struct.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Commit: fc6fcdd71deaf72e0759c5fe363d88e28445f2d7
https://github.com/qemu/qemu/commit/fc6fcdd71deaf72e0759c5fe363d88e28445f2d7
Author: Juan Quintela <quintela@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/migration-stats.c
M migration/migration-stats.h
M migration/migration.c
M migration/multifd.c
M migration/ram.c
M migration/savevm.c
Log Message:
-----------
migration: Rename ram_counters to mig_stats
migration_stats is just too long, and it is going to have more than
ram counters in the near future.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Commit: bb6a3af32e0fb67f1c7a2cc05979ba58d3f856f8
https://github.com/qemu/qemu/commit/bb6a3af32e0fb67f1c7a2cc05979ba58d3f856f8
Author: Juan Quintela <quintela@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/migration-stats.c
M migration/migration-stats.h
Log Message:
-----------
migration: Rename RAMStats to MigrationAtomicStats
It is lousely based on MigrationStats, but that name is taken, so this
is the best one that I came with.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
---
If you have any good suggestion for the name, I am all ears.
Commit: 2585c1d11c300e5e0a4c0829963f09f6a8f71380
https://github.com/qemu/qemu/commit/2585c1d11c300e5e0a4c0829963f09f6a8f71380
Author: Juan Quintela <quintela@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/ram.c
M migration/ram.h
M migration/rdma.c
Log Message:
-----------
migration/rdma: Split the zero page case from acct_update_position
Now that we have atomic counters, we can do it on the place that we
need it, no need to do it inside ram.c.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Commit: 02c1fa1693f9d4f1e312c3081a7a090f2f711422
https://github.com/qemu/qemu/commit/02c1fa1693f9d4f1e312c3081a7a090f2f711422
Author: Juan Quintela <quintela@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/ram.c
M migration/ram.h
M migration/rdma.c
Log Message:
-----------
migration/rdma: Unfold last user of acct_update_position()
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Commit: 32bcb96551ac23e7f9cf21d868d113ea7a0a9670
https://github.com/qemu/qemu/commit/32bcb96551ac23e7f9cf21d868d113ea7a0a9670
Author: Juan Quintela <quintela@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/tls.c
Log Message:
-----------
migration: Drop unused parameter for migration_tls_get_creds()
It is not needed since we moved the accessor for tls properties to
options.c.
Suggested-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Commit: c20062e46ef9e350c10b70317fb5ff31caec9a95
https://github.com/qemu/qemu/commit/c20062e46ef9e350c10b70317fb5ff31caec9a95
Author: Juan Quintela <quintela@redhat.com>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/multifd.c
M migration/postcopy-ram.c
M migration/tls.c
M migration/tls.h
Log Message:
-----------
migration: Drop unused parameter for migration_tls_client_create()
It is not needed since we moved the accessor for tls properties to
options.c.
Suggested-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Commit: 5d3b09409965beb372df2f9d723d8ccf5bde5fec
https://github.com/qemu/qemu/commit/5d3b09409965beb372df2f9d723d8ccf5bde5fec
Author: Lukas Straub <lukasstraub2@web.de>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M tests/qtest/migration-test.c
Log Message:
-----------
qtest/migration-test.c: Add tests with compress enabled
There has never been tests for migration with compress enabled.
Add suitable tests, testing with compress-wait-thread = false
too.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Commit: 94c3c8df5e1e6cbc97cd53c91b1d35abe829db8a
https://github.com/qemu/qemu/commit/94c3c8df5e1e6cbc97cd53c91b1d35abe829db8a
Author: Lukas Straub <lukasstraub2@web.de>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M tests/qtest/migration-test.c
Log Message:
-----------
qtest/migration-test.c: Add postcopy tests with compress enabled
Add postcopy tests with compress enabled to ensure nothing breaks
with the refactoring in the next commits.
preempt+compress is blocked, so no test needed for that case.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Commit: 280304a3164bbd1e032e38e83c662047f253ecc4
https://github.com/qemu/qemu/commit/280304a3164bbd1e032e38e83c662047f253ecc4
Author: Lukas Straub <lukasstraub2@web.de>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/ram.c
Log Message:
-----------
ram.c: Let the compress threads return a CompressResult enum
This will be used in the next commits to move save_page_header()
out of compress code.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Commit: 7ab0eb0d01090c9e1576f26f3cb307a84758a71e
https://github.com/qemu/qemu/commit/7ab0eb0d01090c9e1576f26f3cb307a84758a71e
Author: Lukas Straub <lukasstraub2@web.de>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/ram.c
Log Message:
-----------
ram.c: Dont change param->block in the compress thread
Instead introduce a extra parameter to trigger the compress thread.
Now, when the compress thread is done, we know what RAMBlock and
offset it did compress.
This will be used in the next commits to move save_page_header()
out of compress code.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Commit: 7fe37c4210cb59e4ea4d7da377fe83760ce4c09b
https://github.com/qemu/qemu/commit/7fe37c4210cb59e4ea4d7da377fe83760ce4c09b
Author: Lukas Straub <lukasstraub2@web.de>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/ram.c
Log Message:
-----------
ram.c: Reset result after sending queued data
And take the param->mutex lock for the whole section to ensure
thread-safety.
Now, it is explicitly clear if there is no queued data to send.
Before, this was handled by param->file stream being empty and thus
qemu_put_qemu_file() not sending anything.
This will be used in the next commits to move save_page_header()
out of compress code.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Commit: b4be6040c7deff7b55d7f613ec5c83757deebee7
https://github.com/qemu/qemu/commit/b4be6040c7deff7b55d7f613ec5c83757deebee7
Author: Lukas Straub <lukasstraub2@web.de>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/ram.c
Log Message:
-----------
ram.c: Do not call save_page_header() from compress threads
save_page_header() accesses several global variables, so calling it
from multiple threads is pretty ugly.
Instead, call save_page_header() before writing out the compressed
data from the compress buffer to the migration stream.
This also makes the core compress code more independend from ram.c.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Commit: 85f44f9c316c381120b21fdf9518e5d7b173cafd
https://github.com/qemu/qemu/commit/85f44f9c316c381120b21fdf9518e5d7b173cafd
Author: Lukas Straub <lukasstraub2@web.de>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/ram.c
Log Message:
-----------
ram.c: Call update_compress_thread_counts from compress_send_queued_data
This makes the core compress code more independend from ram.c.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Commit: 9b1efb40129d0583c9c73fc15b2c899ac817f508
https://github.com/qemu/qemu/commit/9b1efb40129d0583c9c73fc15b2c899ac817f508
Author: Lukas Straub <lukasstraub2@web.de>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/ram.c
Log Message:
-----------
ram.c: Remove last ram.c dependency from the core compress code
Make compression interfaces take send_queued_data() as an argument.
Remove save_page_use_compression() from flush_compressed_data().
This removes the last ram.c dependency from the core compress code.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Commit: 9e9bf8c21b68a881ebc47882b659905d9638a636
https://github.com/qemu/qemu/commit/9e9bf8c21b68a881ebc47882b659905d9638a636
Author: Lukas Straub <lukasstraub2@web.de>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/meson.build
A migration/ram-compress.c
A migration/ram-compress.h
M migration/ram.c
Log Message:
-----------
ram.c: Move core compression code into its own file
No functional changes intended.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Commit: 0c5190409d2e52b0a69007f7cfc3398cd0d352b9
https://github.com/qemu/qemu/commit/0c5190409d2e52b0a69007f7cfc3398cd0d352b9
Author: Lukas Straub <lukasstraub2@web.de>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/ram-compress.c
M migration/ram-compress.h
M migration/ram.c
Log Message:
-----------
ram.c: Move core decompression code into its own file
No functional changes intended.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Commit: 973704dded4b0730bfd8df4217f1bfa781f7a07e
https://github.com/qemu/qemu/commit/973704dded4b0730bfd8df4217f1bfa781f7a07e
Author: Lukas Straub <lukasstraub2@web.de>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/qemu-file.c
M migration/qemu-file.h
M migration/ram-compress.c
M migration/ram.c
Log Message:
-----------
ram compress: Assert that the file buffer matches the result
Before this series, "nothing to send" was handled by the file buffer
being empty. Now it is tracked via param->result.
Assert that the file buffer state matches the result.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Commit: 5766ce817eac5b20c6fd65a145c818f954c0d935
https://github.com/qemu/qemu/commit/5766ce817eac5b20c6fd65a145c818f954c0d935
Author: Lukas Straub <lukasstraub2@web.de>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/meson.build
M migration/ram-compress.c
Log Message:
-----------
ram-compress.c: Make target independent
Make ram-compress.c target independent.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Commit: 05ecac612ec6a4bdb358e68554b4406ac2c8e25a
https://github.com/qemu/qemu/commit/05ecac612ec6a4bdb358e68554b4406ac2c8e25a
Author: Lukas Straub <lukasstraub2@web.de>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/migration.c
M migration/ram.c
Log Message:
-----------
migration: Initialize and cleanup decompression in migration.c
This fixes compress with colo.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Commit: 05b1de846ca58782e63bfa437791b1a5dcf7ffb4
https://github.com/qemu/qemu/commit/05b1de846ca58782e63bfa437791b1a5dcf7ffb4
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M docs/devel/qapi-code-gen.rst
M docs/interop/firmware.json
M qapi/block-core.json
M qapi/block-export.json
M qapi/block.json
M qapi/char.json
M qapi/control.json
M qapi/cryptodev.json
M qapi/job.json
M qapi/machine-target.json
M qapi/machine.json
M qapi/migration.json
M qapi/misc.json
M qapi/net.json
M qapi/qapi-schema.json
M qapi/qdev.json
M qapi/qom.json
M qapi/rdma.json
M qapi/replay.json
M qapi/run-state.json
M qapi/stats.json
M qapi/tpm.json
M qapi/trace.json
M qapi/ui.json
M qapi/yank.json
M qga/qapi-schema.json
M storage-daemon/qapi/qapi-schema.json
Log Message:
-----------
Merge tag 'pull-qapi-2023-04-28' of https://repo.or.cz/qemu/armbru into
staging
QAPI patches patches for 2023-04-28
# -----BEGIN PGP SIGNATURE-----
#
# iQJGBAABCAAwFiEENUvIs9frKmtoZ05fOHC0AOuRhlMFAmRLlpsSHGFybWJydUBy
# ZWRoYXQuY29tAAoJEDhwtADrkYZTTjwP/iezbnBFv55HxaRFisEpBom7skXakV1r
# 0KTyYNo0BatS01yVlX7IOh37ZVmoBHrpbs0SLb2V5/uVALQBvmlnhUCCQ+BJwhJF
# JON6yjZRKUikVKn8CGj0ql9KDF6bC/T1ByFEotGc7SBMCx+FWuGXnmVzwOKOK2O3
# XAHG1P04wlxuyHMt3V7qqbc5IyzZIEHLbEitDhQM/6quQmwx4NzFR+JwvzUXCok1
# F7cEt0cKbE3JZHSXWIVTOuseeZR8vnk3giKBgFOetqhVorGusiTPMQwpDPvvgKGn
# fkg2l5SZQz9hSDfuzCKpJSQDqO8ji+62fHci9+PPpG10raoMiwCiuhP9yYECYekM
# 7BcAY7fItrUB+x+vjm8JRY15JxOT8ouHLfyknNLOwow8QwtsiNn35VlRJU7O+k+D
# gk9qvwl1RoLUSXzOo6Ye1NvzF8oMZ8o8f0vmYC+W3sdg89U9QnRrpCaX8YCytLnd
# rEXJiL26mg54yXrWShIzLvC33//sz7AvH6IjwrRt0ZQu7ANRJsNmYY9S1THAJBKW
# b9hY3Aosw8Advt0RUFkYr/PndZp/gxDpbtOCIkKZkti6XRkY89ExPk6zVmeo8miw
# DeEo1kRtzKYDC7ZU0yp73MZDSmUt17L1AfdgS0QuCQCfPHsa8LwtZoQmRIihT/Bo
# GZTLIZPiVC79
# =mkwX
# -----END PGP SIGNATURE-----
# gpg: Signature made Fri 28 Apr 2023 10:49:15 AM BST
# gpg: using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg: issuer "armbru@redhat.com"
# gpg: Good signature from "Markus Armbruster <armbru@redhat.com>" [undefined]
# gpg: aka "Markus Armbruster <armbru@pond.sub.org>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg: There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867 4E5F 3870 B400 EB91 8653
* tag 'pull-qapi-2023-04-28' of https://repo.or.cz/qemu/armbru:
docs/devel/qapi-code-gen: Describe some doc markup pitfalls
qapi storage-daemon/qapi: Fix documentation section structure
qapi: Format since information the conventional way: (since X.Y)
qapi: Fix misspelled section tags in doc comments
qapi: Replace ad hoc "since" documentation by member documentation
qapi: Fix argument documentation markup
qga/qapi-schema: Fix member documentation markup
qapi: Fix unintended definition lists in documentation
qapi: Fix bullet list markup in documentation
qapi: Delete largely misleading "Stability Considerations"
qapi: Tidy up examples
qapi: @foo should be used to reference, not ``foo``
qapi/block-core: Clean up after removal of dirty bitmap @status
qapi: Fix up references to long gone error classes
qapi: Fix misspelled references
qga/qapi-schema: Fix a misspelled reference
qga/qapi-schema: Tidy up documentation of guest-fsfreeze-status
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: b39dcf3ccc66f5c2f7fad43350ba727c0b4392eb
https://github.com/qemu/qemu/commit/b39dcf3ccc66f5c2f7fad43350ba727c0b4392eb
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M block.c
M block/block-backend.c
M block/file-posix.c
M block/io.c
M block/io_uring.c
M block/linux-aio.c
M block/qapi-sysemu.c
M block/qapi.c
M block/raw-format.c
M block/trace-events
M docs/devel/index-api.rst
A docs/devel/zoned-storage.rst
M docs/system/qemu-block-drivers.rst.inc
M hw/block/trace-events
M hw/block/virtio-blk-common.c
M hw/block/virtio-blk.c
M hw/virtio/virtio-qmp.c
M include/block/accounting.h
M include/block/block-common.h
M include/block/block-io.h
M include/block/block_int-common.h
M include/block/raw-aio.h
M include/standard-headers/drm/drm_fourcc.h
M include/standard-headers/linux/ethtool.h
M include/standard-headers/linux/fuse.h
M include/standard-headers/linux/pci_regs.h
M include/standard-headers/linux/vhost_types.h
M include/standard-headers/linux/virtio_blk.h
M include/sysemu/block-backend-io.h
M linux-headers/asm-arm64/kvm.h
M linux-headers/asm-x86/kvm.h
M linux-headers/linux/kvm.h
M linux-headers/linux/vfio.h
M linux-headers/linux/vhost.h
M meson.build
M qapi/block-core.json
M qapi/block.json
M qemu-io-cmds.c
A tests/qemu-iotests/tests/zoned
A tests/qemu-iotests/tests/zoned.out
Log Message:
-----------
Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into
staging
Pull request
This pull request contains Sam Li's virtio-blk zoned storage work. These
patches were dropped from my previous block pull request due to CI failures.
# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmRLvo0ACgkQnKSrs4Gr
# c8iPDgf+IugpWRHiL+mM0VJFGo8DHAsWqixU8yM46Rig4xGPqcjdhmAqYUsziDcA
# 6jKtc+vhMGbj5jZrHOgLdIiLtFWs58zyXaQso2TAMWoI3s3DI3two+MT9DwOWnJM
# /0G2ZoEZnr1SO+Mzz0R8WKewB/ezbGpqwog/JILWu+vEXNCrtJYrd4XCSrL9Xs3n
# ZrwZCFc+bHKKmC251sqpe5ls9OkvFcIVPXSawNUTN8zesjd58dCssHnAgeIuopA5
# rM042u1xwINCc7uT06b9yBFEX058eWpvshwL+tZtPdyqg9XPtTBr6/mZPtNKFeU9
# bf0nuEGgRBSpbcj8uikjvefu8Rw4IQ==
# =pfhE
# -----END PGP SIGNATURE-----
# gpg: Signature made Fri 28 Apr 2023 01:39:41 PM BST
# gpg: using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>" [full]
# gpg: aka "Stefan Hajnoczi <stefanha@gmail.com>" [full]
* tag 'block-pull-request' of https://gitlab.com/stefanha/qemu:
docs/zoned-storage:add zoned emulation use case
virtio-blk: add some trace events for zoned emulation
block: add accounting for zone append operation
virtio-blk: add zoned storage emulation for zoned devices
include: update virtio_blk headers to v6.3-rc1
block: add some trace events for zone append
qemu-iotests: test zone append operation
block: introduce zone append write for zoned devices
file-posix: add tracking of the zone write pointers
docs/zoned-storage: add zoned device documentation
block: add some trace events for new block layer APIs
iotests: test new zone operations
block: add zoned BlockDriver check to block layer
block/raw-format: add zone operations to pass through requests
block/block-backend: add block layer APIs resembling Linux ZonedBlockDevice
ioctls
block/file-posix: introduce helper functions for sysfs attributes
block/block-common: add zoned device structs
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: f7a1a0a503cfa993d91b5539e59a9e2a6d181ffb
https://github.com/qemu/qemu/commit/f7a1a0a503cfa993d91b5539e59a9e2a6d181ffb
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M migration/meson.build
A migration/migration-stats.c
A migration/migration-stats.h
M migration/migration.c
M migration/multifd.c
M migration/postcopy-ram.c
M migration/qemu-file.c
M migration/qemu-file.h
A migration/ram-compress.c
A migration/ram-compress.h
M migration/ram.c
M migration/ram.h
M migration/rdma.c
M migration/savevm.c
M migration/tls.c
M migration/tls.h
M tests/qtest/migration-test.c
Log Message:
-----------
Merge tag 'migration-20230428-pull-request' of
https://gitlab.com/juan.quintela/qemu into staging
Migration Pull request (20230429 vintage)
Hi
In this series:
- compression code cleanup (lukas)
nice, nice, nice.
- drop useless parameters from migration_tls* (juan)
- first part of remove QEMUFileHooks series (juan)
Please apply.
# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEEGJn/jt6/WMzuA0uC9IfvGFhy1yMFAmRMF90ACgkQ9IfvGFhy
# 1yPVUBAApRj2d6K6T0FwW8axL0LUD+7QXmMnTkhO9/QJDBHGban9hWuaH4n3Om+0
# 89tHl5Fo6bgOJMagUGfIuF1Xt9tJSFZMp3OMFxrV2+yhLqHQ7LlJSIFrO+ILeRQJ
# 3kKzTzBEb9LNVFPKrD2SyEvhGxxD1kHfnNydKdU3XqvyAWPXqr1BonxsF06+i5ud
# WRhEJ9iL9eFP4CkCPOMHxBhfme6gP+NkxaB6R2Eb30jNTP1U9nTlKaV2fGLVn/zY
# VRC1bV9Ujy3wGeKBp8Lm9FIa8yBIf/HImI+nWGFROYslECMAR0kMfEU+aWY5y8By
# t0xDD0OEh2QB7rjGpx1B3Pb2He5YznzQNG4kmjNqWcH+PWurRbBaN++1r1DHrQzk
# fhfsT3A9eWUM06JsMm2Y+IhHwzT+PddmjWjHDU/kPNn1+GnxFytC55Ie5ew62PLu
# jWtOTERSg38e6m2gdFM5PLnfP5aLmjH0An78CDFhVy8f8I0R89tIC915p4QECuaa
# IIetvv70NF92EOXEtV9IEt8XvCsOomXrUCCtQMSAthHsh37Vn3W2U8fmXluAclua
# AW/mllj1AqEaUHVvCyST5bq0xqzE90dqjUB474oKi+wtPIzpXb8LP0xVZvcU8zWo
# 53MNFybvcDoZdva1JynzUvug06k5o2t91wIkLyUvigZZQ+3Osrg=
# =rl9X
# -----END PGP SIGNATURE-----
# gpg: Signature made Fri 28 Apr 2023 08:00:45 PM BST
# gpg: using RSA key 1899FF8EDEBF58CCEE034B82F487EF185872D723
# gpg: Good signature from "Juan Quintela <quintela@redhat.com>" [undefined]
# gpg: aka "Juan Quintela <quintela@trasno.org>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg: There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 1899 FF8E DEBF 58CC EE03 4B82 F487 EF18 5872 D723
* tag 'migration-20230428-pull-request' of
https://gitlab.com/juan.quintela/qemu: (21 commits)
migration: Initialize and cleanup decompression in migration.c
ram-compress.c: Make target independent
ram compress: Assert that the file buffer matches the result
ram.c: Move core decompression code into its own file
ram.c: Move core compression code into its own file
ram.c: Remove last ram.c dependency from the core compress code
ram.c: Call update_compress_thread_counts from compress_send_queued_data
ram.c: Do not call save_page_header() from compress threads
ram.c: Reset result after sending queued data
ram.c: Dont change param->block in the compress thread
ram.c: Let the compress threads return a CompressResult enum
qtest/migration-test.c: Add postcopy tests with compress enabled
qtest/migration-test.c: Add tests with compress enabled
migration: Drop unused parameter for migration_tls_client_create()
migration: Drop unused parameter for migration_tls_get_creds()
migration/rdma: Unfold last user of acct_update_position()
migration/rdma: Split the zero page case from acct_update_position
migration: Rename RAMStats to MigrationAtomicStats
migration: Rename ram_counters to mig_stats
migration: Move ram_stats to its own file migration-stats.[ch]
...
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Compare: https://github.com/qemu/qemu/compare/2074424ef6ec...f7a1a0a503cf
- [Qemu-commits] [qemu/qemu] a36c86: qga/qapi-schema: Tidy up documentation of guest-fs...,
Richard Henderson <=