qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 5ebecf: tests/qtest/rtl8139-test: Make the te


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 5ebecf: tests/qtest/rtl8139-test: Make the test less verbo...
Date: Mon, 27 Feb 2023 03:59:07 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 5ebecf207293014dca147f6a56200f918532f34c
      
https://github.com/qemu/qemu/commit/5ebecf207293014dca147f6a56200f918532f34c
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M tests/qtest/rtl8139-test.c

  Log Message:
  -----------
  tests/qtest/rtl8139-test: Make the test less verbose by default

We are facing the issues that some test logs in the gitlab CI are
too big (and thus cut off). The rtl8139-test is one of the few qtests
that prints many lines of output by default when running with V=1, so
it contributes to this problem. Almost all other qtests are silent
with V=1 and only print debug messages with V=2 and higher. Thus let's
change the rtl8139-test to behave more like the other tests and only
print the debug messages with V=2 (or higher).

Message-Id: <20230215124122.72037-1-thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: f0830823d017af1a4e7dad228e5870cad7eb764b
      
https://github.com/qemu/qemu/commit/f0830823d017af1a4e7dad228e5870cad7eb764b
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M hw/pci-host/mv64361.c
    M hw/ppc/pegasos2.c
    M hw/sensor/dps310.c
    M include/hw/ssi/ibex_spi_host.h
    M include/hw/tricore/tricore_testdevice.h

  Log Message:
  -----------
  Do not include hw/hw.h if it is not necessary

hw.h only contains the protoype of one function nowadays, hw_error(),
so all files that do not use this function anymore also do not need
to include this header anymore.

Message-Id: <20230216142915.304481-1-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 4c8a2054e78780622f5d005a52e0bc000f87eb93
      
https://github.com/qemu/qemu/commit/4c8a2054e78780622f5d005a52e0bc000f87eb93
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M hw/vfio/ccw.c

  Log Message:
  -----------
  hw/vfio/ccw: Simplify using DEVICE() macro

QOM parenthood relationship is:

  VFIOCCWDevice -> S390CCWDevice -> CcwDevice -> DeviceState

We can directly use the QOM DEVICE() macro to get the parent object.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Message-Id: <20230213170145.45666-3-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 011da22c5c53910239e7c13394bdeca90c729b09
      
https://github.com/qemu/qemu/commit/011da22c5c53910239e7c13394bdeca90c729b09
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M hw/vfio/ccw.c

  Log Message:
  -----------
  hw/vfio/ccw: Use intermediate S390CCWDevice variable

'cdev' is VFIOCCWDevice's private parent object.
Access it using the S390_CCW_DEVICE() QOM macro.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Message-Id: <20230213170145.45666-4-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 0cea1f62a872c22af362acab05beb947a1fdee77
      
https://github.com/qemu/qemu/commit/0cea1f62a872c22af362acab05beb947a1fdee77
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M hw/vfio/ccw.c

  Log Message:
  -----------
  hw/vfio/ccw: Replace DO_UPCAST(S390CCWDevice) by S390_CCW_DEVICE()

Use the S390_CCW_DEVICE() QOM type-checking macro to avoid DO_UPCAST().

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20230213170145.45666-5-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 4b447883ede2d75960f2c02856e68710d6155268
      
https://github.com/qemu/qemu/commit/4b447883ede2d75960f2c02856e68710d6155268
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M hw/vfio/ccw.c

  Log Message:
  -----------
  hw/vfio/ccw: Remove pointless S390CCWDevice variable

QOM parenthood relationship is:

  VFIOCCWDevice -> S390CCWDevice -> CcwDevice -> DeviceState

No need to double-cast, call CCW_DEVICE() on VFIOCCWDevice.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Message-Id: <20230213170145.45666-6-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: ecba64689596614112b662d0579d097fa5cfd5d5
      
https://github.com/qemu/qemu/commit/ecba64689596614112b662d0579d097fa5cfd5d5
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M hw/vfio/ccw.c

  Log Message:
  -----------
  hw/vfio/ccw: Replace DO_UPCAST(VFIOCCWDevice) by VFIO_CCW()

Use the VFIO_CCW() QOM type-checking macro to avoid DO_UPCAST().

Reviewed-by: Eric Farman <farman@linux.ibm.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230213170145.45666-7-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: eb60026120081430d554c9cabaa36c4ac271fce0
      
https://github.com/qemu/qemu/commit/eb60026120081430d554c9cabaa36c4ac271fce0
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M target/s390x/arch_dump.c

  Log Message:
  -----------
  target/s390x/arch_dump: Fix memory corruption in s390x_write_elf64_notes()

"note_size" can be smaller than sizeof(note), so unconditionally calling
memset(notep, 0, sizeof(note)) could cause a memory corruption here in
case notep has been allocated dynamically, thus let's use note_size as
length argument for memset() instead.

Reported-by: Sebastian Mitterle <smitterl@redhat.com>
Fixes: 113d8f4e95 ("s390x: pv: Add dump support")
Message-Id: <20230214141056.680969-1-thuth@redhat.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 4376a770c719f480dd6fad130db8eceeda8cdcb7
      
https://github.com/qemu/qemu/commit/4376a770c719f480dd6fad130db8eceeda8cdcb7
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M target/s390x/arch_dump.c

  Log Message:
  -----------
  target/s390x/arch_dump: Simplify memory allocation in 
s390x_write_elf64_notes()

We are not on a hot path here, so there is no real need for the logic
here with the split heap and stack space allocation. Simplify it by
always allocating memory from the heap.

Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230215085703.746788-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 40494314789ba87dc118b91e8a8964a99809a5fb
      
https://github.com/qemu/qemu/commit/40494314789ba87dc118b91e8a8964a99809a5fb
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M target/s390x/tcg/mem_helper.c

  Log Message:
  -----------
  target/s390x: Fix s390_probe_access for user-only

In db9aab5783a2 we broke the contract of s390_probe_access, in that it
no longer returned an exception code, nor set __excp_addr.  Fix both.

Reported-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20230109201856.3916639-2-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 7ba5da818a73048a9a2e4949bb971708b2f4259c
      
https://github.com/qemu/qemu/commit/7ba5da818a73048a9a2e4949bb971708b2f4259c
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M target/s390x/tcg/mem_helper.c

  Log Message:
  -----------
  target/s390x: Pass S390Access pointer into access_prepare

Passing a pointer from the caller down to access_prepare_nf
eliminates a structure copy.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20230109201856.3916639-3-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: bebc8ade7014ca1f8afbc9d1bd297460f2e88461
      
https://github.com/qemu/qemu/commit/bebc8ade7014ca1f8afbc9d1bd297460f2e88461
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M target/s390x/tcg/mem_helper.c

  Log Message:
  -----------
  target/s390x: Use void* for haddr in S390Access

The interface from probe_access_flags is void*, and matching
that will be helpful.  We already rely on the gcc extension
for byte arithmetic on void*.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20230109201856.3916639-4-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: fb391b0b474c316d841f5e27fd094832a91f77f4
      
https://github.com/qemu/qemu/commit/fb391b0b474c316d841f5e27fd094832a91f77f4
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M target/s390x/tcg/mem_helper.c

  Log Message:
  -----------
  target/s390x: Tidy access_prepare_nf

Assign to access struct immediately, rather than waiting
until the end of the function.  This means we can pass
address of haddr struct members instead of allocating
extra space on the local stack.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20230109201856.3916639-5-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 96b1416fda52cb37eaa6d2316d9946b1078c6210
      
https://github.com/qemu/qemu/commit/96b1416fda52cb37eaa6d2316d9946b1078c6210
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M target/s390x/tcg/mem_helper.c

  Log Message:
  -----------
  target/s390x: Remove TLB_NOTDIRTY workarounds

When this code was written, it was using tlb_vaddr_to_host,
which does not handle TLB_DIRTY.  Since then, it has been
converted to probe_access_flags, which does.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: David Hildenbrand <david@redhat.com>
Message-Id: <20230109201856.3916639-6-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 61dee10ff00720e6e056824b4548c914632ef6fe
      
https://github.com/qemu/qemu/commit/61dee10ff00720e6e056824b4548c914632ef6fe
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M target/s390x/tcg/mem_helper.c

  Log Message:
  -----------
  target/s390x: Inline do_access_{get,set}_byte

Inline into the parent functions with a simple test
to select the page, and a new define to remove ifdefs.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20230109201856.3916639-7-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: e73a0f4075a78de9a62beeddb41c54a4090e0777
      
https://github.com/qemu/qemu/commit/e73a0f4075a78de9a62beeddb41c54a4090e0777
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M target/s390x/tcg/mem_helper.c

  Log Message:
  -----------
  target/s390x: Hoist some computation in access_memmove

Ensure that the total length is in a local variable
across the byte loop.  Compute size1 difference once.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20230109201856.3916639-8-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: c3a073c6109dfa34ed4d3b5d8238b97e696aaf20
      
https://github.com/qemu/qemu/commit/c3a073c6109dfa34ed4d3b5d8238b97e696aaf20
  Author: Claudio Imbrenda <imbrenda@linux.ibm.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M hw/s390x/pv.c
    M hw/s390x/s390-virtio-ccw.c
    M include/hw/s390x/pv.h

  Log Message:
  -----------
  s390x/pv: Add support for asynchronous teardown for reboot

This patch adds support for the asynchronous teardown for reboot for
protected VMs.

When attempting to tear down a protected VM, try to use the new
asynchronous interface first. If that fails, fall back to the classic
synchronous one.

The asynchronous interface involves invoking the new
KVM_PV_ASYNC_DISABLE_PREPARE command for the KVM_S390_PV_COMMAND ioctl.

This will prepare the current protected VM for asynchronous teardown.
Once the protected VM is prepared for teardown, execution can continue
immediately.

Once the protected VM has been prepared, a new thread is started to
actually perform the teardown. The new thread uses the new
KVM_PV_ASYNC_DISABLE command for the KVM_S390_PV_COMMAND ioctl. The
previously prepared protected VM is torn down in the new thread.

Once KVM_PV_ASYNC_DISABLE is invoked, it is possible to use
KVM_PV_ASYNC_DISABLE_PREPARE again. If a protected VM has already been
prepared and its cleanup has not started, it will not be possible to
prepare a new VM. In that case the classic synchronous teardown has to
be performed.

The synchronous teardown will now also clean up any prepared VMs whose
asynchronous teardown has not been initiated yet.

This considerably speeds up the reboot of a protected VM; for large VMs
especially, it could take a long time to perform a reboot with the
traditional synchronous teardown, while with this patch it is almost
immediate.

Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20230214163035.44104-3-imbrenda@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: f1ea739bd598db3d8801566ae86e4eb76ab44436
      
https://github.com/qemu/qemu/commit/f1ea739bd598db3d8801566ae86e4eb76ab44436
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M target/s390x/tcg/translate.c

  Log Message:
  -----------
  target/s390x: Use tcg_constant_* in local contexts

Replace tcg_const_* with tcg_constant_* in contexts
where the free to remove is nearby.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20230220184052.163465-2-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: f5d7b0e2e05526585e9cad9284ca265838fd1799
      
https://github.com/qemu/qemu/commit/f5d7b0e2e05526585e9cad9284ca265838fd1799
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M target/s390x/tcg/translate.c

  Log Message:
  -----------
  target/s390x: Use tcg_constant_* for DisasCompare

The a and b fields are not modified by the consumer,
and while we need not free a constant, tcg will quietly
ignore such frees, so free_compare need not be changed.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20230220184052.163465-3-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 6276d93faa5546e5c616eecc333d9ea397b763ac
      
https://github.com/qemu/qemu/commit/6276d93faa5546e5c616eecc333d9ea397b763ac
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M target/s390x/tcg/translate.c

  Log Message:
  -----------
  target/s390x: Use tcg_constant_i32 for fpinst_extract_m34

Return a constant or NULL, which means the free may be
removed from all callers of fpinst_extract_m34.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20230220184052.163465-4-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 2b0fa727f7d02176a2c620093810402cc744072b
      
https://github.com/qemu/qemu/commit/2b0fa727f7d02176a2c620093810402cc744072b
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M target/s390x/tcg/translate_vx.c.inc

  Log Message:
  -----------
  target/s390x: Use tcg_constant_* in translate_vx.c.inc

In most cases, this is a simple local allocate and free
replaced by tcg_constant_*.  In three cases, a variable
temp was initialized with a constant value -- reorg to
localize the constant.  In gen_acc, this fixes a leak.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20230220184052.163465-5-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: c78d9269755dce56ac8d16181af46aa969aa7755
      
https://github.com/qemu/qemu/commit/c78d9269755dce56ac8d16181af46aa969aa7755
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M tests/tcg/s390x/Makefile.softmmu-target
    A tests/tcg/s390x/bal.S

  Log Message:
  -----------
  tests/tcg/s390x: Add bal.S

Add a small test to prevent regressions.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20221103130011.2670186-1-iii@linux.ibm.com>
Message-Id: <20230220184052.163465-6-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: c8db90b86d0849b59452b8cac5b477bb65dcb6a1
      
https://github.com/qemu/qemu/commit/c8db90b86d0849b59452b8cac5b477bb65dcb6a1
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M tests/tcg/s390x/Makefile.softmmu-target
    A tests/tcg/s390x/sam.S

  Log Message:
  -----------
  tests/tcg/s390x: Add sam.S

Add a small test to prevent regressions.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20221129015328.55439-1-iii@linux.ibm.com>
Message-Id: <20230220184052.163465-7-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: f160a5b25b33b69b089815cfd435aa3199497984
      
https://github.com/qemu/qemu/commit/f160a5b25b33b69b089815cfd435aa3199497984
  Author: Dinah Baum <dinahbaum123@gmail.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Add 'mkdir build' check

QEMU configure script goes into an infinite error printing loop
when in read only directory due to 'build' dir never being created.

Checking if 'mkdir dir' succeeds prevents this error.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/321
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Dinah Baum <dinahbaum123@gmail.com>
Message-Id: <20230221110631.4142-1-dinahbaum123@gmail.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
[thuth: Remove second "touch $MARKER"]
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 5c70adbfbbf98c22d43fb4df1bac6802b6c61034
      
https://github.com/qemu/qemu/commit/5c70adbfbbf98c22d43fb4df1bac6802b6c61034
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M qemu-keymap.c

  Log Message:
  -----------
  qemu-keymap: Silence memory leak warning from Clang's sanitizer

When compiling QEMU with "--enable-sanitizers --enable-xkbcommon --cc=clang"
there is a memory leak warning when running qemu-keymap:

 $ ./qemu-keymap -f pc-bios/keymaps/de -l de

 =================================================================
 ==610321==ERROR: LeakSanitizer: detected memory leaks

 Direct leak of 136 byte(s) in 1 object(s) allocated from:
     #0 0x5642830d0820 in __interceptor_calloc.part.11 asan_malloc_linux.cpp.o
     #1 0x7f31873b8d2b in xkb_state_new (/lib64/libxkbcommon.so.0+0x1dd2b) 
(BuildId: dd32581e2248833243f3f646324ae9b98469f025)

 SUMMARY: AddressSanitizer: 136 byte(s) leaked in 1 allocation(s).

It can be silenced by properly releasing the "state" again
after it has been used.

Message-Id: <20230221122440.612281-1-thuth@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: adf4c9bd2e274968e1abc2430376349eb3f3d392
      
https://github.com/qemu/qemu/commit/adf4c9bd2e274968e1abc2430376349eb3f3d392
  Author: Steve Sistare <steven.sistare@oracle.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M docs/devel/kconfig.rst
    M pc-bios/keymaps/meson.build

  Log Message:
  -----------
  meson: fix dependency on qemu-keymap

When qemu-keymap is not available on the host, and enable-xkbcommon
is specified, parallel make fails with:

  % make clean
  ...
  % make -j 32
  ...
  FAILED: pc-bios/keymaps/is
  ./qemu-keymap -f pc-bios/keymaps/is -l is
  /bin/sh: ./qemu-keymap: No such file or directory
  ... many similar messages ...

The code always runs find_program, rather than waiting to build
qemu-keymap, because it looks for CONFIG_XKBCOMMON in config_host
rather than config_host_data.  Making serially succeeds, by soft
linking files from pc-bios/keymaps, but that is not the desired
result for enable-xkbcommon.

Examining all occurrences of 'in config_host' for similar bugs shows one
instance in the docs, which is also fixed here.

Fixes: 4113f4cfee ("meson: move xkbcommon to meson")

Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <1675708442-74966-1-git-send-email-steven.sistare@oracle.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 0c201cc17fef05f9fa771b462ad979d8b2f4f526
      
https://github.com/qemu/qemu/commit/0c201cc17fef05f9fa771b462ad979d8b2f4f526
  Author: Khadija Kamran <kkamran.bese16seecs@seecs.edu.pk>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M contrib/gitdm/filetypes.txt
    M hw/scsi/viosrp.h
    M hw/sh4/sh7750_regs.h
    M include/hw/arm/raspi_platform.h
    M include/qemu/uri.h
    M tests/qemu-iotests/022
    M tests/unit/rcutorture.c
    M tests/unit/test-rcu-list.c
    M util/uri.c

  Log Message:
  -----------
  Updated the FSF address to <https://www.gnu.org/licenses/>

The Free Software Foundation moved to a new address and some
sources in QEMU referred to their old location.
The address should be updated and replaced by a pointer to
<https://www.gnu.org/licenses/>

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/379
Signed-off-by: Khadija Kamran <kkamran.bese16seecs@seecs.edu.pk>
Message-Id: 
<576ee9203fdac99d7251a98faa66b9ce1e7febc5.1675941486.git.kkamran.bese16seecs@seecs.edu.pk>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 6eda5ef5f8f43ee992586a29d4323f3359695650
      
https://github.com/qemu/qemu/commit/6eda5ef5f8f43ee992586a29d4323f3359695650
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml

  Log Message:
  -----------
  gitlab-ci.d/buildtest: Remove aarch64-softmmu from the build-system-ubuntu job

aarch64-softmmu is also checked on the same version of Ubuntu in the
gcov job, so it is redundant to check again in the normal ubuntu job.

Message-Id: <20230207201447.566661-3-thuth@redhat.com>
Reviewed-by: David Woodhouse <dwmw2@infradead.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 2f5a375f6033fcb4cedd6874852ff3def5841c95
      
https://github.com/qemu/qemu/commit/2f5a375f6033fcb4cedd6874852ff3def5841c95
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    M .gitlab-ci.d/crossbuilds.yml

  Log Message:
  -----------
  gitlab-ci.d/buildtest: Disintegrate the build-coroutine-sigaltstack job

We can get rid of the build-coroutine-sigaltstack job by moving
the configure flags that should be tested here to other jobs:
Move --with-coroutine=sigaltstack to the build-system-debian job
(where the coroutines should get some more test coverage with
"make check-block", too) and --enable-trace-backends=ftrace to
the cross-s390x-kvm-only job.

Message-Id: <20230207201447.566661-4-thuth@redhat.com>
Reviewed-by: David Woodhouse <dwmw2@infradead.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 22ebcba061f882c4cc4a77124d1e9f13cd3b1a07
      
https://github.com/qemu/qemu/commit/22ebcba061f882c4cc4a77124d1e9f13cd3b1a07
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M .gitlab-ci.d/buildtest-template.yml

  Log Message:
  -----------
  gitlab-ci.d/buildtest-template: Simplify the configure step

It's easier to use ${TARGETS:+--target-list="$TARGETS"} to add
a --target-list parameter depending on whether the TARGETS variable
is set or not.

Message-Id: <20230207201447.566661-5-thuth@redhat.com>
Reviewed-by: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: eda2321d7f807d3cc5a98aea34bbab82e2e8a7e6
      
https://github.com/qemu/qemu/commit/eda2321d7f807d3cc5a98aea34bbab82e2e8a7e6
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M .gitlab-ci.d/buildtest-template.yml
    M .gitlab-ci.d/buildtest.yml
    M .gitlab-ci.d/crossbuild-template.yml
    M .gitlab-ci.d/crossbuilds.yml
    M .gitlab-ci.d/windows.yml

  Log Message:
  -----------
  gitlab-ci.d: Build with --enable-fdt=system by default

By using --enable-fdt=system we can make sure that the configure
script does not try to check out the "dtc" submodule. This should
help to safe some precious CI minutes in the long run.

While we're at it, also drop some now-redundant --enable-slirp
and --enable-capstone statements. These used to have the "=system"
suffix in the past, too, which has been dropped when the their
corresponding submodules had been removed. Since these features
are auto-enabled anyway now (since the containers have the right
libraries installed), we do not need the explicit --enable-...
statements anymore.

Message-Id: <20230207201447.566661-6-thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: e97a9b8ce6aaefcd2523010946609245b8a1bd8c
      
https://github.com/qemu/qemu/commit/e97a9b8ce6aaefcd2523010946609245b8a1bd8c
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M .gitlab-ci.d/base.yml

  Log Message:
  -----------
  gitlab-ci.d/base: Mark jobs as interruptible by default

When handling pull requests in the staging branch, it often happens
that one of the job fails due to a problem, so that the pull request
can't be merged. Peter/Richard/Stefan then informs the sender of the
pull request and continues by pushing the next pending pull request
from another subsystem maintainer. Now the problem is that there might
still be lots of other running jobs in the pipeline of the first pull
request, eating up precious CI minutes though the pipeline is not
needed anymore. We can avoid this by marking the jobs as "interruptible".
With this setting, the jobs from previous pipelines are automatically
terminated when pushing a new one. If someone does not like this auto-
matic termination, it can still be disabled in the settings of the
repository. See this URL for details:

 https://docs.gitlab.com/ee/ci/yaml/index.html#interruptible

Message-Id: <20230223191343.1064274-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: fffa36b68e2f266c8b03ef3fdd242aa9a9181a87
      
https://github.com/qemu/qemu/commit/fffa36b68e2f266c8b03ef3fdd242aa9a9181a87
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M docs/about/deprecated.rst
    M softmmu/vl.c

  Log Message:
  -----------
  Deprecate the "-no-acpi" command line switch

Similar to "-no-hpet", the "-no-acpi" switch is a legacy command
line option that should be replaced with the "acpi" machine parameter
nowadays.

Message-Id: <20230224090543.1129677-1-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 3db629f03e8caf39526cd0415dac16a6a6484107
      
https://github.com/qemu/qemu/commit/3db629f03e8caf39526cd0415dac16a6a6484107
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M .gitlab-ci.d/base.yml
    M .gitlab-ci.d/buildtest-template.yml
    M .gitlab-ci.d/buildtest.yml
    M .gitlab-ci.d/crossbuild-template.yml
    M .gitlab-ci.d/crossbuilds.yml
    M .gitlab-ci.d/windows.yml
    M configure
    M contrib/gitdm/filetypes.txt
    M docs/about/deprecated.rst
    M docs/devel/kconfig.rst
    M hw/pci-host/mv64361.c
    M hw/ppc/pegasos2.c
    M hw/s390x/pv.c
    M hw/s390x/s390-virtio-ccw.c
    M hw/scsi/viosrp.h
    M hw/sensor/dps310.c
    M hw/sh4/sh7750_regs.h
    M hw/vfio/ccw.c
    M include/hw/arm/raspi_platform.h
    M include/hw/s390x/pv.h
    M include/hw/ssi/ibex_spi_host.h
    M include/hw/tricore/tricore_testdevice.h
    M include/qemu/uri.h
    M pc-bios/keymaps/meson.build
    M qemu-keymap.c
    M softmmu/vl.c
    M target/s390x/arch_dump.c
    M target/s390x/tcg/mem_helper.c
    M target/s390x/tcg/translate.c
    M target/s390x/tcg/translate_vx.c.inc
    M tests/qemu-iotests/022
    M tests/qtest/rtl8139-test.c
    M tests/tcg/s390x/Makefile.softmmu-target
    A tests/tcg/s390x/bal.S
    A tests/tcg/s390x/sam.S
    M tests/unit/rcutorture.c
    M tests/unit/test-rcu-list.c
    M util/uri.c

  Log Message:
  -----------
  Merge tag 'pull-request-2023-02-27' of https://gitlab.com/thuth/qemu into 
staging

* Simplify device casting in w/vfio/ccw.c
* Fix memory corruption in the s390x dump code
* Various s390x TCG clean-ups
* s390x PV support for asynchronous teardown for reboot
* qemu-keymap related fixes
* Improvements for the duration of the gitlab-CI
* Deprecate the "-no-acpi" command line switch

# -----BEGIN PGP SIGNATURE-----
#
# iQJFBAABCAAvFiEEJ7iIR+7gJQEY8+q5LtnXdP5wLbUFAmP8lVURHHRodXRoQHJl
# ZGhhdC5jb20ACgkQLtnXdP5wLbWYkg//RTKsG0+HGMtnKvjTA5NzLIJrWAQfSPfh
# ABkxNHoscReae8LGquFfeTy9cN/uA051e/P06WfPXAkg3Uj72JKHHs/ncm5VhApY
# 7moOCIHlvFRAsy5TKYoInM+Yo0jov7vgKqqJcS3AL3hwhmvEwPwKr0cpZLNfKV8p
# GD+XM453g0AFn2jDFoXDsnHX3zco+7sd4dQN4olSrkd/gDel2UQ5JE4gJ/o6Qgys
# GW4vb+NpxQ6W3mSlU+ClTr03ZljPkascBS7tZO8Fwn+J3Wv4UTNLlM1JFXQhC3v8
# x9HpVpk4HW6C/hiPcsMpZRlXBb/HklkAhDxZ6tjTnQLRvbJ/o2uISJt+ZgeH9zeQ
# Ae4Ap7yPxsuGbx2twzbGoyEPAJj18hW7EUd6KromFqy877svmyRYs3NXQqSJOEmh
# Pv7VriUe6esyyVSXWjA6g2imo5pIhWxxRlsNVrrp8vOJNYT+ygBIFqu28ngwk86H
# jZOLqekEkQrNkwZZLuoxm8FyCAvzfMBeHQFlDnL4a3114dlC6X3/cJqCZ5htTaO+
# t7CL6QcepRh0NQPw1jRlUCARZK+WocjwwcmzgVzSKKzGpdg/EJC8Sg54l7wdVQCp
# jY3HEUWHHHmrqe3IefrzadRQhsB9xKcNdUaZmetRUm+ohgSc9S0cfpVXNwT+G3+M
# a47dp9ueI6Q=
# =wDFZ
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 27 Feb 2023 11:34:45 GMT
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* tag 'pull-request-2023-02-27' of https://gitlab.com/thuth/qemu: (33 commits)
  Deprecate the "-no-acpi" command line switch
  gitlab-ci.d/base: Mark jobs as interruptible by default
  gitlab-ci.d: Build with --enable-fdt=system by default
  gitlab-ci.d/buildtest-template: Simplify the configure step
  gitlab-ci.d/buildtest: Disintegrate the build-coroutine-sigaltstack job
  gitlab-ci.d/buildtest: Remove aarch64-softmmu from the build-system-ubuntu job
  Updated the FSF address to <https://www.gnu.org/licenses/>
  meson: fix dependency on qemu-keymap
  qemu-keymap: Silence memory leak warning from Clang's sanitizer
  configure: Add 'mkdir build' check
  tests/tcg/s390x: Add sam.S
  tests/tcg/s390x: Add bal.S
  target/s390x: Use tcg_constant_* in translate_vx.c.inc
  target/s390x: Use tcg_constant_i32 for fpinst_extract_m34
  target/s390x: Use tcg_constant_* for DisasCompare
  target/s390x: Use tcg_constant_* in local contexts
  s390x/pv: Add support for asynchronous teardown for reboot
  target/s390x: Hoist some computation in access_memmove
  target/s390x: Inline do_access_{get,set}_byte
  target/s390x: Remove TLB_NOTDIRTY workarounds
  ...

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/b11728dc3ae6...3db629f03e8c



reply via email to

[Prev in Thread] Current Thread [Next in Thread]