[Qemu-commits] [qemu/qemu] a0aecc: accel/tcg: Allow the second page of a

qemu-commits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] a0aecc: accel/tcg: Allow the second page of a

From:	Peter Maydell
Subject:	[Qemu-commits] [qemu/qemu] a0aecc: accel/tcg: Allow the second page of an instruction...
Date:	Tue, 21 Feb 2023 05:20:46 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: a0aecc26b65f1ac34114bdd51df636fb8a93d9fa
      
https://github.com/qemu/qemu/commit/a0aecc26b65f1ac34114bdd51df636fb8a93d9fa
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-19 (Sun, 19 Feb 2023)

  Changed paths:
    M accel/tcg/translator.c

  Log Message:
  -----------
  accel/tcg: Allow the second page of an instruction to be MMIO

If an instruction straddles a page boundary, and the first page
was ram, but the second page was MMIO, we would abort.  Handle
this as if both pages are MMIO, by setting the ram_addr_t for
the first page to -1.

Reported-by: Sid Manning <sidneym@quicinc.com>
Reported-by: Jørgen Hansen <Jorgen.Hansen@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 98a1737c7a37923b0911303cc86413d659b80afc
      
https://github.com/qemu/qemu/commit/98a1737c7a37923b0911303cc86413d659b80afc
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-19 (Sun, 19 Feb 2023)

  Changed paths:
    M linux-user/sparc/cpu_loop.c

  Log Message:
  -----------
  linux-user/sparc: Raise SIGILL for all unhandled software traps

The linux kernel's trap tables vector all unassigned trap
numbers to BAD_TRAP, which then raises SIGILL.

Tested-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reported-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: ad574d64008e181374f5f912806e870da3637782
      
https://github.com/qemu/qemu/commit/ad574d64008e181374f5f912806e870da3637782
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2023-02-19 (Sun, 19 Feb 2023)

  Changed paths:
    M linux-user/main.c
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: Always exit from exclusive state in fork_end()

fork()ed processes currently start with
current_cpu->in_exclusive_context set, which is, strictly speaking, not
correct, but does not cause problems (even assertion failures).

With one of the next patches, the code begins to rely on this value, so
fix it by always calling end_exclusive() in fork_end().

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20230214140829.45392-2-iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: c06147da68481b0c60d759bdd3e8b1fdda8729b2
      
https://github.com/qemu/qemu/commit/c06147da68481b0c60d759bdd3e8b1fdda8729b2
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2023-02-19 (Sun, 19 Feb 2023)

  Changed paths:
    M cpus-common.c
    M include/hw/core/cpu.h

  Log Message:
  -----------
  cpus: Make {start,end}_exclusive() recursive

Currently dying to one of the core_dump_signal()s deadlocks, because
dump_core_and_abort() calls start_exclusive() two times: first via
stop_all_tasks(), and then via preexit_cleanup() ->
qemu_plugin_user_exit().

There are a number of ways to solve this: resume after dumping core;
check cpu_in_exclusive_context() in qemu_plugin_user_exit(); or make
{start,end}_exclusive() recursive. Pick the last option, since it's
the most straightforward one.

Fixes: da91c1920242 ("linux-user: Clean up when exiting due to a signal")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20230214140829.45392-3-iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: c0933bf7346a4c8c989b8b0a5918ad176881edf9
      
https://github.com/qemu/qemu/commit/c0933bf7346a4c8c989b8b0a5918ad176881edf9
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2023-02-19 (Sun, 19 Feb 2023)

  Changed paths:
    M linux-user/microblaze/cpu_loop.c

  Log Message:
  -----------
  linux-user/microblaze: Handle privileged exception

Follow what kernel's full_exception() is doing.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20230214140829.45392-4-iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 97c03b1733987c611080eb3d6d09fe1613b9cdb1
      
https://github.com/qemu/qemu/commit/97c03b1733987c611080eb3d6d09fe1613b9cdb1
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2023-02-19 (Sun, 19 Feb 2023)

  Changed paths:
    A tests/tcg/multiarch/linux/linux-fork-trap.c

  Log Message:
  -----------
  tests/tcg/linux-test: Add linux-fork-trap test

Check that dying due to a signal does not deadlock.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20230214140829.45392-5-iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 2f5b4792c0220920831ac84f94c3435b14791857
      
https://github.com/qemu/qemu/commit/2f5b4792c0220920831ac84f94c3435b14791857
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-02-19 (Sun, 19 Feb 2023)

  Changed paths:
    M configs/targets/microblaze-linux-user.mak
    M configs/targets/microblaze-softmmu.mak
    M configs/targets/microblazeel-linux-user.mak
    M configs/targets/microblazeel-softmmu.mak
    A gdb-xml/microblaze-core.xml
    A gdb-xml/microblaze-stack-protect.xml
    M target/microblaze/cpu.c
    M target/microblaze/cpu.h
    M target/microblaze/gdbstub.c

  Log Message:
  -----------
  target/microblaze: Add gdbstub xml

Mirroring the upstream gdb xml files, the two stack boundary
registers are separated out.

Reviewed-by: Edgar E. Iglesias <edgar@zeroasic.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 1ff77887236076a7b82d604c1680ac910cdc6ee1
      
https://github.com/qemu/qemu/commit/1ff77887236076a7b82d604c1680ac910cdc6ee1
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2023-02-21 (Tue, 21 Feb 2023)

  Changed paths:
    M accel/tcg/translator.c
    M configs/targets/microblaze-linux-user.mak
    M configs/targets/microblaze-softmmu.mak
    M configs/targets/microblazeel-linux-user.mak
    M configs/targets/microblazeel-softmmu.mak
    M cpus-common.c
    A gdb-xml/microblaze-core.xml
    A gdb-xml/microblaze-stack-protect.xml
    M include/hw/core/cpu.h
    M linux-user/main.c
    M linux-user/microblaze/cpu_loop.c
    M linux-user/sparc/cpu_loop.c
    M linux-user/syscall.c
    M target/microblaze/cpu.c
    M target/microblaze/cpu.h
    M target/microblaze/gdbstub.c
    A tests/tcg/multiarch/linux/linux-fork-trap.c

  Log Message:
  -----------
  Merge tag 'pull-tcg-20230219' of https://gitlab.com/rth7680/qemu into staging

tcg: Allow first half of insn in ram, and second half in mmio
linux-user/sparc: SIGILL for unknown trap vectors
linux-user/microblaze: SIGILL for privileged insns
linux-user: Fix deadlock while exiting due to signal
target/microblaze: Add gdbstub xml

# -----BEGIN PGP SIGNATURE-----
#
# iQFRBAABCgA7FiEEekgeeIaLTbaoWgXAZN846K9+IV8FAmPy5xQdHHJpY2hhcmQu
# aGVuZGVyc29uQGxpbmFyby5vcmcACgkQZN846K9+IV+nHQgAvYfTQV+uth+0SULv
# ii4FB2lqPl3du/bcjfjm48ly6sV/Bqk0cMncv9r1bzFz/YwWKfWxGoUdTKAyAfMq
# G4d8sT/fqviYLifyhzb79xfTH8RqAdQI/0HtnqfCUnZW2x6APCYFOlrEsgrYuR9L
# e99fhDW2PArgMdiLcKw4Xw+K4aLs1RgMuHgod9UOckFaTJBJ2D/kS9Hc+OYnTijK
# UqH/h5ePKDTh6Y6W1XNjZ9uG0VEsvyTmrxkz1N9z2IJ5akwv33/nim/92CVRMoJE
# yacWyLPe9IPF93XUiJejJIMj2kklAwVs5AIxiW7Gh71WGN5fTHPx3T5SGqZdmWHr
# BjspZw==
# =t3Ou
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 20 Feb 2023 03:20:52 GMT
# gpg:                using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg:                issuer "richard.henderson@linaro.org"
# gpg: Good signature from "Richard Henderson <richard.henderson@linaro.org>" 
[full]
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* tag 'pull-tcg-20230219' of https://gitlab.com/rth7680/qemu:
  target/microblaze: Add gdbstub xml
  tests/tcg/linux-test: Add linux-fork-trap test
  linux-user/microblaze: Handle privileged exception
  cpus: Make {start,end}_exclusive() recursive
  linux-user: Always exit from exclusive state in fork_end()
  linux-user/sparc: Raise SIGILL for all unhandled software traps
  accel/tcg: Allow the second page of an instruction to be MMIO

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/79b677d658d3...1ff778872360

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-commits] [qemu/qemu] a0aecc: accel/tcg: Allow the second page of an instruction..., Peter Maydell <=

Prev by Date: [Qemu-commits] [qemu/qemu] 66169c: hw/sparse-mem: clear memory on reset
Next by Date: [Qemu-commits] [qemu/qemu] 62c5bc: hw/riscv: handle 32 bit CPUs kernel_entry in riscv...
Previous by thread: [Qemu-commits] [qemu/qemu] 66169c: hw/sparse-mem: clear memory on reset
Next by thread: [Qemu-commits] [qemu/qemu] 62c5bc: hw/riscv: handle 32 bit CPUs kernel_entry in riscv...
Index(es):
- Date
- Thread