qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 9323af: tests: fix test-cutils leaks


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] 9323af: tests: fix test-cutils leaks
Date: Tue, 05 Jul 2022 09:43:28 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 9323af2e81be7c7697db024bdd5680a8d47c17e4
      
https://github.com/qemu/qemu/commit/9323af2e81be7c7697db024bdd5680a8d47c17e4
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-07-04 (Mon, 04 Jul 2022)

  Changed paths:
    M tests/unit/test-cutils.c

  Log Message:
  -----------
  tests: fix test-cutils leaks

Reported by ASAN.

Fixes commit cfb34489 ("cutils: add functions for IEC and SI prefixes").

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20220621083420.66365-1-marcandre.lureau@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: e0a2602070e4f3c265a6c0fc48b4f032455ea3d3
      
https://github.com/qemu/qemu/commit/e0a2602070e4f3c265a6c0fc48b4f032455ea3d3
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M tests/fp/meson.build

  Log Message:
  -----------
  tests/fp: Do not build softfloat3 tests if TCG is disabled

Technically we don't need the TCG accelerator to run the
softfloat3 tests. However it is unlikely an interesting
build combination. Developers using softfloat3 likely use
TCG too. Similarly, developers disabling TCG shouldn't
mind much about softfloat3 tests.

This reduces a non-TCG build by 474 objects!

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220204152924.6253-3-f4bug@amsat.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 94b731874a853cebc50f8e30c85c9c533a690c05
      
https://github.com/qemu/qemu/commit/94b731874a853cebc50f8e30c85c9c533a690c05
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M .gitlab-ci.d/edk2.yml
    M .gitlab-ci.d/opensbi.yml

  Log Message:
  -----------
  gitlab: normalize indentation in edk2/opensbi rules

The edk2/opensbi gitlab CI config was using single space indents
which is not consistent with the rest of the gitlab CI config
files.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220629170638.520630-2-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 37a2b95231d6699536820c8ff0ca3f5ba8356184
      
https://github.com/qemu/qemu/commit/37a2b95231d6699536820c8ff0ca3f5ba8356184
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M .gitlab-ci.d/edk2.yml
    M .gitlab-ci.d/opensbi.yml

  Log Message:
  -----------
  gitlab: tweak comments in edk2/opensbi jobs

Get rid of comments stating the obvious and re-arrange remaining
comments. The opensbi split of rules for file matches is also
merged into one rule.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220629170638.520630-3-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 6e131bf69b98fbe74cc02b5a910fa2dc5bb7962e
      
https://github.com/qemu/qemu/commit/6e131bf69b98fbe74cc02b5a910fa2dc5bb7962e
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M .gitlab-ci.d/edk2.yml
    M .gitlab-ci.d/opensbi.yml

  Log Message:
  -----------
  gitlab: honour QEMU_CI variable in edk2/opensbi jobs

To preserve contributor CI credits we don't want jobs to run by default
unless the QEMU_CI variable is set. For most jobs we can achieve this
using the base template, but the edk2/opensbi jobs are a little special
as they have some complex conditions we can't easily model in the base
template.

We duplicate existing rules and put them under control of QEMU_CI
variable, such that QEMU_CI=1 creates manual jobs and QEMU_CI=2
immediately runs jobs.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220629170638.520630-4-berrange@redhat.com>
[thuth: Fixed "on_success" <-> "manual" copy-n-paste bug]
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 3a751770ee687047230eca5f25ce3844b97cd713
      
https://github.com/qemu/qemu/commit/3a751770ee687047230eca5f25ce3844b97cd713
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M .gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml

  Log Message:
  -----------
  gitlab-ci: Extend timeout for ubuntu-20.04-s390x-all to 75m

Recent runs have been taking just over the 60m default.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220606182436.410053-1-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 276dfd03f00358ba904ca1954d3671f94949fbf6
      
https://github.com/qemu/qemu/commit/276dfd03f00358ba904ca1954d3671f94949fbf6
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M tests/qtest/migration-helpers.c

  Log Message:
  -----------
  tests: wait max 120 seconds for migration test status changes

Currently the wait_for_migration_fail and wait_for_migration_complete
functions will spin in an infinite loop checking query-migrate status
to detect a specific change/goal. This is fine when everything goes
to plan, but when the unusual happens, these will hang the test suite
forever.

Any normally executing migration test case normally takes < 1 second
for a state change, with exception of the autoconverge test which
takes about 5 seconds. Taking into account possibility of people
running tests inside TCG, allowing a factor of x20 slowdown gives
a reasonable worst case of 120 seconds. Anything taking longer than
this is a strong sign that the test has hung, or the test should be
rewritten to be faster.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20220628105434.295905-2-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 8d4e897a99089995128b78b3c3e61beb4a8e2f23
      
https://github.com/qemu/qemu/commit/8d4e897a99089995128b78b3c3e61beb4a8e2f23
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  tests: wait for migration completion before looking for STOP event

When moving into the convergance phase, the precopy tests will first
look for a STOP event and once found will look for migration completion
status. If the test VM is not converging, the test suite will be waiting
for the STOP event forever. If we wait for the migration completion
status first, then we will trigger the previously added timeout and
prevent the test hanging forever.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20220628105434.295905-3-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 6843ad8c034053487ca8755d13d18b7cc286b3d8
      
https://github.com/qemu/qemu/commit/6843ad8c034053487ca8755d13d18b7cc286b3d8
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  tests: increase migration test converge downtime to 30 seconds

While 1 second might be enough to converge migration on a fast host,
this is not guaranteed, especially if using TLS in the tests without
hardware accelerated crypto available.

Increasing the downtime to 30 seconds should guarantee it can converge
in any sane scenario.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20220628105434.295905-4-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 886dfe9db39ac9625dfa2da40b50a2e3534b5470
      
https://github.com/qemu/qemu/commit/886dfe9db39ac9625dfa2da40b50a2e3534b5470
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  tests: use consistent bandwidth/downtime limits in migration tests

The different migration test cases are using a variety of settings
to ensure convergance/non-convergance. Introduce two helpers to
extra the common functionality and ensure consistency.

  * Non-convergance: 1ms downtime, 30mbs bandwidth
  * Convergance: 30s downtime, 1gbs bandwidth

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20220628105434.295905-5-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 2116650254117a873ab316038803cef657ae2820
      
https://github.com/qemu/qemu/commit/2116650254117a873ab316038803cef657ae2820
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M MAINTAINERS
    M disas.c
    R disas/arm-a64.cc
    R disas/libvixl/LICENCE
    R disas/libvixl/README
    R disas/libvixl/meson.build
    R disas/libvixl/vixl/a64/assembler-a64.h
    R disas/libvixl/vixl/a64/constants-a64.h
    R disas/libvixl/vixl/a64/cpu-a64.h
    R disas/libvixl/vixl/a64/decoder-a64.cc
    R disas/libvixl/vixl/a64/decoder-a64.h
    R disas/libvixl/vixl/a64/disasm-a64.cc
    R disas/libvixl/vixl/a64/disasm-a64.h
    R disas/libvixl/vixl/a64/instructions-a64.cc
    R disas/libvixl/vixl/a64/instructions-a64.h
    R disas/libvixl/vixl/code-buffer.h
    R disas/libvixl/vixl/compiler-intrinsics.cc
    R disas/libvixl/vixl/compiler-intrinsics.h
    R disas/libvixl/vixl/globals.h
    R disas/libvixl/vixl/invalset.h
    R disas/libvixl/vixl/platform.h
    R disas/libvixl/vixl/utils.cc
    R disas/libvixl/vixl/utils.h
    M disas/meson.build
    M include/exec/poison.h
    M meson.build
    M scripts/clean-header-guards.pl
    M scripts/clean-includes
    M scripts/coverity-scan/COMPONENTS.md
    M target/arm/cpu.c

  Log Message:
  -----------
  disas: Remove libvixl disassembler

The disassembly via capstone should be superiour to our old vixl
sources nowadays, so let's finally cut this old disassembler out
of the QEMU source tree.

Message-Id: <20220603164249.112459-1-thuth@redhat.com>
Tested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 6d17020a808097a3587f6f9a36f0a5491871f091
      
https://github.com/qemu/qemu/commit/6d17020a808097a3587f6f9a36f0a5491871f091
  Author: Andrij Mizyk <andmizyk@gmail.com>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M po/LINGUAS
    A po/uk.po

  Log Message:
  -----------
  po: add ukrainian translation

Signed-off-by: Andrij Mizyk <andmizyk@gmail.com>
Message-Id: <20220613123758.13280-1-andmizyk@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 1ec8c2c01ed9c1b2bc8a273c7045e179f90013bc
      
https://github.com/qemu/qemu/commit/1ec8c2c01ed9c1b2bc8a273c7045e179f90013bc
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  meson.build: Require a recent version of libpng

According to https://gitlab.com/qemu-project/qemu/-/issues/1080#note_998088246
QEMU does not compile with older versions of libpng, so we should check
for a good version in meson.build. According to repology.org, our supported
host target operating systems ship these versions:

             Fedora 35: 1.6.37
     CentOS 8 (RHEL-8): 1.6.34
             Debian 11: 1.6.37
    OpenSUSE Leap 15.3: 1.6.34
      Ubuntu LTS 20.04: 1.6.37
         FreeBSD Ports: 1.6.37
         NetBSD pkgsrc: 1.6.37
         OpenBSD Ports: 1.6.37
              Homebrew: 1.6.37
           MSYS2 mingw: 1.6.37

So it seem reasonable to require at least libpng version 1.6.34 for
our builds.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1080
Message-Id: <20220623174941.531196-1-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 7a890b756620223f35f8056baddf0406526ae025
      
https://github.com/qemu/qemu/commit/7a890b756620223f35f8056baddf0406526ae025
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M include/qemu/host-utils.h

  Log Message:
  -----------
  include/qemu/host-utils: Remove unused code in the *_overflow wrappers

According to commit cec07c0b612975 the code in the #else paths was required
for GCC < 5.0 and Clang < 3.8. We don't support such old compilers
at all anymore, so we can remove these lines now. We keep the wrapper
function, though, since they are easier to read and help to make sure that
the parameters have the right types.

Message-Id: <20220701025132.303469-1-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: d82423a697790aac46680068ff64375cd12c6c94
      
https://github.com/qemu/qemu/commit/d82423a697790aac46680068ff64375cd12c6c94
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-07-05 (Tue, 05 Jul 2022)

  Changed paths:
    M .gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml
    M .gitlab-ci.d/edk2.yml
    M .gitlab-ci.d/opensbi.yml
    M MAINTAINERS
    M disas.c
    R disas/arm-a64.cc
    R disas/libvixl/LICENCE
    R disas/libvixl/README
    R disas/libvixl/meson.build
    R disas/libvixl/vixl/a64/assembler-a64.h
    R disas/libvixl/vixl/a64/constants-a64.h
    R disas/libvixl/vixl/a64/cpu-a64.h
    R disas/libvixl/vixl/a64/decoder-a64.cc
    R disas/libvixl/vixl/a64/decoder-a64.h
    R disas/libvixl/vixl/a64/disasm-a64.cc
    R disas/libvixl/vixl/a64/disasm-a64.h
    R disas/libvixl/vixl/a64/instructions-a64.cc
    R disas/libvixl/vixl/a64/instructions-a64.h
    R disas/libvixl/vixl/code-buffer.h
    R disas/libvixl/vixl/compiler-intrinsics.cc
    R disas/libvixl/vixl/compiler-intrinsics.h
    R disas/libvixl/vixl/globals.h
    R disas/libvixl/vixl/invalset.h
    R disas/libvixl/vixl/platform.h
    R disas/libvixl/vixl/utils.cc
    R disas/libvixl/vixl/utils.h
    M disas/meson.build
    M include/exec/poison.h
    M include/qemu/host-utils.h
    M meson.build
    M po/LINGUAS
    A po/uk.po
    M scripts/clean-header-guards.pl
    M scripts/clean-includes
    M scripts/coverity-scan/COMPONENTS.md
    M target/arm/cpu.c
    M tests/fp/meson.build
    M tests/qtest/migration-helpers.c
    M tests/qtest/migration-test.c
    M tests/unit/test-cutils.c

  Log Message:
  -----------
  Merge tag 'pull-request-2022-07-05' of https://gitlab.com/thuth/qemu into 
staging

* Fix memory leak in test-cutils
* Fix edk2/opensbi jobs to not run automatically by accident
* Improve timings in the migration qtest
* Remove libvixl disassembler
* Add ukrainian translation
* Require a recent version of libpng

# -----BEGIN PGP SIGNATURE-----
#
# iQJFBAABCAAvFiEEJ7iIR+7gJQEY8+q5LtnXdP5wLbUFAmLECEkRHHRodXRoQHJl
# ZGhhdC5jb20ACgkQLtnXdP5wLbV7lxAAmEItM6PIoW58eWPzReKVH8LE2w3UlvOZ
# JQhNgJjuN23fqjUVkcT0yCfdNCz/nKvafHnxfHQnrAXyB5V5vU8ovBgSuWK2mcmD
# NTFK+/2x5lcsyBrOe3QoeD2g1r7+Os3AYVkdnN/t2HAMLwQyaoshKaMV/UHC9O/i
# Kle1svYRNyCgyXJgxaOdbVMBSLi/L9h2R5AaG31GIi9wnf0n8HDH/ONtmeIpN09g
# BlMeZqPhGJT+tpMvviif65/Za57Y9h/r+TOgEIIs00cWmxqaBmcXXN9qog2s0n7A
# nOm3ck2lpGJCQ6+sl6/Mphyr3X6nWHsxGrLDElS0Ba5bg6T/Xqfg2pBcb81Klkjc
# QcTdFPiMxKUczgpFq326sqiaVzMgys4vwnW5iPSd5swNzrkYKADAIreki5jyM3cH
# lohBG/ruOmg5xMkX2K6pra0iOAeCz44Ku/HTREfY1CTUgEQZJY4SZrMJSnmUTnM+
# EQCkDcmOsnFDaQazneCbo18l37cXOgEhH8VoGAOqg1aRjr7TNlsJzx87PoD+9zNR
# GEh7kp18ABRGik5ZACdLQ/HhhOJa8+UWsGCwCdeBGv/TVug1Byz0OUG0PxX3X5SV
# WwubeKyZcqzoH92SQI3jZGSmuGBySy9q51T2k8FjZvaDsPiUN/MLPspNezH1qj2B
# W7qEaqIyGmo=
# =Q2vV
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 05 Jul 2022 03:15:45 PM +0530
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [undefined]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [undefined]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* tag 'pull-request-2022-07-05' of https://gitlab.com/thuth/qemu:
  include/qemu/host-utils: Remove unused code in the *_overflow wrappers
  meson.build: Require a recent version of libpng
  po: add ukrainian translation
  disas: Remove libvixl disassembler
  tests: use consistent bandwidth/downtime limits in migration tests
  tests: increase migration test converge downtime to 30 seconds
  tests: wait for migration completion before looking for STOP event
  tests: wait max 120 seconds for migration test status changes
  gitlab-ci: Extend timeout for ubuntu-20.04-s390x-all to 75m
  gitlab: honour QEMU_CI variable in edk2/opensbi jobs
  gitlab: tweak comments in edk2/opensbi jobs
  gitlab: normalize indentation in edk2/opensbi rules
  tests/fp: Do not build softfloat3 tests if TCG is disabled
  tests: fix test-cutils leaks

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/19361471b594...d82423a69779



reply via email to

[Prev in Thread] Current Thread [Next in Thread]