[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 694804: hw/qdev: Cosmetic around documentatio
|
From: |
Richard Henderson |
|
Subject: |
[Qemu-commits] [qemu/qemu] 694804: hw/qdev: Cosmetic around documentation |
|
Date: |
Fri, 31 Dec 2021 09:34:45 -0800 |
Branch: refs/heads/staging
Home: https://github.com/qemu/qemu
Commit: 694804ed7b26e66e114a2330887187d697a0d92b
https://github.com/qemu/qemu/commit/694804ed7b26e66e114a2330887187d697a0d92b
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M include/hw/qdev-core.h
Log Message:
-----------
hw/qdev: Cosmetic around documentation
Add empty lines to have a clearer distinction between different
functions declarations.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Message-Id: <20211218130437.1516929-2-f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Commit: 14b0375b39f4acbd2b313a37f5fdf886b0fe74cb
https://github.com/qemu/qemu/commit/14b0375b39f4acbd2b313a37f5fdf886b0fe74cb
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M include/hw/qdev-core.h
Log Message:
-----------
hw/qdev: Correct qdev_init_gpio_out_named() documentation
qdev_init_gpio_out_named() is described as qdev_init_gpio_out(),
and referring to itself in an endless loop, which is confusing. Fix.
Reported-by: Yanan Wang <wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Message-Id: <20211218130437.1516929-3-f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Commit: 1fbd004b00198fb3f27e52ce7b138b9c13288f78
https://github.com/qemu/qemu/commit/1fbd004b00198fb3f27e52ce7b138b9c13288f78
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M include/hw/qdev-core.h
Log Message:
-----------
hw/qdev: Correct qdev_connect_gpio_out_named() documentation
qdev_connect_gpio_out_named() is described as qdev_connect_gpio_out(),
and referring to itself in an endless loop, which is confusing. Fix.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Message-Id: <20211218130437.1516929-4-f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Commit: 2ebd9ce19a324aa627c3f9b8f40285a1cf9bb0c9
https://github.com/qemu/qemu/commit/2ebd9ce19a324aa627c3f9b8f40285a1cf9bb0c9
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M hw/core/gpio.c
M include/hw/qdev-core.h
Log Message:
-----------
hw/qdev: Rename qdev_connect_gpio_out*() 'input_pin' parameter
@pin is an input where we connect a device output.
Rename it @input_pin to simplify the documentation.
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20211218130437.1516929-5-f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Commit: 1ab192f30caeb7dd409fa82164ffa0df5e984a70
https://github.com/qemu/qemu/commit/1ab192f30caeb7dd409fa82164ffa0df5e984a70
Author: Philippe Mathieu-Daudé <philmd@redhat.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M tests/unit/test-smp-parse.c
Log Message:
-----------
tests/unit/test-smp-parse: Pass machine type as argument to tests
Use g_test_add_data_func() instead of g_test_add_func() so we can
pass the machine type to the tests (we will soon have different
machine types).
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211216132015.815493-2-philmd@redhat.com>
Commit: c30bdb025ce04f26ad63cbaebba911cff6573a52
https://github.com/qemu/qemu/commit/c30bdb025ce04f26ad63cbaebba911cff6573a52
Author: Philippe Mathieu-Daudé <philmd@redhat.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M tests/unit/test-smp-parse.c
Log Message:
-----------
tests/unit/test-smp-parse: Split the 'generic' test in valid / invalid
Split the 'generic' test in two tests: 'valid' and 'invalid'.
This will allow us to remove the hack which modifies the
MachineClass internal state.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211216132015.815493-3-philmd@redhat.com>
Commit: 76b6d4cce364ef841a3e2e3574322ca6d8a27414
https://github.com/qemu/qemu/commit/76b6d4cce364ef841a3e2e3574322ca6d8a27414
Author: Philippe Mathieu-Daudé <philmd@redhat.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M tests/unit/test-smp-parse.c
Log Message:
-----------
tests/unit/test-smp-parse: Add 'smp-with-dies' machine type
Avoid modifying the MachineClass internals by adding the
'smp-with-dies' machine, which inherits from TYPE_MACHINE.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Tested-by: Yanan Wang <wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211216132015.815493-4-philmd@redhat.com>
Commit: 7ca0705eba00c0d38f7b37670ee6cff9b607bb74
https://github.com/qemu/qemu/commit/7ca0705eba00c0d38f7b37670ee6cff9b607bb74
Author: Philippe Mathieu-Daudé <philmd@redhat.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M tests/unit/test-smp-parse.c
Log Message:
-----------
tests/unit/test-smp-parse: Add 'smp-generic-invalid' machine type
Avoid modifying the MachineClass internals by adding the
'smp-generic-invalid' machine, which inherits from TYPE_MACHINE.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Message-Id: <20211216132015.815493-5-philmd@redhat.com>
Commit: 2dc426c468833619afc1221666e0e6246b8f21d7
https://github.com/qemu/qemu/commit/2dc426c468833619afc1221666e0e6246b8f21d7
Author: Philippe Mathieu-Daudé <philmd@redhat.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M tests/unit/test-smp-parse.c
Log Message:
-----------
tests/unit/test-smp-parse: Add 'smp-generic-valid' machine type
Keep the common TYPE_MACHINE class initialization in
machine_base_class_init(), make it abstract, and move
the non-common code to a new class: "smp-generic-valid".
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Message-Id: <20211216132015.815493-6-philmd@redhat.com>
Commit: 47ab8a491ac62a884a42fb50ef3c7c7e0dac59d3
https://github.com/qemu/qemu/commit/47ab8a491ac62a884a42fb50ef3c7c7e0dac59d3
Author: Philippe Mathieu-Daudé <philmd@redhat.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M tests/unit/test-smp-parse.c
Log Message:
-----------
tests/unit/test-smp-parse: Simplify pointer to compound literal use
We can simply use a local variable (and pass its pointer) instead
of a pointer to a compound literal.
Reviewed-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Tested-by: Yanan Wang <wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211216132015.815493-7-philmd@redhat.com>
Commit: cf65000ae9884bc4bb36f2941568353ba405d966
https://github.com/qemu/qemu/commit/cf65000ae9884bc4bb36f2941568353ba405d966
Author: Philippe Mathieu-Daudé <philmd@redhat.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M tests/unit/test-smp-parse.c
Log Message:
-----------
tests/unit/test-smp-parse: Constify some pointer/struct
Declare structures const when we don't need to modify
them at runtime.
Reviewed-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Tested-by: Yanan Wang <wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211216132015.815493-8-philmd@redhat.com>
Commit: 3e2f14981c73f0cc009963512d63f2919efed5a1
https://github.com/qemu/qemu/commit/3e2f14981c73f0cc009963512d63f2919efed5a1
Author: Philippe Mathieu-Daudé <philmd@redhat.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M hw/core/machine-smp.c
M hw/core/machine.c
M include/hw/boards.h
M tests/unit/test-smp-parse.c
Log Message:
-----------
hw/core: Rename smp_parse() -> machine_parse_smp_config()
All methods related to MachineState are prefixed with "machine_".
smp_parse() does not need to be an exception. Rename it and
const'ify the SMPConfiguration argument, since it doesn't need
to be modified.
Reviewed-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Tested-by: Yanan Wang <wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211216132015.815493-9-philmd@redhat.com>
Commit: 0d8717852326db6deb4f10ab47d3458fb2b73529
https://github.com/qemu/qemu/commit/0d8717852326db6deb4f10ab47d3458fb2b73529
Author: Yanan Wang <wangyanan55@huawei.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M qemu-options.hx
Log Message:
-----------
qemu-options: Improve readability of SMP related Docs
We have a description in qemu-options.hx for each CPU topology
parameter to explain what it exactly means, and also an extra
declaration for the target-specific one, e.g. "for PC only"
when describing "dies", and "for PC, it's on one die" when
describing "cores".
Now we are going to introduce one more non-generic parameter
"clusters", it will make the Doc less readable and if we still
continue to use the legacy way to describe it.
So let's at first make two tweaks of the Docs to improve the
readability and also scalability:
1) In the -help text: Delete the extra specific declaration and
describe each topology parameter level by level. Then add a
note to declare that different machines may support different
subsets and the actual meaning of the supported parameters
will vary accordingly.
2) In the rST text: List all the sub-hierarchies currently
supported in QEMU, and correspondingly give an example of
-smp configuration for each of them.
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211228092221.21068-2-wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Commit: 864c3b5c32f02d3507e6a63bdb8a652803c4bd1b
https://github.com/qemu/qemu/commit/864c3b5c32f02d3507e6a63bdb8a652803c4bd1b
Author: Yanan Wang <wangyanan55@huawei.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M hw/core/machine-smp.c
M hw/core/machine.c
M include/hw/boards.h
M qapi/machine.json
M qemu-options.hx
M softmmu/vl.c
Log Message:
-----------
hw/core/machine: Introduce CPU cluster topology support
The new Cluster-Aware Scheduling support has landed in Linux 5.16,
which has been proved to benefit the scheduling performance (e.g.
load balance and wake_affine strategy) on both x86_64 and AArch64.
So now in Linux 5.16 we have four-level arch-neutral CPU topology
definition like below and a new scheduler level for clusters.
struct cpu_topology {
int thread_id;
int core_id;
int cluster_id;
int package_id;
int llc_id;
cpumask_t thread_sibling;
cpumask_t core_sibling;
cpumask_t cluster_sibling;
cpumask_t llc_sibling;
}
A cluster generally means a group of CPU cores which share L2 cache
or other mid-level resources, and it is the shared resources that
is used to improve scheduler's behavior. From the point of view of
the size range, it's between CPU die and CPU core. For example, on
some ARM64 Kunpeng servers, we have 6 clusters in each NUMA node,
and 4 CPU cores in each cluster. The 4 CPU cores share a separate
L2 cache and a L3 cache tag, which brings cache affinity advantage.
In virtualization, on the Hosts which have pClusters (physical
clusters), if we can design a vCPU topology with cluster level for
guest kernel and have a dedicated vCPU pinning. A Cluster-Aware
Guest kernel can also make use of the cache affinity of CPU clusters
to gain similar scheduling performance.
This patch adds infrastructure for CPU cluster level topology
configuration and parsing, so that the user can specify cluster
parameter if their machines support it.
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Message-Id: <20211228092221.21068-3-wangyanan55@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
[PMD: Added '(since 7.0)' to @clusters in qapi/machine.json]
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Commit: e5ef89ae44f6720e32dc4f516b2e997d2377f08a
https://github.com/qemu/qemu/commit/e5ef89ae44f6720e32dc4f516b2e997d2377f08a
Author: Yanan Wang <wangyanan55@huawei.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M tests/unit/test-smp-parse.c
Log Message:
-----------
tests/unit/test-smp-parse: Add testcases for CPU clusters
Add testcases for parsing of the four-level CPU topology hierarchy,
ie sockets/clusters/cores/threads, which will be supported on ARM
virt machines.
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211228092221.21068-5-wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Commit: 16f573847697038fae6657e2ed84ad2e1c4786ad
https://github.com/qemu/qemu/commit/16f573847697038fae6657e2ed84ad2e1c4786ad
Author: Yanan Wang <wangyanan55@huawei.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M tests/unit/test-smp-parse.c
Log Message:
-----------
tests/unit/test-smp-parse: No need to explicitly zero MachineClass members
The default value of the MachineClass members is 0, which
means we don't have to explicitly zero them. Also the value
of "mc->smp_props.prefer_sockets" will be taken care of by
smp_parse_test(), we don't necessarily need the statement
in machine_base_class_init() either.
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211228092221.21068-6-wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Commit: a2348fa23247f565ef0b0fcc5679b2a6d5c3acf6
https://github.com/qemu/qemu/commit/a2348fa23247f565ef0b0fcc5679b2a6d5c3acf6
Author: Yanan Wang <wangyanan55@huawei.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M tests/unit/test-smp-parse.c
Log Message:
-----------
tests/unit/test-smp-parse: Keep default MIN/MAX CPUs in
machine_base_class_init
Most machine types in test-smp-parse will be OK to have the default
MIN/MAX CPUs except "smp-generic-invalid", let's keep the default
values in machine_base_class_init which will be inherited. And if
we hope a different value for a specific machine, modify it in its
own initialization function.
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211228092221.21068-7-wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Commit: da7595cad36fd8db17a0e812f656ee163bfa6701
https://github.com/qemu/qemu/commit/da7595cad36fd8db17a0e812f656ee163bfa6701
Author: Yanan Wang <wangyanan55@huawei.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M MAINTAINERS
Log Message:
-----------
MAINTAINERS: Self-recommended as reviewer of "Machine core"
I've built interests in the generic machine subsystem and
have also been working on projects related to this part,
self-recommand myself as a reviewer so that I can help to
review some patches familiar to me, and have a chance to
learn more continuously.
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211228092221.21068-8-wangyanan55@huawei.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Commit: 90f285fd8370f404a376adb63f1555a667689745
https://github.com/qemu/qemu/commit/90f285fd8370f404a376adb63f1555a667689745
Author: Philippe Mathieu-Daudé <philmd@redhat.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M .gitlab-ci.d/edk2/Dockerfile
M .mailmap
M MAINTAINERS
Log Message:
-----------
MAINTAINERS: Change philmd's email address
The philmd@redhat.com email address will stop working on
2022-01-01, change it to my personal email address.
Update .mailmap in case anyone wants to send me an email
because of some past commit I authored.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211231000759.707519-1-philmd@redhat.com>
Commit: 2ece6e64846e1929c4ed338c73328d3b126e48d3
https://github.com/qemu/qemu/commit/2ece6e64846e1929c4ed338c73328d3b126e48d3
Author: Li Zhijian <lizhijian@cn.fujitsu.com>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M MAINTAINERS
Log Message:
-----------
MAINTAINERS: email address change
Fujitsu's mail service has migrated to O365 months ago, the
lizhijian@cn.fujitsu.com address will stop working on 2022-06-01,
change it to my new email address lizhijian@fujitsu.com.
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
Acked-by: Zhang Chen <chen.zhang@intel.com>
Message-Id: <20211231050901.360-1-lizhijian@cn.fujitsu.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Commit: 814a0505302d6af277557f10f88d3639eff7a547
https://github.com/qemu/qemu/commit/814a0505302d6af277557f10f88d3639eff7a547
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-12-31 (Fri, 31 Dec 2021)
Changed paths:
M .gitlab-ci.d/edk2/Dockerfile
M .mailmap
M MAINTAINERS
M hw/core/gpio.c
M hw/core/machine-smp.c
M hw/core/machine.c
M include/hw/boards.h
M include/hw/qdev-core.h
M qapi/machine.json
M qemu-options.hx
M softmmu/vl.c
M tests/unit/test-smp-parse.c
Log Message:
-----------
Merge tag 'machine-core-20211231' of https://github.com/philmd/qemu into
staging
Machine core patches
- Clarify qdev_connect_gpio_out() documentation
- Rework test-smp-parse tests following QOM style
- Introduce CPU cluster topology support (Yanan Wang)
- MAINTAINERS updates (Yanan Wang, Li Zhijian, myself)
# gpg: Signature made Fri 31 Dec 2021 04:45:35 AM PST
# gpg: using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE
# gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) <f4bug@amsat.org>"
[full]
* tag 'machine-core-20211231' of https://github.com/philmd/qemu:
MAINTAINERS: email address change
MAINTAINERS: Change philmd's email address
MAINTAINERS: Self-recommended as reviewer of "Machine core"
tests/unit/test-smp-parse: Keep default MIN/MAX CPUs in
machine_base_class_init
tests/unit/test-smp-parse: No need to explicitly zero MachineClass members
tests/unit/test-smp-parse: Add testcases for CPU clusters
hw/core/machine: Introduce CPU cluster topology support
qemu-options: Improve readability of SMP related Docs
hw/core: Rename smp_parse() -> machine_parse_smp_config()
tests/unit/test-smp-parse: Constify some pointer/struct
tests/unit/test-smp-parse: Simplify pointer to compound literal use
tests/unit/test-smp-parse: Add 'smp-generic-valid' machine type
tests/unit/test-smp-parse: Add 'smp-generic-invalid' machine type
tests/unit/test-smp-parse: Add 'smp-with-dies' machine type
tests/unit/test-smp-parse: Split the 'generic' test in valid / invalid
tests/unit/test-smp-parse: Pass machine type as argument to tests
hw/qdev: Rename qdev_connect_gpio_out*() 'input_pin' parameter
hw/qdev: Correct qdev_connect_gpio_out_named() documentation
hw/qdev: Correct qdev_init_gpio_out_named() documentation
hw/qdev: Cosmetic around documentation
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Compare: https://github.com/qemu/qemu/compare/69f153667fce...814a0505302d
- [Qemu-commits] [qemu/qemu] 694804: hw/qdev: Cosmetic around documentation,
Richard Henderson <=