qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 14554b: pmu: fix pmu vmstate subsection list


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] 14554b: pmu: fix pmu vmstate subsection list
Date: Fri, 19 Nov 2021 06:25:06 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 14554b3dccae18ddc58d39654443c8e4551252c9
      
https://github.com/qemu/qemu/commit/14554b3dccae18ddc58d39654443c8e4551252c9
  Author: Laurent Vivier <lvivier@redhat.com>
  Date:   2021-11-17 (Wed, 17 Nov 2021)

  Changed paths:
    M hw/misc/macio/pmu.c

  Log Message:
  -----------
  pmu: fix pmu vmstate subsection list

The subsection is not closed by a NULL marker so this can trigger
a segfault when the pmu vmstate is saved.

This can be easily shown with:

  $ ./qemu-system-ppc64  -dump-vmstate vmstate.json
  Segmentation fault (core dumped)

Fixes: d811d61fbc6c ("mac_newworld: add PMU device")
Cc: mark.cave-ayland@ilande.co.uk
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Cédric Le Goater <clg@kaod.org>


  Commit: a443d55c3f7cafa3d5dfb7fe2b5c3cd9d671b61d
      
https://github.com/qemu/qemu/commit/a443d55c3f7cafa3d5dfb7fe2b5c3cd9d671b61d
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2021-11-17 (Wed, 17 Nov 2021)

  Changed paths:
    M tests/tcg/ppc64le/Makefile.target

  Log Message:
  -----------
  tests/tcg/ppc64le: Fix compile flags for byte_reverse

With a host compiler new enough to recognize power10 insns,
CROSS_CC_HAS_POWER10 is true, but we do not supply the -cpu
option to the compiler, resulting in

/tmp/ccAVdYJd.s: Assembler messages:
/tmp/ccAVdYJd.s:49: Error: unrecognized opcode: `brh'
/tmp/ccAVdYJd.s:78: Error: unrecognized opcode: `brw'
/tmp/ccAVdYJd.s:107: Error: unrecognized opcode: `brd'
make[2]: *** [byte_reverse] Error 1

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>


  Commit: d434a47905641433e16ef65356d17090fd6fdcb1
      
https://github.com/qemu/qemu/commit/d434a47905641433e16ef65356d17090fd6fdcb1
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2021-11-19 (Fri, 19 Nov 2021)

  Changed paths:
    M hw/misc/macio/pmu.c
    M tests/tcg/ppc64le/Makefile.target

  Log Message:
  -----------
  Merge tag 'pull-ppc-20211119' of https://github.com/legoater/qemu into staging

ppc 6.2 queue:

* fix pmu vmstate
* Fix compile of byte_reverse on new compilers

# gpg: Signature made Fri 19 Nov 2021 12:49:30 PM CET
# gpg:                using RSA key A0F66548F04895EBFE6B0B6051A343C7CFFBECA1
# gpg: Good signature from "Cédric Le Goater <clg@kaod.org>" [marginal]
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: A0F6 6548 F048 95EB FE6B  0B60 51A3 43C7 CFFB ECA1

* tag 'pull-ppc-20211119' of https://github.com/legoater/qemu:
  tests/tcg/ppc64le: Fix compile flags for byte_reverse
  pmu: fix pmu vmstate subsection list

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/9c25e1db18d8...d434a4790564



reply via email to

[Prev in Thread] Current Thread [Next in Thread]