qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] b3793b: hw/sh4: Coding style: Remove tabs


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] b3793b: hw/sh4: Coding style: Remove tabs
Date: Sat, 30 Oct 2021 13:12:54 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b3793b8a9183d6019f557263bbddd647e1918394
      
https://github.com/qemu/qemu/commit/b3793b8a9183d6019f557263bbddd647e1918394
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/intc/sh_intc.c
    M hw/sh4/r2d.c
    M hw/sh4/sh7750.c
    M hw/sh4/sh7750_regnames.c
    M hw/sh4/sh7750_regs.h
    M include/hw/sh4/sh.h

  Log Message:
  -----------
  hw/sh4: Coding style: Remove tabs

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: 
<2d9b2c470ec022cc85a25b3e5de337b5e794f7f6.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 221389657aa77ced7a17936747f288193e321d3f
      
https://github.com/qemu/qemu/commit/221389657aa77ced7a17936747f288193e321d3f
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/char/sh_serial.c
    M hw/intc/sh_intc.c
    M hw/sh4/r2d.c
    M hw/sh4/sh7750.c
    M hw/sh4/sh7750_regs.h
    M hw/sh4/shix.c
    M hw/timer/sh_timer.c

  Log Message:
  -----------
  hw/sh4: Coding style: Fix multi-line comments

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: 
<3f192c699f4e5949ec0fcc436e5610f50afe2dbf.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: f94bff1337ff525e2ff458b8e4cd57f9561acde3
      
https://github.com/qemu/qemu/commit/f94bff1337ff525e2ff458b8e4cd57f9561acde3
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/char/sh_serial.c
    M hw/intc/sh_intc.c
    M hw/pci-host/sh_pci.c
    M hw/sh4/r2d.c
    M hw/sh4/sh7750.c
    M hw/sh4/sh7750_regnames.c
    M hw/sh4/sh7750_regs.h
    M hw/sh4/shix.c
    M hw/timer/sh_timer.c
    M include/hw/sh4/sh.h

  Log Message:
  -----------
  hw/sh4: Coding style: White space fixes

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: 
<91698c54fa493a4cfe93546211206439787d4b78.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: ac3c9e74c1ee1071e5be692a611c5ee261b9b581
      
https://github.com/qemu/qemu/commit/ac3c9e74c1ee1071e5be692a611c5ee261b9b581
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/char/sh_serial.c
    M hw/intc/sh_intc.c
    M hw/sh4/r2d.c
    M hw/sh4/sh7750.c
    M hw/sh4/sh7750_regnames.c
    M hw/timer/sh_timer.c

  Log Message:
  -----------
  hw/sh4: Coding style: Add missing braces

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: 
<b53a8cbcf57207fbd6408db1007b3e82008d60f7.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 373b96b9c6d77a54a52239b422a44958d9dcc67e
      
https://github.com/qemu/qemu/commit/373b96b9c6d77a54a52239b422a44958d9dcc67e
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/timer/sh_timer.c

  Log Message:
  -----------
  hw/sh4: Coding style: Remove unnecessary casts

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: 
<6cb1bcf24572ad8465c20b64fec81157f34bcbe9.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 3b885dabd09f449143adbfc0595896b47648673d
      
https://github.com/qemu/qemu/commit/3b885dabd09f449143adbfc0595896b47648673d
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/timer/sh_timer.c

  Log Message:
  -----------
  hw/sh4: Fix typos in a comment

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<a84405db64ef81bff1a16526da290cc68f1444db.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: ad52cfc13750662fd003565e8035bb8ffbd4f0ef
      
https://github.com/qemu/qemu/commit/ad52cfc13750662fd003565e8035bb8ffbd4f0ef
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/char/sh_serial.c
    M hw/char/trace-events
    M hw/intc/sh_intc.c
    M hw/intc/trace-events
    M hw/sh4/sh7750.c
    A hw/sh4/trace-events
    A hw/sh4/trace.h
    M hw/timer/sh_timer.c
    M hw/timer/trace-events
    M meson.build

  Log Message:
  -----------
  hw/sh4: Change debug printfs to traces

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: 
<b776043e811ab3caf200515e1350bdcccd1cc47b.1635541329.git.balaton@eik.bme.hu>
[PMD: Fixed format strings for 32-bit hosts]
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 6e5dd76f213afc3fdf07ddebe3fed3980228f71b
      
https://github.com/qemu/qemu/commit/6e5dd76f213afc3fdf07ddebe3fed3980228f71b
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/sh4/r2d.c

  Log Message:
  -----------
  hw/sh4/r2d: Use error_report instead of fprintf to stderr

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<7f320ab72f3d4d43cd62925230a9f83583413f67.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 3cf7ce4337aebf8f9148ee53033710b4c4b00f01
      
https://github.com/qemu/qemu/commit/3cf7ce4337aebf8f9148ee53033710b4c4b00f01
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/char/sh_serial.c

  Log Message:
  -----------
  hw/char/sh_serial: Do not abort on invalid access

Replace fprintf with qemu_log_mask LOG_GUEST_ERROR as the intention is
to handle valid accesses in these functions so if we get to these
errors then it's an invalid access. Do not abort as that would allow
the guest to crash QEMU and the practice in other devices is to not do
that just log and ignore the invalid access. While at it also simplify
the complex bit ops to check if a return value was set which can be
done much simpler and clearer.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<6b46045141d6d9cc32e17c223896fa1116384796.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 2f6df13748a7de19ab150a52af846f70303746e5
      
https://github.com/qemu/qemu/commit/2f6df13748a7de19ab150a52af846f70303746e5
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/char/sh_serial.c

  Log Message:
  -----------
  hw/char/sh_serial: Rename type sh_serial_state to SHSerialState

Coding style says types should be camel case.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: 
<0f185653528c99eeeb2b4e4afb8b818d93298c20.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 5b344b02e1813c6823e76ea981a56e7b432985a4
      
https://github.com/qemu/qemu/commit/5b344b02e1813c6823e76ea981a56e7b432985a4
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/char/sh_serial.c

  Log Message:
  -----------
  hw/char/sh_serial: Embed QEMUTimer in state struct

Instead of allocating timer with timer_new store it directly in the
state struct. This makes it simpler to free it together with the device.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<fd01eb3720ec32dab06e03019f72f3e177033679.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 017f77bbf75ef6c9b69188a150020013e6d5d8ad
      
https://github.com/qemu/qemu/commit/017f77bbf75ef6c9b69188a150020013e6d5d8ad
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/char/sh_serial.c

  Log Message:
  -----------
  hw/char/sh_serial: Split off sh_serial_reset() from sh_serial_init()

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<ffb46f2814794c8dfc2c5a0cf83086a7bd754e10.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: beeb520925d54f5c69c66656a96dc68de0eec9a4
      
https://github.com/qemu/qemu/commit/beeb520925d54f5c69c66656a96dc68de0eec9a4
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/char/sh_serial.c
    M hw/sh4/sh7750.c
    M include/hw/sh4/sh.h

  Log Message:
  -----------
  hw/char/sh_serial: QOM-ify

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<92902ba34fdf2c8c62232365fbb6531b1036d557.1635541329.git.balaton@eik.bme.hu>
[PMD: Use g_strdup() to initialize DeviceState::id]
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 44ae04f0328d0726c1b1666600d0aa8da604a341
      
https://github.com/qemu/qemu/commit/44ae04f0328d0726c1b1666600d0aa8da604a341
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/char/sh_serial.c
    M hw/char/trace-events

  Log Message:
  -----------
  hw/char/sh_serial: Add device id to trace output

Normally there are at least two sh_serial instances. Add device id to
trace messages to make it clear which instance they belong to
otherwise its not possible to tell which serial device is accessed.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: 
<cc1f9ff9f4259ae799750e452f8871849c7a104c.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: cfaf2806e87b0eb962866e041a0fd75a524394d8
      
https://github.com/qemu/qemu/commit/cfaf2806e87b0eb962866e041a0fd75a524394d8
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/intc/sh_intc.c

  Log Message:
  -----------
  hw/intc/sh_intc: Use existing macro instead of local one

The INTC_A7 local macro does the same as the A7ADDR from
include/sh/sh.h so use the latter and drop the local macro definition.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: 
<53f033477c73b7c9b021d36033c590416d6199c7.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: dc6f1734b704e5563e4c512393e2629799093681
      
https://github.com/qemu/qemu/commit/dc6f1734b704e5563e4c512393e2629799093681
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/intc/sh_intc.c

  Log Message:
  -----------
  hw/intc/sh_intc: Turn some defines into an enum

Turn the INTC_MODE defines into an enum and clean up the function
returning these to make it clearer by removing nested ifs and
superfluous parenthesis. The one remaining #define is a flag which is
moved further apart by changing its value from 8 to 0x80 to leave some
spare bits as this is or-ed with the enum value at some places.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: 
<4adf4e1ac9d2e728e5a536c69e310d77f0c4455a.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 81d18cd48a87205bed159586fd3ca524a36bd49a
      
https://github.com/qemu/qemu/commit/81d18cd48a87205bed159586fd3ca524a36bd49a
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/intc/sh_intc.c

  Log Message:
  -----------
  hw/intc/sh_intc: Rename iomem region

Rename the iomem region to "intc" from "interrupt-controller" which
makes the info mtree output less wide as it is already too wide
because of all the aliases. Also drop the format macro which was only
used twice in close proximity so we can just use the literal string
instead without a macro definition.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<cb6402dab6b44c804142b5cf9af68e6398cb613f.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 92d1d3ada11dfb338bb96b6405d6938901182488
      
https://github.com/qemu/qemu/commit/92d1d3ada11dfb338bb96b6405d6938901182488
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/intc/sh_intc.c

  Log Message:
  -----------
  hw/intc/sh_intc: Drop another useless macro

The INT_REG_PARAMS macro was only used a few times within one function
on adjacent lines and is actually more complex than writing out the
parameters so simplify it by expanding the macro at call sites and
dropping the #define.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: 
<d3bdfdc5ab5ae1c51a6c6c38bde3829a99f85ce5.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 51cb902baca1ccfba270fa5a1f230d85301a68e6
      
https://github.com/qemu/qemu/commit/51cb902baca1ccfba270fa5a1f230d85301a68e6
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/intc/sh_intc.c

  Log Message:
  -----------
  hw/intc/sh_intc: Move sh_intc_register() closer to its only user

The sh_intc_register() function is only used at one place. Move them
together so it's easier to see what's going on.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<49f2742bc67cba7164385fafad204ab1e1bd3a0b.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 46ea1f8236ffdf80c52dad79ee7d2dc18ed5eda1
      
https://github.com/qemu/qemu/commit/46ea1f8236ffdf80c52dad79ee7d2dc18ed5eda1
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/intc/sh_intc.c

  Log Message:
  -----------
  hw/intc/sh_intc: Remove excessive parenthesis

Drop unneded parenthesis and split up one complex expression to write
it with less brackets so it's easier to follow.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<a48e849e5b803a952ed15a2502cfece2bde68934.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 12201fe38a592695eea647c9600d08a4622c1431
      
https://github.com/qemu/qemu/commit/12201fe38a592695eea647c9600d08a4622c1431
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/intc/sh_intc.c

  Log Message:
  -----------
  hw/intc/sh_intc: Use array index instead of pointer arithmetics

Address of element i is one word thus clearer than array + i.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<f49c9b1dee1fcaf374b092d862a6821907d5fcdc.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 9b12fb10b731d8d9cbb6cc0bf200d1c48de7f20d
      
https://github.com/qemu/qemu/commit/9b12fb10b731d8d9cbb6cc0bf200d1c48de7f20d
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/intc/sh_intc.c
    M hw/sh4/sh7750.c
    M include/hw/sh4/sh_intc.h

  Log Message:
  -----------
  hw/intc/sh_intc: Inline and drop sh_intc_source() function

This function is very simple and provides no advantage. Call sites
become simpler without it so just write it in line and drop the
separate function.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<a98d1f7f94e91a42796b7d91e9153a7eaa3d1c44.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 85208f7a9756948ed16ef09d7982584528904430
      
https://github.com/qemu/qemu/commit/85208f7a9756948ed16ef09d7982584528904430
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/intc/sh_intc.c

  Log Message:
  -----------
  hw/intc/sh_intc: Replace abort() with g_assert_not_reached()

All the places that call abort should not happen which is better
marked by g_assert_not_reached.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<039e6a784532f2af27f8adeafdb8e0391722f567.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 418a221c2b8a97838980e61cdfef356ec6976e4b
      
https://github.com/qemu/qemu/commit/418a221c2b8a97838980e61cdfef356ec6976e4b
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/intc/sh_intc.c

  Log Message:
  -----------
  hw/intc/sh_intc: Avoid using continue in loops

Instead of if !expr continue else do something it is more straight
forward to say if expr then do something, especially if the action is
just a few lines. Remove such uses of continue to make the code easier
to follow.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: 
<0efaa5e7a1a3ee11f82b3bb1942c287576c67f8b.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 36cf5ee8852a3aac56be160ad87cc49974278c46
      
https://github.com/qemu/qemu/commit/36cf5ee8852a3aac56be160ad87cc49974278c46
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/intc/sh_intc.c

  Log Message:
  -----------
  hw/intc/sh_intc: Simplify allocating sources array

Use g_new0 instead of g_malloc0 and avoid some unneeded temporary
variable assignments.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<72efc4f2c4ff8b96848d03dca08e4541ee4076f6.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 32331787896104022deb024906f1cca9606cfdc6
      
https://github.com/qemu/qemu/commit/32331787896104022deb024906f1cca9606cfdc6
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/intc/sh_intc.c

  Log Message:
  -----------
  hw/intc/sh_intc: Remove unneeded local variable initialisers

The sh_intc_locate function will either init these or not return so no
need to initialise them.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<15e04aa665c68ab5df47bbf505346d413be2fc1c.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 5d9b737e5144baff1c3a4205ff57d974a347c204
      
https://github.com/qemu/qemu/commit/5d9b737e5144baff1c3a4205ff57d974a347c204
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/timer/sh_timer.c

  Log Message:
  -----------
  hw/timer/sh_timer: Rename sh_timer_state to SHTimerState

According to coding style types should be camel case, also remove
unneded casts from void *.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<d9a9d160c1153a583397e366ab06477f5a31c507.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: f64ccec414e72754921c25de6395d7e3b10a0c9e
      
https://github.com/qemu/qemu/commit/f64ccec414e72754921c25de6395d7e3b10a0c9e
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/timer/sh_timer.c

  Log Message:
  -----------
  hw/timer/sh_timer: Do not wrap lines that are not too long

It's more readable to keep things on one line if it fits the length limit.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<97bc2a38991f33fd0c8cc2e4d0a3a29b20c47d1f.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 65307c7792a50bffe036423ec21107f4fb9c74e3
      
https://github.com/qemu/qemu/commit/65307c7792a50bffe036423ec21107f4fb9c74e3
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/timer/sh_timer.c

  Log Message:
  -----------
  hw/timer/sh_timer: Fix timer memory region size

The timer unit only has registers that fit in a region 0x30 bytes
long. No need to have the timer region larger than that.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<b1cd196cf1395a602c7a08a4f858e69e50c446a1.1635550060.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 46e44759fc24a05e338cd37a735b4aad5422e717
      
https://github.com/qemu/qemu/commit/46e44759fc24a05e338cd37a735b4aad5422e717
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/timer/sh_timer.c

  Log Message:
  -----------
  hw/timer/sh_timer: Remove use of hw_error

The hw_error function calls abort and is not meant to be used by
devices. Use qemu_log_mask instead to log and ignore invalid accesses.
Also fix format strings to allow dropping type casts of hwaddr and use
__func__ instead of hard coding function name in the message which
were wrong in two cases.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<f818dc3dd2ac8c3b3d53067f316a716d7f9683d8.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: af531756d25541a1b3b3d9a14e72e7fedd941a2e
      
https://github.com/qemu/qemu/commit/af531756d25541a1b3b3d9a14e72e7fedd941a2e
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M hw/char/sh_serial.c
    M hw/char/trace-events
    M hw/intc/sh_intc.c
    M hw/intc/trace-events
    M hw/pci-host/sh_pci.c
    M hw/sh4/r2d.c
    M hw/sh4/sh7750.c
    M hw/sh4/sh7750_regnames.c
    M hw/sh4/sh7750_regs.h
    M hw/sh4/shix.c
    A hw/sh4/trace-events
    A hw/sh4/trace.h
    M hw/timer/sh_timer.c
    M hw/timer/trace-events
    M include/hw/sh4/sh.h
    M include/hw/sh4/sh_intc.h
    M meson.build

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/philmd/tags/renesas-20211030' into 
staging

Renesas SH-4 patches queue

Patches from Zoltan:
- Various clean up to align the code style with the rest of the code base
- QOM'ify the SH_SERIAL device
- Modify few memory region size to better match the hardware manual

# gpg: Signature made Sat 30 Oct 2021 10:05:03 AM PDT
# gpg:                using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE
# gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) <f4bug@amsat.org>" 
[full]

* remotes/philmd/tags/renesas-20211030: (30 commits)
  hw/timer/sh_timer: Remove use of hw_error
  hw/timer/sh_timer: Fix timer memory region size
  hw/timer/sh_timer: Do not wrap lines that are not too long
  hw/timer/sh_timer: Rename sh_timer_state to SHTimerState
  hw/intc/sh_intc: Remove unneeded local variable initialisers
  hw/intc/sh_intc: Simplify allocating sources array
  hw/intc/sh_intc: Avoid using continue in loops
  hw/intc/sh_intc: Replace abort() with g_assert_not_reached()
  hw/intc/sh_intc: Inline and drop sh_intc_source() function
  hw/intc/sh_intc: Use array index instead of pointer arithmetics
  hw/intc/sh_intc: Remove excessive parenthesis
  hw/intc/sh_intc: Move sh_intc_register() closer to its only user
  hw/intc/sh_intc: Drop another useless macro
  hw/intc/sh_intc: Rename iomem region
  hw/intc/sh_intc: Turn some defines into an enum
  hw/intc/sh_intc: Use existing macro instead of local one
  hw/char/sh_serial: Add device id to trace output
  hw/char/sh_serial: QOM-ify
  hw/char/sh_serial: Split off sh_serial_reset() from sh_serial_init()
  hw/char/sh_serial: Embed QEMUTimer in state struct
  ...

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/dd61b91c080c...af531756d255



reply via email to

[Prev in Thread] Current Thread [Next in Thread]