[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] c9460d: accel/tcg: Handle gdb singlestep in c
From: |
Richard Henderson |
Subject: |
[Qemu-commits] [qemu/qemu] c9460d: accel/tcg: Handle gdb singlestep in cpu_tb_exec |
Date: |
Sat, 16 Oct 2021 11:17:24 -0700 |
Branch: refs/heads/staging
Home: https://github.com/qemu/qemu
Commit: c9460d75c59fc6b6f110156e4c1035e9ae9bd611
https://github.com/qemu/qemu/commit/c9460d75c59fc6b6f110156e4c1035e9ae9bd611
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M accel/tcg/cpu-exec.c
Log Message:
-----------
accel/tcg: Handle gdb singlestep in cpu_tb_exec
Currently the change in cpu_tb_exec is masked by the debug exception
being raised by the translators. But this allows us to remove that code.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 1760e4abf11223535b92e25a7fbd928b29b57233
https://github.com/qemu/qemu/commit/1760e4abf11223535b92e25a7fbd928b29b57233
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/alpha/translate.c
Log Message:
-----------
target/alpha: Drop checks for singlestep_enabled
GDB single-stepping is now handled generically.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: a893daa936161b8f45b2567875922343e388de9c
https://github.com/qemu/qemu/commit/a893daa936161b8f45b2567875922343e388de9c
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/avr/translate.c
Log Message:
-----------
target/avr: Drop checks for singlestep_enabled
GDB single-stepping is now handled generically.
Tested-by: Michael Rolnik <mrolnik@gmail.com>
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: e3774881b5b651da7b44e5e98c5c8cea610e35bc
https://github.com/qemu/qemu/commit/e3774881b5b651da7b44e5e98c5c8cea610e35bc
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/cris/translate.c
Log Message:
-----------
target/cris: Drop checks for singlestep_enabled
GDB single-stepping is now handled generically.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: db07bd026ee6f5ea4fe32c503645813252bae2c6
https://github.com/qemu/qemu/commit/db07bd026ee6f5ea4fe32c503645813252bae2c6
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/hexagon/translate.c
Log Message:
-----------
target/hexagon: Drop checks for singlestep_enabled
GDB single-stepping is now handled generically.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 364caea70f965a4fc81395863a3bae6bc16ce240
https://github.com/qemu/qemu/commit/364caea70f965a4fc81395863a3bae6bc16ce240
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/arm/translate-a64.c
M target/arm/translate.c
Log Message:
-----------
target/arm: Drop checks for singlestep_enabled
GDB single-stepping is now handled generically.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 8532a14e413b3395c3ee2f13285462259858f433
https://github.com/qemu/qemu/commit/8532a14e413b3395c3ee2f13285462259858f433
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/hppa/translate.c
Log Message:
-----------
target/hppa: Drop checks for singlestep_enabled
GDB single-stepping is now handled generically.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 9ef6c6ec08b8ecd89a797fa6819b0c1d121e24d7
https://github.com/qemu/qemu/commit/9ef6c6ec08b8ecd89a797fa6819b0c1d121e24d7
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/i386/tcg/translate.c
Log Message:
-----------
target/i386: Check CF_NO_GOTO_TB for dc->jmp_opt
We were using singlestep_enabled as a proxy for whether
translator_use_goto_tb would always return false.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 4bc4c3135be4b258ae8143b1f8982fe76cba460a
https://github.com/qemu/qemu/commit/4bc4c3135be4b258ae8143b1f8982fe76cba460a
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/i386/helper.h
M target/i386/tcg/misc_helper.c
M target/i386/tcg/translate.c
Log Message:
-----------
target/i386: Drop check for singlestep_enabled
GDB single-stepping is now handled generically.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 661da0f63f973b84755423ae9e919582ff330a0c
https://github.com/qemu/qemu/commit/661da0f63f973b84755423ae9e919582ff330a0c
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/m68k/translate.c
Log Message:
-----------
target/m68k: Drop checks for singlestep_enabled
GDB single-stepping is now handled generically.
Acked-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: fbafb3a4d2fc90efdba05ec0d1f2ad7c4f68e9a5
https://github.com/qemu/qemu/commit/fbafb3a4d2fc90efdba05ec0d1f2ad7c4f68e9a5
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/microblaze/translate.c
Log Message:
-----------
target/microblaze: Check CF_NO_GOTO_TB for DISAS_JUMP
We were using singlestep_enabled as a proxy for whether
translator_use_goto_tb would always return false.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 66345580255f4a9f382cb9e8321a2590025eb1b4
https://github.com/qemu/qemu/commit/66345580255f4a9f382cb9e8321a2590025eb1b4
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/microblaze/translate.c
Log Message:
-----------
target/microblaze: Drop checks for singlestep_enabled
GDB single-stepping is now handled generically.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: ef00cd4a22701923583862c48448b43bbcdaca0f
https://github.com/qemu/qemu/commit/ef00cd4a22701923583862c48448b43bbcdaca0f
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/mips/tcg/translate.c
Log Message:
-----------
target/mips: Fix single stepping
As per an ancient comment in mips_tr_translate_insn about the
expectations of gdb, when restarting the insn in a delay slot
we also re-execute the branch. Which means that we are
expected to execute two insns in this case.
This has been broken since 8b86d6d2580, where we forced max_insns
to 1 while single-stepping. This resulted in an exit from the
translator loop after the branch but before the delay slot is
translated.
Increase the max_insns to 2 for this case. In addition, bypass
the end-of-page check, for when the branch itself ends the page.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 1a79c413999e241bbc24487b4db08faec2493c9d
https://github.com/qemu/qemu/commit/1a79c413999e241bbc24487b4db08faec2493c9d
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/mips/tcg/translate.c
Log Message:
-----------
target/mips: Drop exit checks for singlestep_enabled
GDB single-stepping is now handled generically.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: b21fce536c5e673b1f3faab6db9bd7a7aec88cc1
https://github.com/qemu/qemu/commit/b21fce536c5e673b1f3faab6db9bd7a7aec88cc1
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/openrisc/translate.c
Log Message:
-----------
target/openrisc: Drop checks for singlestep_enabled
GDB single-stepping is now handled generically.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 9498d1032c107166ffb72939f99929a4dd3f600a
https://github.com/qemu/qemu/commit/9498d1032c107166ffb72939f99929a4dd3f600a
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/ppc/translate.c
Log Message:
-----------
target/ppc: Drop exit checks for singlestep_enabled
GDB single-stepping is now handled generically.
Reuse gen_debug_exception to handle architectural debug exceptions.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: ea06a006525181826b1197a987d474bdaeb0acf7
https://github.com/qemu/qemu/commit/ea06a006525181826b1197a987d474bdaeb0acf7
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/riscv/insn_trans/trans_privileged.c.inc
Log Message:
-----------
target/riscv: Remove dead code after exception
We have already set DISAS_NORETURN in generate_exception,
which makes the exit_tb unreachable.
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 273b68b10428117ffb1917d4081cf8ab4cc940ca
https://github.com/qemu/qemu/commit/273b68b10428117ffb1917d4081cf8ab4cc940ca
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/riscv/insn_trans/trans_privileged.c.inc
M target/riscv/insn_trans/trans_rvi.c.inc
M target/riscv/insn_trans/trans_rvv.c.inc
M target/riscv/translate.c
Log Message:
-----------
target/riscv: Remove exit_tb and lookup_and_goto_ptr
GDB single-stepping is now handled generically, which means
we don't need to do anything in the wrappers.
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: b6509e35b9e3a3fa90cdafcb8d53bf75306f427b
https://github.com/qemu/qemu/commit/b6509e35b9e3a3fa90cdafcb8d53bf75306f427b
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/rx/helper.h
M target/rx/op_helper.c
M target/rx/translate.c
Log Message:
-----------
target/rx: Drop checks for singlestep_enabled
GDB single-stepping is now handled generically.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 2df7a3618aacaa0f057d7b05444a21974a157263
https://github.com/qemu/qemu/commit/2df7a3618aacaa0f057d7b05444a21974a157263
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/s390x/tcg/translate.c
Log Message:
-----------
target/s390x: Drop check for singlestep_enabled
GDB single-stepping is now handled generically.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 52df5adce9c028cec91cc0c10f7012b17212ea35
https://github.com/qemu/qemu/commit/52df5adce9c028cec91cc0c10f7012b17212ea35
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/sh4/helper.h
M target/sh4/op_helper.c
M target/sh4/translate.c
Log Message:
-----------
target/sh4: Drop check for singlestep_enabled
GDB single-stepping is now handled generically.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 1b55c52d607043210ed4579009191f99a5cf8f71
https://github.com/qemu/qemu/commit/1b55c52d607043210ed4579009191f99a5cf8f71
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/tricore/helper.h
M target/tricore/op_helper.c
M target/tricore/translate.c
Log Message:
-----------
target/tricore: Drop check for singlestep_enabled
GDB single-stepping is now handled generically.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 02bf7fa022feae36b0f818b5ee30daccef8615fd
https://github.com/qemu/qemu/commit/02bf7fa022feae36b0f818b5ee30daccef8615fd
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M target/xtensa/translate.c
Log Message:
-----------
target/xtensa: Drop check for singlestep_enabled
GDB single-stepping is now handled generically.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 995b87dedc78b0467f5f18bbc3546072ba97516a
https://github.com/qemu/qemu/commit/995b87dedc78b0467f5f18bbc3546072ba97516a
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-15 (Fri, 15 Oct 2021)
Changed paths:
M cpu.c
M hw/core/cpu-common.c
M include/hw/core/cpu.h
Log Message:
-----------
Revert "cpu: Move cpu_common_props to hw/core/cpu.c"
This reverts commit 1b36e4f5a5de585210ea95f2257839c2312be28f.
Despite a comment saying why cpu_common_props cannot be placed in
a file that is compiled once, it was moved anyway. Revert that.
Since then, Property is not defined in hw/core/cpu.h, so it is now
easier to declare a function to install the properties rather than
the Property array itself.
Cc: Eduardo Habkost <ehabkost@redhat.com>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: c148a0572130ff485cd2249fbdd1a3260d5e10a4
https://github.com/qemu/qemu/commit/c148a0572130ff485cd2249fbdd1a3260d5e10a4
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-10-16 (Sat, 16 Oct 2021)
Changed paths:
M accel/tcg/cpu-exec.c
M cpu.c
M hw/core/cpu-common.c
M include/hw/core/cpu.h
M target/alpha/translate.c
M target/arm/translate-a64.c
M target/arm/translate.c
M target/avr/translate.c
M target/cris/translate.c
M target/hexagon/translate.c
M target/hppa/translate.c
M target/i386/helper.h
M target/i386/tcg/misc_helper.c
M target/i386/tcg/translate.c
M target/m68k/translate.c
M target/microblaze/translate.c
M target/mips/tcg/translate.c
M target/openrisc/translate.c
M target/ppc/translate.c
M target/riscv/insn_trans/trans_privileged.c.inc
M target/riscv/insn_trans/trans_rvi.c.inc
M target/riscv/insn_trans/trans_rvv.c.inc
M target/riscv/translate.c
M target/rx/helper.h
M target/rx/op_helper.c
M target/rx/translate.c
M target/s390x/tcg/translate.c
M target/sh4/helper.h
M target/sh4/op_helper.c
M target/sh4/translate.c
M target/tricore/helper.h
M target/tricore/op_helper.c
M target/tricore/translate.c
M target/xtensa/translate.c
Log Message:
-----------
Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20211016' into staging
Move gdb singlestep to generic code
Fix cpu_common_props
# gpg: Signature made Sat 16 Oct 2021 11:13:54 AM PDT
# gpg: using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg: issuer "richard.henderson@linaro.org"
# gpg: Good signature from "Richard Henderson <richard.henderson@linaro.org>"
[ultimate]
* remotes/rth/tags/pull-tcg-20211016: (24 commits)
Revert "cpu: Move cpu_common_props to hw/core/cpu.c"
target/xtensa: Drop check for singlestep_enabled
target/tricore: Drop check for singlestep_enabled
target/sh4: Drop check for singlestep_enabled
target/s390x: Drop check for singlestep_enabled
target/rx: Drop checks for singlestep_enabled
target/riscv: Remove exit_tb and lookup_and_goto_ptr
target/riscv: Remove dead code after exception
target/ppc: Drop exit checks for singlestep_enabled
target/openrisc: Drop checks for singlestep_enabled
target/mips: Drop exit checks for singlestep_enabled
target/mips: Fix single stepping
target/microblaze: Drop checks for singlestep_enabled
target/microblaze: Check CF_NO_GOTO_TB for DISAS_JUMP
target/m68k: Drop checks for singlestep_enabled
target/i386: Drop check for singlestep_enabled
target/i386: Check CF_NO_GOTO_TB for dc->jmp_opt
target/hppa: Drop checks for singlestep_enabled
target/arm: Drop checks for singlestep_enabled
target/hexagon: Drop checks for singlestep_enabled
...
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Compare: https://github.com/qemu/qemu/compare/6587b0c1331d...c148a0572130
- [Qemu-commits] [qemu/qemu] c9460d: accel/tcg: Handle gdb singlestep in cpu_tb_exec,
Richard Henderson <=