qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] eb9484: qxl: fix pre-save logic


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] eb9484: qxl: fix pre-save logic
Date: Thu, 16 Sep 2021 03:25:01 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: eb94846280df3f1e2a91b6179fc05f9890b7e384
      
https://github.com/qemu/qemu/commit/eb94846280df3f1e2a91b6179fc05f9890b7e384
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2021-09-15 (Wed, 15 Sep 2021)

  Changed paths:
    M hw/display/qxl.c

  Log Message:
  -----------
  qxl: fix pre-save logic

Oops.  Logic is backwards.

Fixes: 39b8a183e2f3 ("qxl: remove assert in qxl_pre_save.")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/610
Resolves: https://bugzilla.redhat.com//show_bug.cgi?id=2002907
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210910094203.3582378-1-kraxel@redhat.com>


  Commit: 89faed62af70283d5b6d38a58a1cf40535242c51
      
https://github.com/qemu/qemu/commit/89faed62af70283d5b6d38a58a1cf40535242c51
  Author: Vivek Kasireddy <vivek.kasireddy@intel.com>
  Date:   2021-09-15 (Wed, 15 Sep 2021)

  Changed paths:
    M include/ui/gtk.h
    M ui/gtk-egl.c
    M ui/gtk.c

  Log Message:
  -----------
  ui/gtk: Create a common release_dmabuf helper

Since the texture release mechanism is same for both gtk-egl
and gtk-glarea, move the helper from gtk-egl to common gtk
code so that it can be shared by both gtk backends.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
Message-Id: <20210914211837.3229977-2-vivek.kasireddy@intel.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 121abaf3e68d620f7c4c1d16875de4a4b92fa8f8
      
https://github.com/qemu/qemu/commit/121abaf3e68d620f7c4c1d16875de4a4b92fa8f8
  Author: Vivek Kasireddy <vivek.kasireddy@intel.com>
  Date:   2021-09-15 (Wed, 15 Sep 2021)

  Changed paths:
    M include/ui/console.h
    M include/ui/egl-helpers.h
    M ui/egl-helpers.c

  Log Message:
  -----------
  ui/egl: Add egl helpers to help with synchronization

These egl helpers would be used for creating and waiting on
a sync object.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
Message-Id: <20210914211837.3229977-3-vivek.kasireddy@intel.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 65b847d284c1ab8a1dbd44d2b046e87e83ebb6e0
      
https://github.com/qemu/qemu/commit/65b847d284c1ab8a1dbd44d2b046e87e83ebb6e0
  Author: Vivek Kasireddy <vivek.kasireddy@intel.com>
  Date:   2021-09-15 (Wed, 15 Sep 2021)

  Changed paths:
    M hw/display/virtio-gpu-udmabuf.c
    M include/ui/console.h
    M include/ui/egl-helpers.h
    M include/ui/gtk.h
    M ui/gtk-egl.c
    M ui/gtk-gl-area.c
    M ui/gtk.c

  Log Message:
  -----------
  ui: Create sync objects and fences only for blobs

Create sync objects and fences only for dmabufs that are blobs. Once a
fence is created (after glFlush) and is signalled,
graphic_hw_gl_flushed() will be called and virtio-gpu cmd processing
will be resumed.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
Message-Id: <20210914211837.3229977-4-vivek.kasireddy@intel.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: ab971f8abb8f3e107619866151335ec6e889b5c5
      
https://github.com/qemu/qemu/commit/ab971f8abb8f3e107619866151335ec6e889b5c5
  Author: Vivek Kasireddy <vivek.kasireddy@intel.com>
  Date:   2021-09-15 (Wed, 15 Sep 2021)

  Changed paths:
    M include/ui/gtk.h
    M ui/gtk-egl.c
    M ui/gtk.c

  Log Message:
  -----------
  ui/gtk-egl: Wait for the draw signal for dmabuf blobs

Instead of immediately drawing and submitting, queue and wait
for the draw signal if the dmabuf submitted is a blob.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
Message-Id: <20210914211837.3229977-5-vivek.kasireddy@intel.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: b3a5dfdea99da55fdc70538eeeb2227ebe6d6a5f
      
https://github.com/qemu/qemu/commit/b3a5dfdea99da55fdc70538eeeb2227ebe6d6a5f
  Author: Vivek Kasireddy <vivek.kasireddy@intel.com>
  Date:   2021-09-15 (Wed, 15 Sep 2021)

  Changed paths:
    M hw/display/virtio-gpu.c

  Log Message:
  -----------
  virtio-gpu: Add gl_flushed callback

Adding this callback provides a way to resume the processing of
cmds in fenceq and cmdq that were not processed because the UI
was waiting on a fence and blocked cmd processing.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
Message-Id: <20210914211837.3229977-6-vivek.kasireddy@intel.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: aa74d7066e9883530157b4ffd18ee40c11eb6323
      
https://github.com/qemu/qemu/commit/aa74d7066e9883530157b4ffd18ee40c11eb6323
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M hw/display/qxl.c
    M hw/display/virtio-gpu-udmabuf.c
    M hw/display/virtio-gpu.c
    M include/ui/console.h
    M include/ui/egl-helpers.h
    M include/ui/gtk.h
    M ui/egl-helpers.c
    M ui/gtk-egl.c
    M ui/gtk-gl-area.c
    M ui/gtk.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/vga-20210916-pull-request' 
into staging

virtio-gpu + ui: fence syncronization.
qxl: unbreak live migration.

# gpg: Signature made Thu 16 Sep 2021 06:56:03 BST
# gpg:                using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/vga-20210916-pull-request:
  virtio-gpu: Add gl_flushed callback
  ui/gtk-egl: Wait for the draw signal for dmabuf blobs
  ui: Create sync objects and fences only for blobs
  ui/egl: Add egl helpers to help with synchronization
  ui/gtk: Create a common release_dmabuf helper
  qxl: fix pre-save logic

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/57b6f58c1d0d...aa74d7066e98



reply via email to

[Prev in Thread] Current Thread [Next in Thread]