qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 4699a9: Hexagon (target/hexagon) remove put_u


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 4699a9: Hexagon (target/hexagon) remove put_user_*/get_user_*
Date: Thu, 22 Jul 2021 08:16:26 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 4699a9277932a0e5b5a22ffed18a753c51a0f3cb
      
https://github.com/qemu/qemu/commit/4699a9277932a0e5b5a22ffed18a753c51a0f3cb
  Author: Taylor Simpson <tsimpson@quicinc.com>
  Date:   2021-07-21 (Wed, 21 Jul 2021)

  Changed paths:
    M target/hexagon/op_helper.c

  Log Message:
  -----------
  Hexagon (target/hexagon) remove put_user_*/get_user_*

Replace put_user_* with cpu_st*_data_ra
Replace get_user_* with cpu_ld*_data_ra

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Message-Id: <1626384156-6248-2-git-send-email-tsimpson@quicinc.com>


  Commit: 25fc9b79cd057e394f35d7afc18493becd515797
      
https://github.com/qemu/qemu/commit/25fc9b79cd057e394f35d7afc18493becd515797
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-07-21 (Wed, 21 Jul 2021)

  Changed paths:
    M target/hexagon/op_helper.c

  Log Message:
  -----------
  target/hexagon: Drop include of qemu.h

The qemu.h file is a CONFIG_USER_ONLY header; it doesn't appear on
the include path for softmmu builds.  Currently we include it
unconditionally in target/hexagon/op_helper.c.  We used to need it
for the put_user_*() and get_user_*() functions, but now that we have
removed the uses of those from op_helper.c, the only reason it's
still there is that we're implicitly relying on it pulling in some
other headers.

Explicitly include the headers we need for other functions, and drop
the include of qemu.h.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20210717103017.20491-1-peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>


  Commit: 953ea3e4b426ee0c8349343c53e3358cfec720f2
      
https://github.com/qemu/qemu/commit/953ea3e4b426ee0c8349343c53e3358cfec720f2
  Author: Taylor Simpson <tsimpson@quicinc.com>
  Date:   2021-07-21 (Wed, 21 Jul 2021)

  Changed paths:
    M tests/tcg/multiarch/linux-test.c

  Log Message:
  -----------
  linux-test (tests/tcg/multiarch/linux-test.c) add check

Add a check that the SIGSEGV handler is called

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Message-Id: <1626384156-6248-3-git-send-email-tsimpson@quicinc.com>


  Commit: 4ce4904ed673291a14faa49471ec16a32d4b0ce9
      
https://github.com/qemu/qemu/commit/4ce4904ed673291a14faa49471ec16a32d4b0ce9
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-07-22 (Thu, 22 Jul 2021)

  Changed paths:
    M target/hexagon/op_helper.c
    M tests/tcg/multiarch/linux-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/quic/tags/pull-hex-20210721' into 
staging

The Hexagon target was silently failing the SIGSEGV test because
the signal handler was not called.

Patch 1/3 fixes the Hexagon target
Patch 2/3 drops include qemu.h from target/hexagon/op_helper.c
Patch 3/3 adds a check that the signal handler is called

# gpg: Signature made Wed 21 Jul 2021 22:12:47 BST
# gpg:                using RSA key 7B0244FB12DE4422
# gpg: Good signature from "Taylor Simpson (Rock on) <tsimpson@quicinc.com>" 
[undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 3635 C788 CE62 B91F D4C5  9AB4 7B02 44FB 12DE 4422

* remotes/quic/tags/pull-hex-20210721:
  linux-test (tests/tcg/multiarch/linux-test.c) add check
  target/hexagon: Drop include of qemu.h
  Hexagon (target/hexagon) remove put_user_*/get_user_*

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/beb191385882...4ce4904ed673



reply via email to

[Prev in Thread] Current Thread [Next in Thread]