[Qemu-commits] [qemu/qemu] 8619b5: ci: build & store windows installer

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 8619b5ddb56f562c751bcdac2328abcbff37fdeb
      
https://github.com/qemu/qemu/commit/8619b5ddb56f562c751bcdac2328abcbff37fdeb
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2021-07-19 (Mon, 19 Jul 2021)

  Changed paths:
    M .gitlab-ci.d/crossbuild-template.yml
    M .gitlab-ci.d/crossbuilds.yml
    M tests/docker/dockerfiles/fedora-win64-cross.docker

  Log Message:
  -----------
  ci: build & store windows installer

Build windows installer for qemu in gitlab CI,
store the result as artifact.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210623091137.1156959-2-kraxel@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 659eb157a55666bf379f5362238a86d855e262e2
      
https://github.com/qemu/qemu/commit/659eb157a55666bf379f5362238a86d855e262e2
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-07-19 (Mon, 19 Jul 2021)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Fix endianess test with LTO

If a user is trying to compile QEMU with link-time optimization
enabled by running the configure script like this:

 .../configure --extra-cflags="-flto"

then the endianess test is failing since the magic values do not
show up in the intermediate object files there. If the host is
a big endian machine (like s390x), the QEMU binary is then unusable
since the corresponding variable "bigendian" is pre-initialized
with "no".

To fix this issue, we should rather create a full binary and look
for the magic strings there instead.
And we really should not continue the build if the endianess check
failed, to make it clear right from the start that something went
wrong here, thus let's also add some "exit 1" statements here
after emitting the error message.

Message-Id: <20210715083928.933806-1-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 6a932c4ed8748b08c58cdba3fc9485d5549aacca
      
https://github.com/qemu/qemu/commit/6a932c4ed8748b08c58cdba3fc9485d5549aacca
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-07-19 (Mon, 19 Jul 2021)

  Changed paths:
    M hw/net/vmxnet3.c

  Log Message:
  -----------
  hw/net/vmxnet3: Do not abort if the guest is trying to use an invalid TX queue

QEMU should never abort just because the guest is doing something odd.
Let's simply log the error and ignore the bad transmit queue instead.

Buglink: https://bugs.launchpad.net/qemu/+bug/1926111
Message-Id: <20210715103755.1035566-1-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 283f0a05e24a5e5fab78305f783f06215390d620
      
https://github.com/qemu/qemu/commit/283f0a05e24a5e5fab78305f783f06215390d620
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-07-19 (Mon, 19 Jul 2021)

  Changed paths:
    M hw/net/net_tx_pkt.c

  Log Message:
  -----------
  hw/net/net_tx_pkt: Fix crash detected by fuzzer

QEMU currently crashes when it's started like this:

cat << EOF | ./qemu-system-i386 -device vmxnet3 -nodefaults -qtest stdio
outl 0xcf8 0x80001014
outl 0xcfc 0xe0001000
outl 0xcf8 0x80001018
outl 0xcf8 0x80001004
outw 0xcfc 0x7
outl 0xcf8 0x80001083
write 0x0 0x1 0xe1
write 0x1 0x1 0xfe
write 0x2 0x1 0xbe
write 0x3 0x1 0xba
writeq 0xe0001020 0xefefff5ecafe0000
writeq 0xe0001020 0xffff5e5ccafe0002
EOF

It hits this assertion:

qemu-system-i386: ../qemu/hw/net/net_tx_pkt.c:453: net_tx_pkt_reset:
 Assertion `pkt->raw' failed.

This happens because net_tx_pkt_init() is called with max_frags == 0 and
thus the allocation

    p->raw = g_new(struct iovec, max_frags);

results in a NULL pointer that causes the

    assert(pkt->raw);

in net_tx_pkt_reset() to fail later. To fix this issue we can check
that max_raw_frags was not zero before asserting that pkt->raw is
a non-NULL pointer.

Buglink: https://bugs.launchpad.net/qemu/+bug/1890157
Message-Id: <20210715193219.1132571-1-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Pankaj Gupta <pankaj.gupta@ionos.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 9405d87be25db6dff4d7b5ab48a81bbf6d083e47
      
https://github.com/qemu/qemu/commit/9405d87be25db6dff4d7b5ab48a81bbf6d083e47
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-07-19 (Mon, 19 Jul 2021)

  Changed paths:
    M hw/ide/ioport.c
    M hw/ide/piix.c
    M hw/isa/isa-bus.c
    M include/hw/ide/internal.h
    M include/hw/isa/isa.h

  Log Message:
  -----------
  hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine

QEMU currently crashes when the user tries to do something like:

 qemu-system-x86_64 -M x-remote -device piix3-ide

This happens because the "isabus" variable is not initialized with
the x-remote machine yet. Add a proper check for this condition
and propagate the error to the caller, so we can fail there gracefully.

Message-Id: <20210416125256.2039734-1-thuth@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 7457b407edd6e8555e4b46488aab2f13959fccf8
      
https://github.com/qemu/qemu/commit/7457b407edd6e8555e4b46488aab2f13959fccf8
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-07-19 (Mon, 19 Jul 2021)

  Changed paths:
    M .gitlab-ci.d/crossbuild-template.yml
    M .gitlab-ci.d/crossbuilds.yml
    M configure
    M hw/ide/ioport.c
    M hw/ide/piix.c
    M hw/isa/isa-bus.c
    M hw/net/net_tx_pkt.c
    M hw/net/vmxnet3.c
    M include/hw/ide/internal.h
    M include/hw/isa/isa.h
    M tests/docker/dockerfiles/fedora-win64-cross.docker

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/thuth-gitlab/tags/pull-request-2021-07-19' into staging

- Compile-test the Windows installer in the Gitlab-CI
- Fix endianess detection problem with LTO in "configure"
- Fix two abort()s in the vmxnet code
- Fix crash with x-remote machine and IDE devices

# gpg: Signature made Mon 19 Jul 2021 10:47:12 BST
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/thuth-gitlab/tags/pull-request-2021-07-19:
  hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine
  hw/net/net_tx_pkt: Fix crash detected by fuzzer
  hw/net/vmxnet3: Do not abort if the guest is trying to use an invalid TX queue
  configure: Fix endianess test with LTO
  ci: build & store windows installer

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/fd79f89c76c8...7457b407edd6