qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] b1f3b4: Acceptance Tests: use the job work di


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] b1f3b4: Acceptance Tests: use the job work directory for c...
Date: Wed, 14 Jul 2021 12:34:41 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b1f3b410528177c0a2f86b48bb9fb24422008fb1
      
https://github.com/qemu/qemu/commit/b1f3b410528177c0a2f86b48bb9fb24422008fb1
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py

  Log Message:
  -----------
  Acceptance Tests: use the job work directory for created VMs

The QEMUMachine uses a base temporary directory for all temporary
needs.  By setting it to the Avocado's workdir, it's possible to
keep the temporary files during debugging sessions much more
easily by setting the "--keep-tmp" command line option.

Reference: 
https://avocado-framework.readthedocs.io/en/85.0/api/test/avocado.html#avocado.Test.workdir
Reference:
https://avocado-framework.readthedocs.io/en/85.0/config/index.html#run-keep-tmp

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-Id: <20210211220146.2525771-4-crosa@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 776b019d9d446c2a24a4dcde352616d496a89b36
      
https://github.com/qemu/qemu/commit/776b019d9d446c2a24a4dcde352616d496a89b36
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py

  Log Message:
  -----------
  Acceptance Tests: log information when creating QEMUMachine

Including its base temporary directory, given that information useful
for debugging can be put there.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210211220146.2525771-5-crosa@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: b306e26ce0f33ef0a899131c5191b77aaf6df364
      
https://github.com/qemu/qemu/commit/b306e26ce0f33ef0a899131c5191b77aaf6df364
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M python/qemu/machine/machine.py
    M tests/acceptance/avocado_qemu/__init__.py

  Log Message:
  -----------
  Acceptance Tests: distinguish between temp and logs dir

Logs can be very important to debug issues, and currently QEMUMachine
instances will remove logs that are created under the temporary
directories.

With this change, the stdout and stderr generated by the QEMU process
started by QEMUMachine will always be kept along the test results
directory.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210211220146.2525771-6-crosa@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 341929234c584565ddd7d29bb48d2a5f5f40de22
      
https://github.com/qemu/qemu/commit/341929234c584565ddd7d29bb48d2a5f5f40de22
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py
    M tests/acceptance/boot_linux.py

  Log Message:
  -----------
  Acceptance Tests: rename attribute holding the distro image checksum

This renames the attribute that holds the checksum for the image Linux
distribution image used.

The current name of the attribute is not very descriptive.  Also, in
preparation for making the distribution used configurable, which will
add distro related parameters, attributes and tags, let's make the
naming of those more uniform.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210414221457.1653745-2-crosa@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
[CR: split long lines]
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 889554f09ed0d4c2fcc6be28b81e2e9fc8f35aee
      
https://github.com/qemu/qemu/commit/889554f09ed0d4c2fcc6be28b81e2e9fc8f35aee
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py
    M tests/acceptance/boot_linux.py

  Log Message:
  -----------
  Acceptance Tests: move definition of distro checksums to the framework

Instead of having, by default, the checksum in the tests, and the
definition of tests in the framework, let's keep them together.

A central definition for distributions is available, and it should
allow other known distros to be added more easily.

No behavior change is expected here, and tests can still define
a distro_checksum value if for some reason they want to override
the known distribution information.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210414221457.1653745-3-crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Eric Auger <eric.auger@redhat.com>
[CR: split long lines]
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: d5adf9d52b36d63347b2f658b8c67567ff6bd525
      
https://github.com/qemu/qemu/commit/d5adf9d52b36d63347b2f658b8c67567ff6bd525
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M docs/devel/testing.rst
    M tests/acceptance/avocado_qemu/__init__.py

  Log Message:
  -----------
  Acceptance Tests: support choosing specific distro and version

The tests based on the LinuxTest class give the test writer a ready to
use guest operating system, currently pinned to Fedora 31.

With this change, it's now possible to choose different distros and
versions, similar to how other tags and parameter can be set for the
target arch, accelerator, etc.

One of the reasons for this work, is that some development features
depend on updates on the guest side.  For instance the tests on
virtiofs_submounts.py, require newer kernels, and may benefit from
running, say on Fedora 34, without the need for a custom kernel.

Please notice that the pre-caching of the Fedora 31 images done during
the early stages of `make check-acceptance` (before the tests are
actually executed) are not expanded here to cover every new image
added.  But, the tests will download other needed images (and cache
them) during the first execution.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210414221457.1653745-4-crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 9f5193413026ed65f9651108b6656054b40e43a0
      
https://github.com/qemu/qemu/commit/9f5193413026ed65f9651108b6656054b40e43a0
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py

  Log Message:
  -----------
  tests/acceptance: Ignore binary data sent on serial console

If a guest sends binary data on the serial console, we get:

 File "tests/acceptance/avocado_qemu/__init__.py", line 92,
   in _console_interaction msg = console.readline().strip()
 File "/usr/lib64/python3.8/codecs.py", line 322,
   in decode (result, consumed) = self._buffer_decode(data, self.errors, final)
 UnicodeDecodeError: 'utf-8' codec can't decode byte 0xa9 in position 2: 
invalid start byte

Since we use the console with readline(), fix it the easiest
way possible: ignore binary data (all current tests compare
text string anyway).

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210515134555.307404-2-f4bug@amsat.org>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Tested-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: fb130401736d294843764bfbab37a9e9e020ef08
      
https://github.com/qemu/qemu/commit/fb130401736d294843764bfbab37a9e9e020ef08
  Author: Willian Rampazzo <willianr@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py

  Log Message:
  -----------
  avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class

As the KNOWN_DISTROS grows, more loosely methods will be created in
the avocado_qemu/__init__.py file.

Let's refactor the code so that KNOWN_DISTROS and related methods are
packaged in a class

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Message-Id: <20210706131729.30749-2-eric.auger@redhat.com>
[CR: moved aarch64 definition from patch 2 to 1]
[CR: protect get() when arch is not defined]
[CR: split long lines]
Acked-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: c839d305b90d04643c21b30b8cd1828a9e995163
      
https://github.com/qemu/qemu/commit/c839d305b90d04643c21b30b8cd1828a9e995163
  Author: Willian Rampazzo <willianr@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py

  Log Message:
  -----------
  Acceptance Tests: Add default kernel params and pxeboot url to the 
KNOWN_DISTROS collection

When running LinuxTests we may need to run the guest with
custom params. It is practical to store the pxeboot URL
and the default kernel params so that the
tests just need to fetch those and augment the kernel params.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Message-Id: <20210706131729.30749-3-eric.auger@redhat.com>
[CR: split long lines]
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 6ace9b4e5e78f5d4fac1e5b63264945a5373afd5
      
https://github.com/qemu/qemu/commit/6ace9b4e5e78f5d4fac1e5b63264945a5373afd5
  Author: Eric Auger <eric.auger@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M MAINTAINERS
    A tests/acceptance/smmu.py

  Log Message:
  -----------
  avocado_qemu: Add SMMUv3 tests

Add new tests checking the good behavior of the SMMUv3 protecting
2 virtio pci devices (block and net). We check the guest boots and
we are able to install a package. Different guest configs are tested:
standard, passthrough an strict=0. This is tested with both fedora 31 and
33. The former uses a 5.3 kernel without range invalidation whereas the
latter uses a 5.8 kernel that features range invalidation.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Tested-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210706131729.30749-4-eric.auger@redhat.com>
[CR: split long lines]
[CR: added MAINTAINERS entry]
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 5e57d4e895e59579b3c3a7119df259cdfde2d1ce
      
https://github.com/qemu/qemu/commit/5e57d4e895e59579b3c3a7119df259cdfde2d1ce
  Author: Eric Auger <eric.auger@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    A tests/acceptance/intel_iommu.py

  Log Message:
  -----------
  avocado_qemu: Add Intel iommu tests

Add Intel IOMMU functional tests based on fedora 31.
Different configs are checked:
- strict
- caching mode, strict
- passthrough.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Willian Rampazzo <willianr@redhat.com>
Tested-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
Message-Id: <20210706131729.30749-5-eric.auger@redhat.com>
[CR: split long lines]
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 012293c1b1451edc28e9b3a6ea573d74c5ed373c
      
https://github.com/qemu/qemu/commit/012293c1b1451edc28e9b3a6ea573d74c5ed373c
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/boot_linux_console.py
    M tests/acceptance/ppc_prep_40p.py

  Log Message:
  -----------
  tests/acceptance: Tag NetBSD tests as 'os:netbsd'

Avocado allows us to select set of tests using tags.
When wanting to run all tests using a NetBSD guest OS,
it is convenient to have them tagged, add the 'os:netbsd'
tag.

It allows one to run the NetBSD tests with:

 $ avocado --show=app,console run -t os:netbsd tests/acceptance/

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210623180021.898286-4-f4bug@amsat.org>
Reviewed-by: Niek Linnenbank <nieklinnenbank@gmail.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
[PMD: ammend the commit message with example command]
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 20bbf846b960477a71284bbf848437f2a6e7c804
      
https://github.com/qemu/qemu/commit/20bbf846b960477a71284bbf848437f2a6e7c804
  Author: Wainer dos Santos Moschetta <wainersm@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M docs/devel/testing.rst
    M tests/acceptance/avocado_qemu/__init__.py

  Log Message:
  -----------
  tests/acceptance: Automatic set -cpu to the test vm

This introduces a new feature to the functional tests: automatic setting of
the '-cpu VALUE' option to the created vm if the test is tagged with
'cpu:VALUE'. The 'cpu' property is made available to the test object as well.

For example, for a simple test as:

    def test(self):
        """
        :avocado: tags=cpu:host
        """
        self.assertEqual(self.cpu, "host")
        self.vm.launch()

The resulting QEMU evocation will be like:

    qemu-system-x86_64 -display none -vga none \
        -chardev 
socket,id=mon,path=/var/tmp/avo_qemu_sock_pdgzbgd_/qemu-1135557-monitor.sock \
        -mon chardev=mon,mode=control -cpu host

Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210430133414.39905-2-wainersm@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 8a7c1fdecb91b6aeb943156a169fd7a160691542
      
https://github.com/qemu/qemu/commit/8a7c1fdecb91b6aeb943156a169fd7a160691542
  Author: Wainer dos Santos Moschetta <wainersm@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/machine_mips_malta.py
    M tests/acceptance/tcg_plugins.py

  Log Message:
  -----------
  tests/acceptance: Fix mismatch on cpu tagged tests

There are test cases on machine_mips_malta.py and tcg_plugins.py files
where the cpu tag does not correspond to the value actually given to the QEMU
binary. This fixed those tests tags.

Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210430133414.39905-3-wainersm@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: d377ba48524781310536d5e97642e4b95a4b62c8
      
https://github.com/qemu/qemu/commit/d377ba48524781310536d5e97642e4b95a4b62c8
  Author: Wainer dos Santos Moschetta <wainersm@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/boot_linux.py
    M tests/acceptance/boot_xen.py
    M tests/acceptance/machine_mips_malta.py
    M tests/acceptance/replay_kernel.py
    M tests/acceptance/reverse_debugging.py
    M tests/acceptance/tcg_plugins.py

  Log Message:
  -----------
  tests/acceptance: Let the framework handle "cpu:VALUE" tagged tests

The tests that are already tagged with "cpu:VALUE" don't need to add
"-cpu VALUE" to the list of arguments of the vm object because the avocado_qemu
framework is able to handle it automatically.

Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210430133414.39905-4-wainersm@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 2d14975963b831701363a1153a0db97dc19e0d2e
      
https://github.com/qemu/qemu/commit/2d14975963b831701363a1153a0db97dc19e0d2e
  Author: Wainer dos Santos Moschetta <wainersm@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/boot_linux_console.py
    M tests/acceptance/pc_cpu_hotplug_props.py
    M tests/acceptance/replay_kernel.py
    M tests/acceptance/virtio-gpu.py

  Log Message:
  -----------
  tests/acceptance: Tagging tests with "cpu:VALUE"

The existing tests which are passing "-cpu VALUE" argument to the vm object
are now properly "cpu:VALUE" tagged, so letting the avocado_qemu framework to
handle that automatically.

Reviewed-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210430133414.39905-5-wainersm@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 555fe0c2a8d5c8a9b6dbf17670018cc2d8f062b3
      
https://github.com/qemu/qemu/commit/555fe0c2a8d5c8a9b6dbf17670018cc2d8f062b3
  Author: Wainer dos Santos Moschetta <wainersm@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M python/qemu/machine/machine.py

  Log Message:
  -----------
  python/qemu: Add args property to the QEMUMachine class

This added the args property to QEMUMachine so that users of the class
can access and handle the list of arguments to be given to the QEMU
binary.

Reviewed-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210430133414.39905-6-wainersm@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 58954ac0b59966ebd32720b183a3c7fcfc60e83d
      
https://github.com/qemu/qemu/commit/58954ac0b59966ebd32720b183a3c7fcfc60e83d
  Author: Wainer dos Santos Moschetta <wainersm@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py

  Log Message:
  -----------
  tests/acceptance: Add set_vm_arg() to the Test class

The set_vm_arg method is added to avocado_qemu.Test class on this
change. Use that method to set (or replace) an argument to the list of
arguments given to the QEMU binary.

Suggested-by: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Message-Id: <20210430133414.39905-7-wainersm@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 3843a32152a54092f1fc2c8eb54a03da64ad4c6d
      
https://github.com/qemu/qemu/commit/3843a32152a54092f1fc2c8eb54a03da64ad4c6d
  Author: Wainer dos Santos Moschetta <wainersm@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/x86_cpu_model_versions.py

  Log Message:
  -----------
  tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests

Some test cases on x86_cpu_model_versions.py are corner cases because they
need to pass extra options to the -cpu argument. Once the avocado_qemu
framework will set -cpu automatically, the value should be reset. This changed
those tests so to call set_vm_arg() to overwrite the -cpu value.

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Message-Id: <20210430133414.39905-8-wainersm@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 6f651a6d84b64060aa77373a72ba02ff61ad9911
      
https://github.com/qemu/qemu/commit/6f651a6d84b64060aa77373a72ba02ff61ad9911
  Author: Wainer dos Santos Moschetta <wainersm@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M .gitlab-ci.d/static_checks.yml
    M python/Makefile
    M python/setup.cfg

  Log Message:
  -----------
  python: Configure tox to skip missing interpreters

Currently tox tests against the installed interpreters, however if any
supported interpreter is absent then it will return fail. It seems not
reasonable to expect developers to have all supported interpreters
installed on their systems. Luckily tox can be configured to skip
missing interpreters.

This changed the tox setup so that missing interpreters are skipped by
default. On the CI, however, we still want to enforce it tests
against all supported. This way on CI the
--skip-missing-interpreters=false option is passed to tox.

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210630184546.456582-1-wainersm@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 414e9ae345c5372ece6699342f8afe8d2db107d0
      
https://github.com/qemu/qemu/commit/414e9ae345c5372ece6699342f8afe8d2db107d0
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  Acceptance tests: do not try to reuse packages from the system

The premise behind the original behavior is that it would save people
from downloading Avocado (and other dependencies) if already installed
on the system.  To be honest, I think it's extremely rare that the
same versions described as dependencies will be available on most
systems.  But, the biggest motivations here are that:

 1) Hacking on QEMU in the same system used to develop Avocado leads
    to confusion with regards to the exact bits that are being used;

 2) Not reusing Python packages from system wide installations gives
    extra assurance that the same behavior will be seen from tests run
    on different machines;

With regards to downloads, pip already caches the downloaded wheels
and tarballs under ~/.cache/pip, so there should not be more than
one download even if the venv is destroyed and recreated.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210415215141.1865467-3-crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 9a94d8ae97cd25d71565b99682bb7e49133c1af3
      
https://github.com/qemu/qemu/commit/9a94d8ae97cd25d71565b99682bb7e49133c1af3
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/linux_ssh_mips_malta.py

  Log Message:
  -----------
  tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

These tests' setUp do not do anything beyong what their base class do.
And while they do decorate the setUp() we can decorate the classes
instead, so no functionality is lost here.

This is possible because since Avocado 76.0 we can decorate setUp()
directly.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210415215141.1865467-4-crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
[PMD: added note to commit message about Avocado feature/version]
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: c4e2d499c94fb7d6ea43d28e2613559861ef5d79
      
https://github.com/qemu/qemu/commit/c4e2d499c94fb7d6ea43d28e2613559861ef5d79
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M tests/acceptance/cpu_queries.py

  Log Message:
  -----------
  tests/acceptance/cpu_queries.py: use the proper logging channels

The test contains methods for the proper log of test related
information.  Let's use that and remove the print and the unused
logging import.

Reference: 
https://avocado-framework.readthedocs.io/en/87.0/api/test/avocado.html#avocado.Test.log
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210415215141.1865467-6-crosa@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: a9649a719a44894b81f38dc1c5c1888ee684acef
      
https://github.com/qemu/qemu/commit/a9649a719a44894b81f38dc1c5c1888ee684acef
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-07-14 (Wed, 14 Jul 2021)

  Changed paths:
    M .gitlab-ci.d/static_checks.yml
    M MAINTAINERS
    M docs/devel/testing.rst
    M python/Makefile
    M python/qemu/machine/machine.py
    M python/setup.cfg
    M tests/Makefile.include
    M tests/acceptance/avocado_qemu/__init__.py
    M tests/acceptance/boot_linux.py
    M tests/acceptance/boot_linux_console.py
    M tests/acceptance/boot_xen.py
    M tests/acceptance/cpu_queries.py
    A tests/acceptance/intel_iommu.py
    M tests/acceptance/linux_ssh_mips_malta.py
    M tests/acceptance/machine_mips_malta.py
    M tests/acceptance/pc_cpu_hotplug_props.py
    M tests/acceptance/ppc_prep_40p.py
    M tests/acceptance/replay_kernel.py
    M tests/acceptance/reverse_debugging.py
    A tests/acceptance/smmu.py
    M tests/acceptance/tcg_plugins.py
    M tests/acceptance/virtio-gpu.py
    M tests/acceptance/x86_cpu_model_versions.py

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/cleber-gitlab/tags/python-next-pull-request' into staging

Python and Acceptance Tests

- New SMMUv3 and Intel IOMMU tests
- Respect "cpu" tags and reduce boiler plate code
- Improved logging of qemu execution output
- Other misc improvements

# gpg: Signature made Tue 13 Jul 2021 22:11:36 BST
# gpg:                using RSA key 7ABB96EB8B46B94D5E0FE9BB657E8D33A5F209F3
# gpg: Good signature from "Cleber Rosa <crosa@redhat.com>" [marginal]
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 7ABB 96EB 8B46 B94D 5E0F  E9BB 657E 8D33 A5F2 09F3

* remotes/cleber-gitlab/tags/python-next-pull-request: (23 commits)
  tests/acceptance/cpu_queries.py: use the proper logging channels
  tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp
  Acceptance tests: do not try to reuse packages from the system
  python: Configure tox to skip missing interpreters
  tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests
  tests/acceptance: Add set_vm_arg() to the Test class
  python/qemu: Add args property to the QEMUMachine class
  tests/acceptance: Tagging tests with "cpu:VALUE"
  tests/acceptance: Let the framework handle "cpu:VALUE" tagged tests
  tests/acceptance: Fix mismatch on cpu tagged tests
  tests/acceptance: Automatic set -cpu to the test vm
  tests/acceptance: Tag NetBSD tests as 'os:netbsd'
  avocado_qemu: Add Intel iommu tests
  avocado_qemu: Add SMMUv3 tests
  Acceptance Tests: Add default kernel params and pxeboot url to the 
KNOWN_DISTROS collection
  avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class
  tests/acceptance: Ignore binary data sent on serial console
  Acceptance Tests: support choosing specific distro and version
  Acceptance Tests: move definition of distro checksums to the framework
  Acceptance Tests: rename attribute holding the distro image checksum
  ...

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/1f966c7c11bb...a9649a719a44



reply via email to

[Prev in Thread] Current Thread [Next in Thread]