[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/7] hw/nvme: add placement handle list ranges
From: |
Klaus Jensen |
Subject: |
[PULL 6/7] hw/nvme: add placement handle list ranges |
Date: |
Wed, 28 Jun 2023 11:25:00 +0200 |
From: Klaus Jensen <k.jensen@samsung.com>
Allow the placement handles to be specified as ranges, i.e.
`fdp.ruhs=1:3-5` will attempt to assign ruh 1, 3, 4 and 5 to the
namespace.
Reviewed-by: Jesper Wendel Devantier <j.devantier@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/nvme/ns.c | 42 +++++++++++++++++++++++++++++++++---------
1 file changed, 33 insertions(+), 9 deletions(-)
diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c
index c4ea2033bb1c..44aba8f4d9cf 100644
--- a/hw/nvme/ns.c
+++ b/hw/nvme/ns.c
@@ -400,8 +400,9 @@ static bool nvme_ns_init_fdp(NvmeNamespace *ns, Error
**errp)
NvmeRuHandle *ruh;
uint8_t lbafi = NVME_ID_NS_FLBAS_INDEX(ns->id_ns.flbas);
g_autofree unsigned int *ruhids = NULL;
- unsigned int *ruhid;
- char *r, *p, *token;
+ unsigned int n, m, *ruhid;
+ const char *endptr, *token;
+ char *r, *p;
uint16_t *ph;
if (!ns->params.fdp.ruhs) {
@@ -438,17 +439,40 @@ static bool nvme_ns_init_fdp(NvmeNamespace *ns, Error
**errp)
/* parse the placement handle identifiers */
while ((token = qemu_strsep(&p, ";")) != NULL) {
- if (ns->fdp.nphs++ == endgrp->fdp.nruh) {
- error_setg(errp, "too many placement handles");
- free(r);
- return false;
- }
-
- if (qemu_strtoui(token, NULL, 0, ruhid++) < 0) {
+ if (qemu_strtoui(token, &endptr, 0, &n) < 0) {
error_setg(errp, "cannot parse reclaim unit handle identifier");
free(r);
return false;
}
+
+ m = n;
+
+ /* parse range */
+ if (*endptr == '-') {
+ token = endptr + 1;
+
+ if (qemu_strtoui(token, NULL, 0, &m) < 0) {
+ error_setg(errp, "cannot parse reclaim unit handle
identifier");
+ free(r);
+ return false;
+ }
+
+ if (m < n) {
+ error_setg(errp, "invalid reclaim unit handle identifier
range");
+ free(r);
+ return false;
+ }
+ }
+
+ for (; n <= m; n++) {
+ if (ns->fdp.nphs++ == endgrp->fdp.nruh) {
+ error_setg(errp, "too many placement handles");
+ free(r);
+ return false;
+ }
+
+ *ruhid++ = n;
+ }
}
free(r);
--
2.41.0
- [PULL 0/7] hw/nvme updates, Klaus Jensen, 2023/06/28
- [PULL 2/7] hw/nvme: consider COPY command in nvme_aio_err, Klaus Jensen, 2023/06/28
- [PULL 1/7] hw/nvme: add comment for nvme-ns properties, Klaus Jensen, 2023/06/28
- [PULL 3/7] hw/nvme: check maximum copy length (MCL) for COPY, Klaus Jensen, 2023/06/28
- [PULL 5/7] hw/nvme: verify uniqueness of reclaim unit handle identifiers, Klaus Jensen, 2023/06/28
- [PULL 4/7] hw/nvme: fix verification of number of ruhis, Klaus Jensen, 2023/06/28
- [PULL 6/7] hw/nvme: add placement handle list ranges,
Klaus Jensen <=
- [PULL 7/7] docs: update hw/nvme documentation for TP4146, Klaus Jensen, 2023/06/28
- Re: [PULL 0/7] hw/nvme updates, Richard Henderson, 2023/06/28