[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/10] hw/virtio: Remove unnecessary 'virtio-access.h' hea
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 09/10] hw/virtio: Remove unnecessary 'virtio-access.h' header |
Date: |
Wed, 24 May 2023 16:05:43 +0100 |
User-agent: |
mu4e 1.11.6; emacs 29.0.91 |
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> None of these files use the VirtIO Load/Store API declared
> by "hw/virtio/virtio-access.h". This header probably crept
> in via copy/pasting, remove it.
>
> Note, "virtio-access.h" is target-specific, so any file
> including it also become tainted as target-specific.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Acked-by: Richard Henderson <richard.henderson@linaro.org>
> Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
- Re: [PATCH v2 05/10] hw/virtio: Introduce VHOST_VSOCK_COMMON symbol in Kconfig, (continued)
- [PATCH v2 06/10] hw/virtio/virtio-mem: Use qemu_ram_get_fd() helper, Philippe Mathieu-Daudé, 2023/05/24
- [PATCH v2 07/10] hw/virtio/vhost-vsock: Include missing 'virtio/virtio-bus.h' header, Philippe Mathieu-Daudé, 2023/05/24
- [PATCH v2 08/10] hw/virtio/virtio-iommu: Use target-agnostic qemu_target_page_mask(), Philippe Mathieu-Daudé, 2023/05/24
- [PATCH v2 09/10] hw/virtio: Remove unnecessary 'virtio-access.h' header, Philippe Mathieu-Daudé, 2023/05/24
- Re: [PATCH v2 09/10] hw/virtio: Remove unnecessary 'virtio-access.h' header,
Alex Bennée <=
- [PATCH v2 10/10] hw/virtio: Build various target-agnostic objects just once, Philippe Mathieu-Daudé, 2023/05/24
- Re: [PATCH v2 00/10] hw/virtio: Build various target-agnostic objects just once, Philippe Mathieu-Daudé, 2023/05/31