Re: [PATCH 04/17] meson: Fix to make QAPI generator output depend on main.py

[Juan Quintela]

Markus Armbruster <armbru@redhat.com> wrote:
> @qapi_gen_depends is missing scripts/qapi/main.py.  Fix that, and drop
> a duplicate scripts/qapi/common.py.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>


> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index c44d05a13f..ed24df2ade 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2834,12 +2834,12 @@ qapi_gen_depends = [ meson.current_source_dir() / 
> 'scripts/qapi/__init__.py',
>                       meson.current_source_dir() / 'scripts/qapi/expr.py',
>                       meson.current_source_dir() / 'scripts/qapi/gen.py',
>                       meson.current_source_dir() / 
> 'scripts/qapi/introspect.py',
> +                     meson.current_source_dir() / 'scripts/qapi/main.py',
>                       meson.current_source_dir() / 'scripts/qapi/parser.py',
>                       meson.current_source_dir() / 'scripts/qapi/schema.py',
>                       meson.current_source_dir() / 'scripts/qapi/source.py',
>                       meson.current_source_dir() / 'scripts/qapi/types.py',
>                       meson.current_source_dir() / 'scripts/qapi/visit.py',
> -                     meson.current_source_dir() / 'scripts/qapi/common.py',
>                       meson.current_source_dir() / 'scripts/qapi-gen.py'
>  ]

And here you see why putting things in alphabetical order (when
possible) avoids this kind of duplications.