|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [PATCH v3 4/4] configure: add --disable-colo-proxy option |
Date: | Fri, 28 Apr 2023 11:30:09 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 |
On 28.04.23 10:33, Juan Quintela wrote:
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:Add option to not build filter-mirror, filter-rewriter and colo-compare when they are not needed. There could be more agile configuration, for example add separate options for each filter, but that may be done in future on demand. The aim of this patch is to make possible to disable the whole COLO Proxy subsystem. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>As you have arrived to an agreement about what to do with filter-rewriter, the rest of the patch is ok with me.
You mean filter-mirror, precisely this change to the patch: @@ -22,7 +22,7 @@ if get_option('replication').allowed() or \ endif if get_option('colo_proxy').allowed() - softmmu_ss.add(files('filter-mirror.c', 'filter-rewriter.c')) + softmmu_ss.add(files('filter-rewriter.c')) endif softmmu_ss.add(when: 'CONFIG_TCG', if_true: files('filter-replay.c')) ?
Reviewed-by: Juan Quintela <quintela@redhat.com>
-- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |