Re: [PATCH v2 03/43] migration: Create migration_cap_set()

[Fabiano Rosas]

Juan Quintela <quintela@redhat.com> writes:

> And remove the convoluted use of qmp_migrate_set_capabilities() to
> enable disable MIGRATION_CAPABILITY_BLOCK.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration/migration.c | 34 ++++++++++++++++------------------
>  1 file changed, 16 insertions(+), 18 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 74f28cdca6..4bf5df4778 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1913,25 +1913,24 @@ void migrate_set_state(int *state, int old_state, int 
> new_state)
>      }
>  }
>  
> -static MigrationCapabilityStatus *migrate_cap_add(MigrationCapability index,
> -                                                  bool state)
> +static bool migrate_cap_set(int cap, bool value, Error **errp)

Just a nit, the commit message says migration_cap_set.

Reviewed-by: Fabiano Rosas <farosas@suse.de>