[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/16] qapi/block-core: Clean up after removal of dirty bitma
From: |
John Snow |
Subject: |
Re: [PATCH 05/16] qapi/block-core: Clean up after removal of dirty bitmap @status |
Date: |
Tue, 11 Apr 2023 16:56:46 -0400 |
On Tue, Apr 4, 2023 at 7:59 AM Markus Armbruster <armbru@redhat.com> wrote:
>
> Commit 81cbfd50886 (block: remove dirty bitmaps 'status' field)
> removed deprecated BlockDirtyInfo member @status. It neglected to
> remove references to its enumeration values from the documentation of
> its replacements. Do that now.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/block-core.json | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 75f7c62405..eeb2ed3f16 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -582,11 +582,11 @@
> # @granularity: granularity of the dirty bitmap in bytes (since 1.4)
> #
> # @recording: true if the bitmap is recording new writes from the guest.
> -# Replaces ``active`` and ``disabled`` statuses. (since 4.0)
> +# (since 4.0)
> #
> # @busy: true if the bitmap is in-use by some operation (NBD or jobs)
> # and cannot be modified via QMP or used by another operation.
> -# Replaces ``locked`` and ``frozen`` statuses. (since 4.0)
> +# (since 4.0)
> #
> # @persistent: true if the bitmap was stored on disk, is scheduled to be
> stored
> # on disk, or both. (since 4.0)
> --
> 2.39.2
>
Reviewed-By: John Snow <jsnow@redhat.com>
- [PATCH 01/16] qga/qapi-schema: Tidy up documentation of guest-fsfreeze-status, (continued)
- [PATCH 01/16] qga/qapi-schema: Tidy up documentation of guest-fsfreeze-status, Markus Armbruster, 2023/04/04
- [PATCH 08/16] qapi: Delete largely misleading "Stability Considerations", Markus Armbruster, 2023/04/04
- [PATCH 02/16] qga/qapi-schema: Fix a misspelled reference, Markus Armbruster, 2023/04/04
- [PATCH 03/16] qapi: Fix misspelled references, Markus Armbruster, 2023/04/04
- [PATCH 07/16] qapi: Tidy up examples, Markus Armbruster, 2023/04/04
- [PATCH 10/16] qapi: Fix unintended definition lists in documentation, Markus Armbruster, 2023/04/04
- [PATCH 05/16] qapi/block-core: Clean up after removal of dirty bitmap @status, Markus Armbruster, 2023/04/04
- Re: [PATCH 05/16] qapi/block-core: Clean up after removal of dirty bitmap @status,
John Snow <=
- [PATCH 13/16] qapi: Replace ad hoc "since" documentation by member documentation, Markus Armbruster, 2023/04/04
- [PATCH 06/16] qapi: @foo should be used to reference, not ``foo``, Markus Armbruster, 2023/04/04
- [PATCH 15/16] qapi: Format since information the conventional way: (since X.Y), Markus Armbruster, 2023/04/04
- [PATCH 09/16] qapi: Fix bullet list markup in documentation, Markus Armbruster, 2023/04/04
- [PATCH 11/16] qga/qapi-schema: Fix member documentation markup, Markus Armbruster, 2023/04/04
- [PATCH 04/16] qapi: Fix up references to long gone error classes, Markus Armbruster, 2023/04/04
- [PATCH 16/16] qapi storage-daemon/qapi: Fix documentation section structure, Markus Armbruster, 2023/04/04