[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH |
Date: |
Thu, 9 Mar 2023 13:08:46 +0100 |
On Thu, Mar 9, 2023 at 1:05 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> I think having to do this is problematic, because the blk_drain should
> leave no pending operation.
>
> Here it seems okay because you do it in a controlled situation, but the
> main thread can also issue blk_drain(), or worse bdrv_drained_begin(),
> and there would be pending I/O operations when it returns.
>
> Unfortunately I don't have a solution (I'm not considering the idea of
> using disable_request_queuing and having even more atomics magic in
> block/block-backend.c), but I'll read the thread.
Hmm, what about making blk_aio_prwv non-static and calling
bdrv_co_pdiscard directly from IDE?
Paolo
- [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH, Hanna Czenczek, 2023/03/09
- Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH, Paolo Bonzini, 2023/03/09
- Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH,
Paolo Bonzini <=
- Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH, Hanna Czenczek, 2023/03/09
- Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH, Paolo Bonzini, 2023/03/09
- Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH, Kevin Wolf, 2023/03/09
- Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH, Fiona Ebner, 2023/03/10
- Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH, Kevin Wolf, 2023/03/10
- Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH, Paolo Bonzini, 2023/03/10
- Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH, Fiona Ebner, 2023/03/13
- Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH, Paolo Bonzini, 2023/03/13
- Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH, Kevin Wolf, 2023/03/13
- Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH, Paolo Bonzini, 2023/03/14