Re: [PATCH v2 5/8] iotests: connect stdin to /dev/null when running tests

[Thomas Huth]

On 03/03/2023 17.07, Daniel P. Berrangé wrote:
> Currently the tests have their stdin inherited from the test harness,
> meaning they are connected to a TTY. The QEMU processes spawned by
> certain tests, however, modify TTY settings and if the test exits
> abnormally the settings might not be restored.
>
> The python test harness thus has some logic which will capture the
> initial TTY settings and restore them once all tests are finished.
>
> This does not, however, take into account the possibility of many
> copies of the 'check' program running in parallel. With parallel
> execution, a later invokation may save the TTY state that QEMU has

s/invokation/invocation/

> already modified, and thus restore bad state leaving the TTY
> non-functional.
>
> None of the I/O tests shnould actually be interactive requiring

s/shnould/should/

> user input and so they should not require a TTY at all. To avoid
> this while TTY save/restore complexity we can connect the test
> stdin to /dev/null instead.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   tests/qemu-iotests/testrunner.py | 22 ++--------------------
>   1 file changed, 2 insertions(+), 20 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>