[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 10/19] migration: Clean up includes
From: |
Juan Quintela |
Subject: |
Re: [PATCH v4 10/19] migration: Clean up includes |
Date: |
Mon, 30 Jan 2023 05:11:48 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> wrote:
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:
>
>> * Markus Armbruster (armbru@redhat.com) wrote:
>>> "Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:
>>>
>>> > * Markus Armbruster (armbru@redhat.com) wrote:
>>> >> Clean up includes so that osdep.h is included first and headers
>>> >> which it implies are not included manually.
>>> >
>>> > That change doesn't seem to match the message; the patch is removing the
>>> > osdep.h include.
>>>
>>> It's the commit message scripts/clean-includes creates :)
>>>
>>> I can throw in another patch to the script so it mentions it also
>>> removes qemu/osdep.h from headers.
>>
>> Oh hmm it would be clearer;
>
> What about
>
> $GITSUBJ: Clean up includes
>
> Clean up includes so that osdep.h is included first in .c and not in
> .h, and headers which it implies are not included manually.
>
> This commit was created with scripts/clean-includes.
>
>
>> but OK then, so
>>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Sounds ok to me.
Reviewed-by: Juan Quintela <quintela@redhat.com>
- Re: [PATCH v4 19/19] Drop duplicate #include, (continued)
[PATCH v4 03/19] scripts/clean-includes: Skip symbolic links, Markus Armbruster, 2023/01/19
[PATCH v4 05/19] crypto: Clean up includes, Markus Armbruster, 2023/01/19
[PATCH v4 18/19] 9p: Drop superfluous include of linux/limits.h, Markus Armbruster, 2023/01/19
[PATCH v4 08/19] hw/tricore: Clean up includes, Markus Armbruster, 2023/01/19