[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] hw/smbios: Use qapi for SmbiosEntryPointType
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 2/3] hw/smbios: Use qapi for SmbiosEntryPointType |
Date: |
Tue, 26 Oct 2021 17:14:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/26/21 17:10, Eduardo Habkost wrote:
> This prepares for exposing the SMBIOS entry point type as a
> machine property on x86.
>
> Based on a patch from Daniel P. Berrangé.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> First version of this code was submitted at:
> https://lore.kernel.org/qemu-devel/20200908165438.1008942-5-berrange@redhat.com
>
> Changes from v2:
> * Rename "2_0"/"3_1" to "32"/"64", to
> make the names more QAPI-friendly (as underscores and dots are
> not allowed by QAPI)
> * Move definition from smbios.json back to machine.json
> (no need for a separate file just for one enum)
>
> Changes from v1:
> * Patch was split in two
> * Moved definition to smbios.json
> ---
> include/hw/firmware/smbios.h | 10 ++--------
> qapi/machine.json | 12 ++++++++++++
> 2 files changed, 14 insertions(+), 8 deletions(-)
> +##
> +# @SmbiosEntryPointType:
> +#
> +# @32: SMBIOS version 2.1 (32-bit) Entry Point
> +#
> +# @64: SMBIOS version 3.0 (64-bit) Entry Point
> +#
> +# Since: 6.1
6.2, otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> +##
> +{ 'enum': 'SmbiosEntryPointType',
> + 'data': [ '32', '64' ] }
>