[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/5] aspeed/wdt: Introduce a container for the MMIO region
From: |
Francisco Iglesias |
Subject: |
Re: [PATCH v2 1/5] aspeed/wdt: Introduce a container for the MMIO region |
Date: |
Thu, 21 Oct 2021 09:25:26 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On [2021 Oct 18] Mon 15:26:05, Cédric Le Goater wrote:
> On the AST2600, the 2nd watchdog timer can be controlled through the
> FMC controller to disable the alternate boot function. Next changes
> will map the WDT2 registers in the AST2600 FMC memory region. Add a
> container on top of the register region for this purpose.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
> ---
> include/hw/watchdog/wdt_aspeed.h | 1 +
> hw/watchdog/wdt_aspeed.c | 6 +++++-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/include/hw/watchdog/wdt_aspeed.h
> b/include/hw/watchdog/wdt_aspeed.h
> index f945cd6c5833..14e91acb1284 100644
> --- a/include/hw/watchdog/wdt_aspeed.h
> +++ b/include/hw/watchdog/wdt_aspeed.h
> @@ -28,6 +28,7 @@ struct AspeedWDTState {
> QEMUTimer *timer;
>
> /*< public >*/
> + MemoryRegion iomem_container;
> MemoryRegion iomem;
> uint32_t regs[ASPEED_WDT_REGS_MAX];
>
> diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c
> index 146ffcd71301..803e861a9c61 100644
> --- a/hw/watchdog/wdt_aspeed.c
> +++ b/hw/watchdog/wdt_aspeed.c
> @@ -275,9 +275,13 @@ static void aspeed_wdt_realize(DeviceState *dev, Error
> **errp)
> */
> s->pclk_freq = PCLK_HZ;
>
> + memory_region_init(&s->iomem_container, OBJECT(s),
> + TYPE_ASPEED_WDT ".container", ASPEED_WDT_REGS_MAX *
> 4);
> + sysbus_init_mmio(sbd, &s->iomem_container);
> +
> memory_region_init_io(&s->iomem, OBJECT(s), &aspeed_wdt_ops, s,
> TYPE_ASPEED_WDT, ASPEED_WDT_REGS_MAX * 4);
> - sysbus_init_mmio(sbd, &s->iomem);
> + memory_region_add_subregion(&s->iomem_container, 0x0, &s->iomem);
> }
>
> static Property aspeed_wdt_properties[] = {
> --
> 2.31.1
>
>
- [PATCH v2 0/5] aspeed/smc: Improve support for the alternate boot function, Cédric Le Goater, 2021/10/18
- [PATCH v2 1/5] aspeed/wdt: Introduce a container for the MMIO region, Cédric Le Goater, 2021/10/18
- [PATCH v2 4/5] aspeed/smc: Use a container for the flash mmio address space, Cédric Le Goater, 2021/10/18
- [PATCH v2 5/5] speed/sdhci: Add trace events, Cédric Le Goater, 2021/10/18
- [PATCH v2 2/5] aspeed: Initialize the watchdog device models before the FMC models, Cédric Le Goater, 2021/10/18
- [PATCH v2 3/5] aspeed/smc: Improve support for the alternate boot function, Cédric Le Goater, 2021/10/18