Re: ☠ Buildbot (GNU pspp CI): debian-buster-amd64 - failed compile (failure) compile (failure) '/home/buildbot/pspp-buildbot/get_test_results.sh debian-buster-amd64-build' (failure) (master)

[Friedrich Beckmann]

Hi Ben,

yes true - somebody using g_memdup2 in new code would need this glibfix.h. No 
problem if you want to change the fix. Maybe we can also just wait until newer 
glib is available in our oldest target distribution and then we can remove this 
altogether.

Fritz

> Am 11.07.2022 um 18:30 schrieb Ben Pfaff <blp@cs.stanford.edu>:
> 
> I'm glad you fixed it. I'm not so happy with the details of the fix because 
> it requires developers to realize that they need the fix and include a 
> special header for it. That kind of thing leads to repeated problems over 
> time.
> 
> I think that the attached commit would have fixed the problem without the 
> need for developers to know to include a header.
> 
> On Sun, Jul 10, 2022 at 2:54 PM Friedrich Beckmann 
> <friedrich.beckmann@gmx.de> wrote:
> The fix did not work on debian. I pushed a different fix.
> 
> > Am 09.07.2022 um 17:39 schrieb Ben Pfaff <blp@cs.stanford.edu>:
> >
> > I think I fixed this. I started a build.
> >
> 
> <0001-gui-Make-sure-header-wrapper-gets-used-for-widgets-n.patch>