pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Renaming


From: John Darrington
Subject: Re: Renaming
Date: Tue, 28 Feb 2006 18:29:54 +0800
User-agent: Mutt/1.5.9i

On Mon, Feb 27, 2006 at 06:22:19PM -0800, Ben Pfaff wrote:
     
     > file-handle-def.c
     > file-handle-def.h
     
     => file-handle.[ch] I think.

Won't this conflict with file-handle.q from src/language/data-io ?
     
     
     > lex-def.c                             identifier.c
     > lex-def.h                              identifier.h
     
     I would prefer token.[ch] because I would like to put more of the
     lexical knowledge here eventually.

I had to make this module specifically to allow the data files to be
read/written (they need to know which names are reserved words, so as
to prevent variables getting created with those names).  Perhaps the
lexer needs to be split up a bit, but I think it'd be a mistake to put
lexical knowledge into src/data.  In summary, this file's purpose is
much more specific than a tokenizer, and I think it should remain so.
     
     > som.c
     > som.h
     
     => manager.[ch]

Isn't this a bit vague ?

J'     
-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.


Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]