[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.7.9-350-g8d1e072

[Ben Pfaff]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".

The branch, master has been updated
       via  8d1e072157ee3c8273e328c491be3c8bf57452da (commit)
       via  38980bbfac573dcefe25021e0d9ff8a6894372ca (commit)
       via  f93823750113914727d641dd7e526349fe98cba0 (commit)
       via  d272a0e0664ced3e8e5bb2cde390ea0610a6b26e (commit)
       via  979d5363ef9b22cd865bba3b540d5f4974844f7e (commit)
       via  e7035a9f2cbdd6b630b7816ae01dc337ae9ece66 (commit)
       via  bd4d6e7453918842419ece33f378f94e0be4c9c9 (commit)
       via  c0ba07567e8385dfc2247efad50b6db64b86a05d (commit)
       via  6bf4567d7fcf5f0fa5805c4de24c13c2a7cfbbc9 (commit)
       via  b05cde73f4291705bba140d6ef9896a11616f3ff (commit)
       via  6d68ef1c07880851ffd30ae9420bb081cfc80767 (commit)
       via  0db42c2d683822e1252f17c2c81252a79e618d9c (commit)
      from  705c387fce174567cf17d01bf00625de103496d0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8d1e072157ee3c8273e328c491be3c8bf57452da
Author: Ben Pfaff <address@hidden>
Date:   Tue Sep 25 21:18:32 2012 -0700

    Suppress GCC 4.7 warnings by changes to code that make it less clear.
    
    I'm not entirely happy with these changes, because they make the code
    slightly less obvious.  However, it's still not really bad code, and
    it's convenient to have a warning-free build.

commit 38980bbfac573dcefe25021e0d9ff8a6894372ca
Author: Ben Pfaff <address@hidden>
Date:   Tue Sep 25 21:20:09 2012 -0700

    Suppress GCC 4.7 warnings due to unimplemented features.
    
    GCC 4.7 complains that the variables removed by this commit are
    assigned values that are not used.  Fair enough, so this commit
    removes them.

commit f93823750113914727d641dd7e526349fe98cba0
Author: Ben Pfaff <address@hidden>
Date:   Tue Sep 25 17:09:47 2012 -0700

    gnumeric-reader: Add cast to suppress warning.
    
    This suppresses a GCC warning for a mismatch between
    xmlInputCloseCallback, which takes a "void *" parameter, and
    gzclose(), which takes a "gzFile" (which is "struct gzFile_s *").
    
    This came up with an upgrade from "squeeze" to "wheezy".  I assume
    that a gzclose prototype became visible or that gzFile changed away
    from "void *".
    
    An alternative would be to write a trampoline to just transform one
    pointer type to the other, but the xmlReaderForIO() invocation
    already has one function cast so a second cast doesn't make it much
    worse.

commit d272a0e0664ced3e8e5bb2cde390ea0610a6b26e
Author: Ben Pfaff <address@hidden>
Date:   Tue Sep 25 17:03:10 2012 -0700

    split-file-dialog: Add use of unused variable in split_file_dialog().
    
    'selector' was assigned but never used, but here's a use.
    
    Reported by GCC 4.7.

commit 979d5363ef9b22cd865bba3b540d5f4974844f7e
Author: Ben Pfaff <address@hidden>
Date:   Tue Sep 25 17:02:21 2012 -0700

    Suppress warnings for suspicious use of "enum" constants.
    
    In each case, the code is using values of enums in valid ways that
    GCC 4.7 does not expect, so use a cast to suppress the warnings.

commit e7035a9f2cbdd6b630b7816ae01dc337ae9ece66
Author: Ben Pfaff <address@hidden>
Date:   Tue Sep 25 17:00:34 2012 -0700

    gui: Check return value of gtk_tree_model_get_iter().
    
    In these two cases the return value was assigned to a variable but
    never used.  This commit adds a check for the return value.

commit bd4d6e7453918842419ece33f378f94e0be4c9c9
Author: Ben Pfaff <address@hidden>
Date:   Tue Sep 25 15:54:43 2012 -0700

    cairo: Avoid deprecated pango_cairo_font_map_create_context().
    
    Pango 1.30 that is in Debian "wheezy" has marked this function as
    deprecated.  The replacement pango_font_map_create_context() was
    introduced in Pango 1.22, which was also in Debian "squeeze" (which
    had Pango 1.28), so it seems safe to switch without worrying about
    a Pango version check.

commit c0ba07567e8385dfc2247efad50b6db64b86a05d
Author: Ben Pfaff <address@hidden>
Date:   Tue Sep 25 15:47:04 2012 -0700

    Remove unused "finalize" functions.
    
    A finalize function that just calls into the parent class finalize
    function is a no-op that need not exist.

commit 6bf4567d7fcf5f0fa5805c4de24c13c2a7cfbbc9
Author: Ben Pfaff <address@hidden>
Date:   Tue Sep 25 15:36:50 2012 -0700

    Remove variables assigned to but never used.
    
    Each of the variables removed here was assigned a value that was
    never used, the assignment didn't have any useful side effects, and
    I don't see anything that the variable should have been used for.
    
    Found by GCC 4.7.

commit b05cde73f4291705bba140d6ef9896a11616f3ff
Author: Ben Pfaff <address@hidden>
Date:   Tue Sep 25 15:51:07 2012 -0700

    EXAMINE: Avoid useless call to casereader_count_cases().
    
    The return value is never used, and this call could have significant
    expense (it could cause the data to be read an extra time), so do not
    do it.
    
    Reported by GCC 4.7.

commit 6d68ef1c07880851ffd30ae9420bb081cfc80767
Author: Ben Pfaff <address@hidden>
Date:   Tue Sep 25 16:59:04 2012 -0700

    CROSSTABS: Fix bug in check for REPORT in general mode.
    
    Found by GCC 4.7.

commit 0db42c2d683822e1252f17c2c81252a79e618d9c
Author: Ben Pfaff <address@hidden>
Date:   Tue Sep 25 15:14:50 2012 -0700

    expressions: Fix coercion of numbers to booleans at top level.
    
    The check for the expected type in type_check() used the wrong
    constant (a node type instead of an expression type) and so the
    "if" test was never true.  Also, OP_NUM_TO_BOOLEAN is binary, not
    unary, so fixing just the test caused an assertion failure.
    
    This commit fixes both problems and adds a test.
    
    Found by GCC 4.7 report of a type mismatch.

-----------------------------------------------------------------------

Summary of changes:
 lib/gtk-contrib/psppire-sheet.c         |   23 ++---------------------
 src/data/data-in.c                      |    3 ---
 src/data/gnumeric-reader.c              |    5 +++--
 src/data/por-file-reader.c              |   10 +++++++---
 src/language/command.c                  |    4 ++--
 src/language/control/repeat.c           |    4 +---
 src/language/data-io/inpt-pgm.c         |    2 +-
 src/language/data-io/placement-parser.c |    2 +-
 src/language/data-io/save.c             |   10 ++++------
 src/language/expressions/evaluate.c     |    4 +---
 src/language/expressions/operations.def |   19 +++++++++++--------
 src/language/expressions/parse.c        |    7 ++++---
 src/language/stats/autorecode.c         |    7 ++++---
 src/language/stats/crosstabs.q          |    6 +++---
 src/language/stats/examine.c            |    2 --
 src/language/stats/factor.c             |    2 --
 src/language/stats/quick-cluster.c      |    5 ++---
 src/libpspp/hmapx.c                     |   10 ++++++----
 src/libpspp/range-tower.c               |    4 +---
 src/output/cairo.c                      |    4 +---
 src/ui/gui/autorecode-dialog.c          |    1 +
 src/ui/gui/customentry.c                |    4 +---
 src/ui/gui/pspp-sheet-view.c            |   19 +------------------
 src/ui/gui/psppire-dialog-action-rank.c |    8 ++------
 src/ui/gui/psppire-dialog.c             |   18 ------------------
 src/ui/gui/psppire-dictview.c           |    5 -----
 src/ui/gui/psppire-syntax-window.c      |    3 ---
 src/ui/gui/recode-dialog.c              |    1 +
 src/ui/gui/split-file-dialog.c          |    2 +-
 tests/language/expressions/parse.at     |   17 +++++++++++++++++
 tests/libpspp/heap-test.c               |   16 +---------------
 utilities/pspp-dump-sav.c               |    3 +--
 32 files changed, 80 insertions(+), 150 deletions(-)


hooks/post-receive
-- 
GNU PSPP