[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.6.1-548-g2c411
From: |
Ben Pfaff |
Subject: |
[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.6.1-548-g2c411d6 |
Date: |
Thu, 09 Apr 2009 14:11:43 +0000 |
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".
The branch, master has been updated
via 2c411d651e22704f60f117d944b9380a07d247fe (commit)
via 62c871225e944dbdb2a50e1253423952719145cf (commit)
from b11e0493376378e2a9bfff7cd76fdb32915abfd6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 2c411d651e22704f60f117d944b9380a07d247fe
Author: Ben Pfaff <address@hidden>
Date: Wed Apr 8 21:55:31 2009 -0700
Use Bob Jenkins lookup3 hash instead of FNV.
The Jenkins lookup3 hash is superior to FNV in collision resistance,
avalanching, and performance on systems that do not have fast
multiplication. It also provides a good way to combine the result of
a previous hashing step with the current hash, using its "basis" argument.
This commit replaces the PSPP implementation of FNV with the Jenkins
lookup3 hash and updates all the current users.
In addition, John Darrington pointed out that commit dd2e61b4a
"Make create_iconv() properly distinguish converters by name"
unintentionally introduced gratuitous hash collisions, by causing
all converters where tocode and fromcode were the same to hash to
value 0, and converters where tocode and fromcode were swapped to
hash to the same value as each other. Using the "basis" argument to
the Jenkins hash properly, instead of just attempting to combine
hash values with XOR, fixes this problem.
commit 62c871225e944dbdb2a50e1253423952719145cf
Author: Ben Pfaff <address@hidden>
Date: Wed Apr 8 21:39:22 2009 -0700
NPAR TESTS: Consistently order variables in summary statistics.
The set of variables in the NPAR TESTS specs structure was ordered
randomly, according to however the hash function happened to arrange them.
Sort them by variable name, instead, so that they always appear in
alphabetical order in, e.g., descriptive statistics output.
The particular hash function PSPP uses now tends to order variables
alphabetically anyhow. The next commit changes the PSPP hash functions,
so fixing this in advance prevents having to update any test output.
-----------------------------------------------------------------------
Summary of changes:
src/data/attributes.c | 6 +-
src/data/file-handle-def.c | 12 ++-
src/data/file-name.c | 6 +-
src/data/short-names.c | 8 +-
src/data/value-labels.c | 8 +-
src/data/value.c | 6 +-
src/data/variable.c | 4 +-
src/language/stats/autorecode.c | 4 +-
src/language/stats/crosstabs.q | 2 +-
src/language/stats/npar.q | 4 +-
src/libpspp/hash-functions.c | 196 ++++++++++++++++++++++++++++-----------
src/libpspp/hash-functions.h | 12 +-
src/libpspp/i18n.c | 2 +-
src/math/covariance-matrix.c | 11 +-
14 files changed, 182 insertions(+), 99 deletions(-)
hooks/post-receive
--
GNU PSPP
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.6.1-548-g2c411d6,
Ben Pfaff <=