Re: [PATCH] testsuite: disable poke.cmd/mmap-1.pk on Darwin (macOS)

[Jose E. Marchesi]

Hi Mohammad.

This is OK.  Better than relying on the (perhaps internal) host_triplet
of dejagnu.

Thanks.

> On macOS, /dev/zero is not mappable.
>
> 2024-03-16  Mohammad-Reza Nabipoor  <mnabipoor@gnu.org>
>
>       * testsuite/Makefile.am (check-DEJAGNU): Set `HOST_OS' env var.
>       * testsuite/lib/poke-dg.exp (dg-require): Add "no-darwin"
>       requirement.
>       * testsuite/poke.cmd/mmap-1.pk: Disable the test on Darwin.
> ---
>  ChangeLog                    | 7 +++++++
>  testsuite/Makefile.am        | 1 +
>  testsuite/lib/poke-dg.exp    | 5 +++++
>  testsuite/poke.cmd/mmap-1.pk | 1 +
>  4 files changed, 14 insertions(+)
>
> diff --git a/ChangeLog b/ChangeLog
> index 45bc9acf..d91bc925 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,10 @@
> +2024-03-16  Mohammad-Reza Nabipoor  <mnabipoor@gnu.org>
> +
> +     * testsuite/Makefile.am (check-DEJAGNU): Set `HOST_OS' env var.
> +     * testsuite/lib/poke-dg.exp (dg-require): Add "no-darwin"
> +     requirement.
> +     * testsuite/poke.cmd/mmap-1.pk: Disable the test on Darwin.
> +
>  2024-03-15  Andreas Klinger  <ak@it-klinger.de>
>  
>       * testsuite/poke.pickles/jpeg-test.pk: Fix trailing blank.
> diff --git a/testsuite/Makefile.am b/testsuite/Makefile.am
> index de3ae88a..5dc57f75 100644
> --- a/testsuite/Makefile.am
> +++ b/testsuite/Makefile.am
> @@ -25,6 +25,7 @@ if HAVE_DEJAGNU
>       if $(SHELL) -c "$$runtest --version" > /dev/null 2>&1; then \
>         echo set enable-bracketed-paste off > "$(top_builddir)/inputrc"; \
>         CC_FOR_TARGET="$(CC_FOR_TARGET)" CFLAGS_FOR_TARGET="$(CFLAGS)" \
> +       HOST_OS="$(host_os)" \
>         HAVE_LIBTEXTSTYLE="$(HAVE_LIBTEXTSTYLE)" \
>         NBDKIT="$(NBDKIT)" \
>         INPUTRC="$(top_builddir)/inputrc" \
> diff --git a/testsuite/lib/poke-dg.exp b/testsuite/lib/poke-dg.exp
> index d4c07342..1782095f 100644
> --- a/testsuite/lib/poke-dg.exp
> +++ b/testsuite/lib/poke-dg.exp
> @@ -86,6 +86,11 @@ proc dg-require { args } {
>          # Mark the test as unsupported
>          set do-what [list [lindex do-what 0] N P]
>      }
> +    if {[lindex $args 1] == "no-darwin" \
> +            && [string match "darwin*" $::env(HOST_OS)]} {
> +        # Mark the test as unsupported
> +        set do-what [list [lindex do-what 0] N P]
> +    }
>  }
>  
>  # Create a temporary data file containing the data specified as an
> diff --git a/testsuite/poke.cmd/mmap-1.pk b/testsuite/poke.cmd/mmap-1.pk
> index b61f60d3..61314180 100644
> --- a/testsuite/poke.cmd/mmap-1.pk
> +++ b/testsuite/poke.cmd/mmap-1.pk
> @@ -1,5 +1,6 @@
>  /* { dg-do run } */
>  /* { dg-require memzero } */
> +/* { dg-require no-darwin } */
>  
>  /* Check that it's possible to memory map /dev/zero. */